Exit from command without calling odo if port is not selected (#444)

Fix #443.

Author: dgolovin

src/openshift/url.ts

@@ -16,11 +16,15 @@ export class Url {
         const portsResult: CliExitData = await Url.odo.execute(`oc get service ${context.getName()}-${app.getName()} --namespace ${project.getName()} -o jsonpath="{range .spec.ports[*]}{.port}{','}{end}"`);
         let ports: string[] = portsResult.stdout.trim().split(',');
         ports = ports.slice(0, ports.length-1);
-        let port: string = ports[0];
-        if (ports.length > 1) {
+        let port: string;
+        if (ports.length === 1) {
+            port = ports[0];
+        } else if (ports.length > 1) {
             port = await vscode.window.showQuickPick(ports, {placeHolder: "Select port to expose"});
+        } else {
+            return Promise.reject(`Component '${context.getName()}' has no ports decalred.`);
         }
-        return Promise.resolve()
+        return port === undefined ? undefined : Promise.resolve()
             .then(async () => Url.odo.execute(`odo url create --port ${port} --project ${project.getName()} --app ${app.getName()} --component ${context.getName()}`))
             .then(() => `URL for component '${context.getName()}' successfully created`)
             .catch((err) => Promise.reject(`Failed to create URL for component '${context.getName()}'`));

test/openshift/url.test.ts

@@ -35,7 +35,7 @@ suite('Openshift/URL', () => {
 
         test('asks to select port if more that one exposed and returns message', async () => {
             execStub = sandbox.stub(OdoImpl.prototype, 'execute');
-            execStub.onFirstCall().resolves({error: null, stdout: 'port1,port2,port3', stderr: ''});
+            execStub.onFirstCall().resolves({error: null, stdout: 'port1,port2,port3,', stderr: ''});
             execStub.onSecondCall().resolves();
             sandbox.stub(vscode.window, 'showQuickPick').resolves('port1');
             const result = await Url.create(componentItem);
@@ -46,12 +46,22 @@ suite('Openshift/URL', () => {
 
         test('rejects when fails to create Url', () => {
             execStub = sandbox.stub(OdoImpl.prototype, 'execute');
-            execStub.onFirstCall().resolves({error: null, stdout: 'port1', stderr: ''});
+            execStub.onFirstCall().resolves({error: null, stdout: 'port1,', stderr: ''});
             execStub.onSecondCall().rejects();
 
             return Url.create(componentItem).catch((err) => {
                 expect(err).equals(`Failed to create URL for component '${componentItem.getName()}'`);
             });
         });
+
+        test('rejects when component has no ports declared', () => {
+            execStub = sandbox.stub(OdoImpl.prototype, 'execute');
+            execStub.onFirstCall().resolves({error: null, stdout: '', stderr: ''});
+            execStub.onSecondCall().rejects();
+
+            return Url.create(componentItem).catch((err) => {
+                expect(err).equals(`Component '${componentItem.getName()}' has no ports decalred.`);
+            });
+        });
     });
 });