added --show-multiarch=true param and latest tag

Author: msivasubramaniaan

src/deployment.ts

@@ -6,7 +6,7 @@
 import { KubernetesObject } from '@kubernetes/client-node';
 import * as path from 'path';
 import validator from 'validator';
-import { Disposable, QuickInputButtons, ThemeIcon, TreeItem, window } from 'vscode';
+import { Disposable, InputBox, QuickInputButtons, ThemeIcon, TreeItem, window } from 'vscode';
 import { CommandText } from './base/command';
 import { DeploymentPodObject, OpenShiftExplorer } from './explorer';
 import { Oc } from './oc/ocWrapper';
@@ -164,35 +164,24 @@ export class Deployment {
 
             disposables.push(inputBox.onDidAccept(async (_e) => {
                 //check url has image
-                if (inputBox.validationMessage === undefined && inputBox.value !== undefined) {
-                    inputBox.busy = true;
-                    inputBox.enabled = false;
-                    await Progress.execFunctionWithProgress(`Fetching Image info ${inputBox.value}`, async () => {
-                        if (! await Oc.Instance.hasImageInfo(inputBox.value)) {
-                            inputBox.validationMessage = 'Image referece is not valid'
-                        } else {
-                            inputBox.validationMessage = undefined;
-                        }
-                    });
-                    inputBox.enabled = true;
-                    inputBox.busy = false;
-                }
-
+                await Deployment.validateImageInfo(inputBox);
                 if (inputBox.validationMessage === undefined && inputBox.value !== undefined) {
                     resolve(inputBox.value);
                     inputBox.hide();
                     disposables.forEach(disposable => {disposable.dispose()});
                 }
             }));
 
-            disposables.push(inputBox.onDidTriggerButton((button) => {
+            disposables.push(inputBox.onDidTriggerButton(async (button) => {
                 if (button === QuickInputButtons.Back) {
                     inputBox.hide();
                     resolve(undefined);
                 } else if (button === cancelBtn) {
                     inputBox.hide();
                     resolve(null);
                 } else if (button === okBtn) {
+                    //check url has image
+                    await Deployment.validateImageInfo(inputBox);
                     if (inputBox.validationMessage === undefined && inputBox.value !== undefined) {
                         inputBox.hide();
                         resolve(inputBox.value);
@@ -205,6 +194,22 @@ export class Deployment {
         });
     }
 
+    private static async validateImageInfo(inputBox: InputBox): Promise<void> {
+        if (inputBox.validationMessage === undefined && inputBox.value !== undefined) {
+            inputBox.busy = true;
+            inputBox.enabled = false;
+            await Progress.execFunctionWithProgress(`Fetching Image info ${inputBox.value}`, async () => {
+                if (!await Oc.Instance.hasImageInfo(inputBox.value)) {
+                    inputBox.validationMessage = 'Image referece is not valid';
+                } else {
+                    inputBox.validationMessage = undefined;
+                }
+            });
+            inputBox.enabled = true;
+            inputBox.busy = false;
+        }
+    }
+
     /**
      * Prompt the user for the name of the deployment.
      *

src/oc/ocWrapper.ts

@@ -676,8 +676,9 @@ export class Oc {
     }
 
     public async hasImageInfo(url: string): Promise<boolean> {
+        const imageURL = url.lastIndexOf(':') < 0 ? `${url}:latest` : url;
         const result = await CliChannel.getInstance().executeTool(
-            new CommandText('oc', `image info ${url}`), undefined, false
+            new CommandText('oc', `image info ${imageURL} --show-multiarch=true`), undefined, false
         );
         return result.error && result.stderr.length > 0 ? false : true;
     }