Skip to content

Commit 7264bd3

Browse files
authored
fix macos and windows path for crc 1.34.0 (#2279)
* fix macos and windows path for crc 1.34.0 Signed-off-by: Mohit Suman <[email protected]> * fix space Signed-off-by: Mohit Suman <[email protected]>
1 parent b075cf9 commit 7264bd3

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

README.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
OpenShift Connector extension provides an end-to-end developer experience for Red Hat® OpenShift®. Using this extension:
1313
- Developers can easily create, deploy and live debug container applications running on OpenShift.
14-
- Run local instance of OpenShift 4.7 using [Red Hat CodeReady Containers](https://code-ready.github.io/crc/).
14+
- Run local instance of OpenShift 4.9.0 using [Red Hat CodeReady Containers](https://crc.dev/crc/).
1515

1616
### Demo: https://www.youtube.com/watch?v=HEsYgDqD1rM
1717

@@ -29,9 +29,6 @@ This extension can work with local or remote OpenShift clusters.
2929

3030
To provision local instance of OpenShift cluster, developers can use the following options:
3131
* [Red Hat CodeReady Containers](https://crc.dev/crc/) - run single node local OpenShift 4.x cluster
32-
* [minishift](http://bit.ly/3rSvzOx) / [CDK](http://red.ht/3opF1XC) - run single node local OpenShift 3.x cluster
33-
34-
For detail analysis of how to setup and run local OpenShift Cluster using minishift, please follow this [wiki](http://bit.ly/3be4jUv).
3532

3633
#### Public cloud providers
3734

@@ -47,7 +44,7 @@ To install OpenShift Container Platform 4 in the public cloud, in your datacente
4744
* `Application`: An application is a program designed for end users. An application consists of multiple microservices or components that work individually to build the entire application. Examples of applications: e-Shop, Hotel Reservation System, Online Booking
4845
* `Component`: A component is a set of Kubernetes resources which host code or data. Each component can be run and deployed separately. Examples of components: Warehouse API Backend, Inventory API, Web Frontend, Payment Backend
4946
* `Service`: A service is software that your component links to or depends on. Examples of services: MariaDB, MySQL
50-
* `Devfile`: A portable file responsible for your entire reproducable development environment
47+
* `Devfile`: A devfile is a portable YAML file containing the definition of a component and its related URLs, storages and services.
5148

5249
## Commands and Features
5350

@@ -114,7 +111,7 @@ Components in different states have different set of commands available.
114111
* `Push` - Push the source code to a Component.
115112
* `Watch` - Watch for changes, update Component on change. This is not supported for git based components.
116113
* `Undeploy` - Undeploys a Component from the cluster. The component still resides in the local config.
117-
* `Debug` - Debug local Java or Node.js Component.
114+
* `Debug` - Debug local Java, Node.js and Python Component.
118115
* `Test` - Run test for the Component in cluster.
119116
* `Reveal in Explorer` - Show Component's context folder in Explorer view
120117
* `Delete` - Delete existing Component from the cluster and removes the local config also.
@@ -231,7 +228,7 @@ OpenShift Connector extension provides ```Use Project``` command to switch betwe
231228

232229
**NOTE:** This extension is in Preview mode. The extension support for OpenShift is strictly experimental - assumptions may break, commands and behavior may change!
233230

234-
**NOTE:** CRC (Red Hat CodeReady Containers) version supported by the extension is `1.23.1` (OpenShift Version: `4.7.0`)
231+
**NOTE:** CRC (Red Hat CodeReady Containers) version supported by the extension is `1.34.0` (OpenShift Version: `4.9.0`)
235232

236233
## Dependencies
237234

package.json

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,20 @@
3838
}
3939
],
4040
"categories": [
41-
"Other"
41+
"Other",
42+
"Debuggers"
4243
],
4344
"keywords": [
44-
"openshift",
45-
"kubernetes",
46-
"redhat",
47-
"clusters",
45+
"OpenShift",
46+
"Kubernetes",
47+
"Red Hat",
48+
"Clusters",
4849
"k8s",
49-
"redhat",
50-
"crc",
51-
"codereadycontainers"
50+
"CRC",
51+
"CodeReady Containers",
52+
"devsandbox",
53+
"debuggers",
54+
"Cloud"
5255
],
5356
"icon": "images/openshift_extension.png",
5457
"main": "./out/src/extension",
@@ -1564,7 +1567,7 @@
15641567
"Title": "CRC Pull Secret Path",
15651568
"type": "string",
15661569
"default": null,
1567-
"description": "Provide the path where the pull secret file is present."
1570+
"description": "Path of image pull secret."
15681571
},
15691572
"openshiftConnector.crcCpuCores": {
15701573
"Title": "CRC Cpu Cores",

src/webview/cluster/app/clusterView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,8 @@ export default function addClusterView(props) {
269269
const fetchDownloadBinary = () => {
270270
const platform = (window as any).platform;
271271
let crcBundle = '';
272-
if (platform === 'darwin') crcBundle = 'crc-macos-amd64.tar.xz';
273-
if (platform === 'win32') crcBundle = 'crc-windows-amd64.zip';
272+
if (platform === 'darwin') crcBundle = 'crc-macos-amd64.pkg';
273+
if (platform === 'win32') crcBundle = 'crc-windows-installer.zip';
274274
if (platform === 'linux') crcBundle = 'crc-linux-amd64.tar.xz';
275275
return `${crcDefaults.DefaultCrcUrlBase}/${crcLatest}/${crcBundle}`;
276276
}

0 commit comments

Comments
 (0)