Skip to content

Commit 8c22223

Browse files
committed
Fix buttons to open external links in addCluster editor
Fix to repace 'vscode.open' to actual links in webview based editor. This PR fixes #2213. Signed-off-by: Denis Golovin [email protected]
1 parent 68656ef commit 8c22223

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/webview/cluster/app/cluster.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export default function Header() {
111111
<CardActions className={classes.cardButton}>
112112
<Tooltip title={list.tooltip} placement="top">
113113
<div>
114-
<a onClick={() => handleView(index)} style={{ textDecoration: 'none'}}>
114+
<a onClick={() => handleView(index)} style={{ textDecoration: 'none'}} href={clusterTypes[index].redirectLink}>
115115
<Button
116116
variant="contained"
117117
color="default"

src/webview/cluster/clusterViewLoader.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ export default class ClusterViewLoader {
8383

8484
@vsCommand('openshift.explorer.addCluster.openLaunchSandboxPage')
8585
static async openLaunchSandboxPage(url: string) {
86-
await vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(url));
86+
// fake command to report crc selection through telemetry
8787
}
8888

8989
@vsCommand('openshift.explorer.addCluster.openCreateClusterPage')
9090
static async openCreateClusterPage(url: string) {
91-
await vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(url));
91+
// fake command to report crc selection through telemetry
9292
}
9393

9494
@vsCommand('openshift.explorer.addCluster.openCrcAddClusterPage')

0 commit comments

Comments
 (0)