fix tslint errors

Author: mohitsuman

package-lock.json

@@ -506,7 +506,7 @@
     "@types/js-yaml": "^3.11.2",
     "@types/mkdirp": "^0.5.2",
     "@types/mocha": "^5.2.5",
-    "@types/node": "^10.12.10",
+    "@types/node": "^10.12.11",
     "@types/opn": "^5.1.0",
     "@types/request": "^2.48.1",
     "@types/shelljs": "^0.8.0",
@@ -523,9 +523,9 @@
     "proxyquire": "^2.1.0",
     "remap-istanbul": "^0.12.0",
     "sinon": "^7.1.1",
-    "sinon-chai": "^3.2.0",
+    "sinon-chai": "^3.3.0",
     "tslint": "^5.11.0",
-    "typescript": "^3.1.6",
+    "typescript": "^3.2.1",
     "vscode": "^1.1.21"
   },
   "dependencies": {

package.json

@@ -162,7 +162,7 @@ export class ToolsConfig {
         let detectedVersion: string;
         if (fs.existsSync(location)) {
             const version = new RegExp(`${cmd} v([\\d\\.]+)`);
-            const result = await Cli.getInstance().execute(`"${location}" version`);    
+            const result = await Cli.getInstance().execute(`"${location}" version`);
             if (result.stdout) {
                 const toolVersion: string[] = result.stdout.trim().split('\n').filter((value) => {
                     return value.match(version);

src/tools.ts

@@ -52,7 +52,7 @@ export class Progress {
                 location: vscode.ProgressLocation.Notification,
                 title},
                 async (progress: vscode.Progress<{increment: number, message: string}>, token: vscode.CancellationToken) => {
-                    let result = await odoctl.getInstance().execute(cmd, process.cwd(), false);
+                    const result = await odoctl.getInstance().execute(cmd, process.cwd(), false);
                     result.error ? reject(result.error) : resolve();
                 }
             );

src/util/progress.ts

@@ -7,7 +7,6 @@
 
 import { window, Terminal, TerminalOptions } from 'vscode';
 import * as path from 'path';
-import { Platform } from './platform';
 
 export class WindowUtil {
 

src/util/windowUtils.ts

@@ -17,11 +17,11 @@ import { activate } from '../src/extension';
 import { Cluster } from '../src/openshift/cluster';
 import { Application } from '../src/openshift/application';
 import { Catalog } from '../src/openshift/catalog';
-import { Component} from '../src/openshift/component';
-import { Project} from '../src/openshift/project';
-import { Service} from '../src/openshift/service';
-import { Storage} from '../src/openshift/storage';
-import { Url} from '../src/openshift/url';
+import { Component } from '../src/openshift/component';
+import { Project } from '../src/openshift/project';
+import { Service } from '../src/openshift/service';
+import { Storage } from '../src/openshift/storage';
+import { Url } from '../src/openshift/url';
 import packagejson = require('../package.json');
 
 const expect = chai.expect;
@@ -65,10 +65,10 @@ suite('openshift connector Extension', async () => {
 	});
 
     async function getStaticMethosToStub(osc: string[]): Promise<string[]> {
-        let mths: Set<string> = new Set();
-        osc.forEach(name => {
+        const mths: Set<string> = new Set();
+        osc.forEach((name) => {
             name.replace('.palette', '');
-            let segs: string[] = name.split('.');
+            const segs: string[] = name.split('.');
             let methName: string = segs[segs.length-1];
             methName = methName === 'delete'? 'del' : methName;
             !mths.has(methName) && mths.add(methName);
@@ -81,8 +81,8 @@ suite('openshift connector Extension', async () => {
         const registerTreeDataProviderStub = sandbox.stub(vscode.window, 'registerTreeDataProvider');
         sandbox.stub(vscode.window, 'showErrorMessage');
         await activate(context);
-        let cmds:string[] = await vscode.commands.getCommands();
-        let osc:string[] = cmds.filter((item) => item.includes('openshift.'));
+        const cmds: string[] = await vscode.commands.getCommands();
+        const osc: string[] = cmds.filter((item) => item.includes('openshift.'));
         expect(registerTreeDataProviderStub).calledOnce;
         const mths: string[] = await getStaticMethosToStub(osc);
         (<any>[Application, Catalog, Cluster, Component, Project, Service, Storage, Url]).forEach(async (item) => {
@@ -91,7 +91,7 @@ suite('openshift connector Extension', async () => {
                     sandbox.stub(item, name).resolves();
                 }
             });
-        })
+        });
         osc.forEach((item) => vscode.commands.executeCommand(item));
         expect(vscode.window.showErrorMessage).has.not.been.called;
     });

test/extension.test.ts

@@ -101,7 +101,7 @@ suite("odo", () => {
             };
             toolsStub.restore();
             toolsStub = sandbox.stub(ToolsConfig, 'detectOrDownload').resolves(path.join('segment1', 'segment2'));
-            let ctStub = sandbox.stub(WindowUtil, 'createTerminal').returns(termFake);
+            const ctStub = sandbox.stub(WindowUtil, 'createTerminal').returns(termFake);
             await odoCli.executeInTerminal('cmd');
             expect(termFake.sendText).calledOnce;
             expect(termFake.show).calledOnce;
@@ -205,7 +205,7 @@ suite("odo", () => {
             let e;
             try {
                 const result = await odoCli.getServiceTemplates();
-            } catch(err) {
+            } catch (err) {
                 e = err;
             }
 

test/odo.test.ts

@@ -38,8 +38,8 @@ suite('Openshift/Component', () => {
         const componentType = 'nodejs';
         const version = 'latest';
         const folder = { uri: { fsPath: 'folder' } };
-        let quickPickStub: sinon.SinonStub, 
-            inputStub: sinon.SinonStub, 
+        let quickPickStub: sinon.SinonStub,
+            inputStub: sinon.SinonStub,
             progressStub: sinon.SinonStub,
             progressCmdStub: sinon.SinonStub;
 
@@ -184,7 +184,7 @@ suite('Openshift/Component', () => {
             });
 
             test('happy path works', async () => {
-                
+
                 const result = await Component.create(appItem);
 
                 expect(result).equals(`Component '${componentItem.getName()}' successfully created`);

test/openshift/component.test.ts

@@ -56,7 +56,6 @@ suite('Progress Utility', () => {
     test('throw an error if a command fails', async () => {
         const error = new Error(errorMessage);
         execStub = sandbox.stub(OdoImpl.prototype, 'execute').rejects(error);
-        const spy = sandbox.spy(vscode.window, 'showErrorMessage');
         let e;
         try {
             await Progress.execWithProgress(options, steps, OdoImpl.getInstance());
@@ -70,9 +69,7 @@ suite('Progress Utility', () => {
     });
 
     test('execCmdWithProgress returned promice resolves in case of cmd finished sucessfully', () => {
-        const error = new Error(errorMessage);
         execStub = sandbox.stub(OdoImpl.prototype, 'execute').resolves({error: undefined, stdout: '', stderr: ''});
-        let e;
         Progress.execCmdWithProgress('title', 'cmd').catch(() => {
             expect.fail(true, false, 'returned promise should not be rejected');
         });

test/util/progress.test.ts

@@ -8,7 +8,6 @@
 import * as chai from 'chai';
 import * as sinonChai from 'sinon-chai';
 import * as sinon from 'sinon';
-import * as path from 'path';
 import * as fs from 'fs-extra';
 import { WatchUtil } from '../../src/util/watch';