Bump the typescript-eslint group with 2 updates (#802)

* Bump the typescript-eslint group with 2 updates

Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser).


Updates `@typescript-eslint/eslint-plugin` from 7.18.0 to 8.0.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.0.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 7.18.0 to 8.0.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.0.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: typescript-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>

* Address lint errors and adjust some lint rules

Signed-off-by: David Thompson <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: David Thompson <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Thompson <[email protected]>

Author: dependabot[bot]

.eslintrc.json

@@ -19,12 +19,14 @@
     "@typescript-eslint/no-unused-vars": [
       "warn",
       {
-        "argsIgnorePattern": "^_"
+        "argsIgnorePattern": "^_",
+        "caughtErrorsIgnorePattern": "^_"
       }
     ],
     "@typescript-eslint/no-namespace": "off",
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-unused-expressions": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
     "no-inner-declarations": "off"
   },

package-lock.json

@@ -454,8 +454,8 @@
     "@types/vscode": "^1.82.0",
     "@types/which": "^3.0.4",
     "@types/yauzl": "^2.10.3",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "axios": "^1.6.7",
     "chai": "^4.5.0",
     "chai-fs": "^2.0.0",

package.json

@@ -14,7 +14,7 @@ async function main() {
 
 		// Download VS Code, unzip it and run the integration test
 		await runTests({ extensionDevelopmentPath, extensionTestsPath });
-	} catch (err) {
+	} catch (_err) {
 		console.error('Failed to run tests');
 		process.exit(1);
 	}

src/test/vscodeTest/runTest.ts

@@ -154,7 +154,7 @@ export class ProjectGenerationWizard extends InputBox {
     try {
       const backButton: WebElement = await enclosing.findElement(By.className(backButtonClass));
       return backButton;
-    } catch (e) {
+    } catch (_e) {
       return undefined;
     }
   }
@@ -259,13 +259,13 @@ export class ProjectGenerationWizard extends InputBox {
 
     try {
       result.detail = await this.getStringFromChildElementByClassName(quickPickItem, 'quick-input-list-label-meta');
-    } catch (e) {
+    } catch (_e) {
       // there is no vscode.QuickPickItem.detail for this quick pick item
     }
 
     try {
       result.description = await this.getStringFromChildElementByClassName(quickPickItem, 'label-description');
-    } catch (e) {
+    } catch (_e) {
       // there is no vscode.QuickPickItem.description for this quick pick item
     }
     return result;

src/test/vscodeUiTest/ProjectGenerationWizard.ts

@@ -560,7 +560,7 @@ async function wizardExists(): Promise<boolean> {
     const enclosing: WebElement = input.getEnclosingElement();
     const title: WebElement = await enclosing.findElement(By.className('quick-input-title'));
     return (await title.getText()).includes('Quarkus Tools');
-  } catch (e) {
+  } catch (_e) {
     return false;
   }
 }

src/test/vscodeUiTest/suite/projectGenerationTest.ts

@@ -46,7 +46,7 @@ async function tryGetExtensionsJSON(apiUrl: string): Promise<APIExtension[]> {
       timeout: 30_000,
     });
     return response.data;
-  } catch (err) {
+  } catch (_err) {
     throw `Unable to reach ${apiUrl}`;
   }
 }
@@ -92,7 +92,7 @@ async function tryGetProjectBuffer(projectUrl: string): Promise<Buffer> {
       responseType: 'arraybuffer',
     });
     return response.data as Buffer;
-  } catch (err) {
+  } catch (_err) {
     throw 'Unable to download Quarkus project.';
   }
 }

src/utils/requestUtils.ts

@@ -92,7 +92,7 @@ function toDefaultWslPath(p: string): string {
 async function toWslPath(path: string): Promise<string> {
   try {
       return (await executeCommand("wsl", ["wslpath", "-u", `"${path.replace(/\\/g, "/")}"`])).trim();
-  } catch (error) {
+  } catch (_error) {
     return toDefaultWslPath(path);
   }
 }

src/utils/shellUtils.ts

@@ -20,7 +20,7 @@ import { BuildSupport } from "../../buildSupport/BuildSupport";
 import { ProjectLabelInfo } from "../../definitions/ProjectLabelInfo";
 import { TaskCreator } from "../debugging/TaskCreator";
 import { getQuarkusProject } from "../getQuarkusProject";
-import which = require("which");
+import * as which from "which";
 
 const NATIVE_IMAGE_DOCS_URI: Uri = Uri.parse('https://quarkus.io/guides/building-native-image');
 
@@ -93,7 +93,7 @@ function pathFromEnvHasNativeImage(envVarValue: string | undefined): boolean {
 async function hasNativeImageOnPath(): Promise<boolean> {
   try {
     return !! await which('native-image');
-  } catch (e) {
+  } catch (_e) {
     return false;
   }
 }

src/wizards/binary/buildBinary.ts

@@ -32,7 +32,7 @@ export function createTerminateDebugListener(): Disposable {
     try {
       checkHasPreLaunchTask(debugSession);
       quarkusDevTaskExe = await getPreLaunchTaskExecution(debugSession);
-    } catch (message) {
+    } catch (_message) {
       // debugger for a non Quarkus project has terminated
       // don't display an error message
       return;