Fix terminal not appearing when adding extensions

Signed-off-by: David Kwon <[email protected]>

Author: dkwon17

CHANGELOG.md

@@ -10,6 +10,7 @@
 
 ### Bug fixes
 
+ * Fix terminal not appearing when adding extensions with the Add Extensions command. See [#252](https://github.com/redhat-developer/vscode-quarkus/pull/252)
  * `quarkus.banner.enabled` marked as error. See [#249](https://github.com/redhat-developer/vscode-quarkus/issues/249)
  * Completion in non-Quarkus and non-MicroProfile project causes errors. See [#247](https://github.com/redhat-developer/vscode-quarkus/issues/247)
 

src/extension.ts

@@ -17,7 +17,7 @@ import * as requirements from './languageServer/requirements';
 
 import { VSCodeCommands, MicroProfileLS } from './definitions/constants';
 import { DidChangeConfigurationNotification, LanguageClientOptions, LanguageClient } from 'vscode-languageclient';
-import { ExtensionContext, commands, window, workspace } from 'vscode';
+import { ExtensionContext, commands, window, workspace, Terminal } from 'vscode';
 import { QuarkusContext } from './QuarkusContext';
 import { addExtensionsWizard } from './wizards/addExtensions/addExtensionsWizard';
 import { createTerminateDebugListener } from './wizards/debugging/terminateProcess';
@@ -29,6 +29,7 @@ import { WelcomeWebview } from './webviews/WelcomeWebview';
 import { QuarkusConfig } from './QuarkusConfig';
 import { registerConfigurationUpdateCommand, registerOpenURICommand, CommandKind } from './lsp-commands';
 import { registerYamlSchemaSupport, MicroProfilePropertiesChangeEvent } from './yaml/YamlSchema';
+import { terminalCommandRunner } from './terminal/terminalCommandRunner';
 
 let languageClient: LanguageClient;
 
@@ -39,6 +40,12 @@ export function activate(context: ExtensionContext) {
 
   context.subscriptions.push(createTerminateDebugListener());
   context.subscriptions.push(quarkusProjectListener.getQuarkusProjectListener());
+  context.subscriptions.push(terminalCommandRunner);
+  context.subscriptions.push(
+    window.onDidCloseTerminal((closedTerminal: Terminal) => {
+      terminalCommandRunner.dispose(closedTerminal.name);
+    })
+  );
 
   /**
    * Register Yaml Schema support to manage application.yaml

src/terminal/terminalCommandRunner.ts

@@ -44,19 +44,15 @@ class TerminalCommandRunner implements Disposable {
         });
     }
 
-    public onDidCloseTerminal(closedTerminal: Terminal): void {
-        try {
-            delete this.terminals[closedTerminal.name];
-        } catch (error) {
-            // ignore it.
-        }
-    }
-
-    public dispose(id?: string): void {
-        if (id) {
-            this.terminals[id].dispose();
+    public dispose(terminalName?: string): void {
+        if (terminalName && this.terminals[terminalName] !== undefined) {
+            this.terminals[terminalName].dispose();
+            delete this.terminals[terminalName];
         } else {
-            this.closeAllTerminals();
+            Object.keys(this.terminals).forEach((id: string) => {
+                this.terminals[id].dispose();
+                delete this.terminals[id];
+            });
         }
     }
 }