Skip to content

Commit 503f354

Browse files
committed
Use Node 20
Node 18 is EOL and has been for a bit, so we should use Node 20 wherever possible. Signed-off-by: David Thompson <davthomp@redhat.com>
1 parent f6aaeba commit 503f354

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ jobs:
8080
cp org.eclipse.lemminx/target/org.eclipse.lemminx*-uber.jar ../staging
8181
- name: Check Out VS Code XML
8282
uses: actions/checkout@v4
83-
- name: Set Up NodeJS
84-
uses: actions/setup-node@v4
85-
with:
86-
node-version: '18'
8783
- name: Install dependencies
8884
run: npm install -g typescript "@vscode/vsce" "ovsx"
8985
- name: Build vscode-xml
@@ -184,10 +180,6 @@ jobs:
184180
steps:
185181
- name: Check Out VS Code XML
186182
uses: actions/checkout@v4
187-
- name: Set Up NodeJS
188-
uses: actions/setup-node@v4
189-
with:
190-
node-version: '20'
191183
- name: Install dependencies
192184
run: npm install -g typescript "@vscode/vsce" "ovsx"
193185
- name: Download VSIX & LemMinX Server Uber Jar

package-lock.json

Lines changed: 11 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"@eslint/js": "^9.16.0",
7979
"@types/fs-extra": "^8.1.2",
8080
"@types/glob": "^7.1.4",
81-
"@types/node": "^18.17.1",
81+
"@types/node": "^20.19.9",
8282
"@types/vscode": "^1.37.0",
8383
"@types/yauzl": "^2.9.1",
8484
"@vscode/test-cli": "^0.0.10",

0 commit comments

Comments
 (0)