Decoded URI component on ref value (#1033)

* decodedURIComponent on ref value

Signed-off-by: msivasubramaniaan <[email protected]>

* fixed test case

Signed-off-by: msivasubramaniaan <[email protected]>

---------

Signed-off-by: msivasubramaniaan <[email protected]>

Author: msivasubramaniaan

src/languageservice/services/yamlSchemaService.ts

@@ -279,7 +279,7 @@ export class YAMLSchemaService extends JSONSchemaService {
       const handleRef = (next: JSONSchema): void => {
         const seenRefs = new Set();
         while (next.$ref) {
-          const ref = next.$ref;
+          const ref = decodeURIComponent(next.$ref);
           const segments = ref.split('#', 2);
           //return back removed $ref. We lost info about referenced type without it.
           next._$ref = next.$ref;

test/schemaValidation.test.ts

@@ -2027,4 +2027,31 @@ obj:
       ['Missing property "form".'] // not inclide provider error
     );
   });
+
+  it('URL-encoded characters in $ref', async () => {
+    // note that 'missing form property' is necessary to trigger the bug (there has to be some problem in both subSchemas)
+    // order of the object in `anyOf` is also important
+    const schema: JSONSchema = {
+      type: 'object',
+      properties: {
+        myProperty: {
+          $ref: '#/definitions/Interface%3Ctype%3E',
+        },
+      },
+      definitions: {
+        'Interface<type>': {
+          type: 'object',
+          properties: {
+            foo: {
+              type: 'string',
+            },
+          },
+        },
+      },
+    };
+    schemaProvider.addSchema(SCHEMA_ID, schema);
+    const content = `myProperty:\n  foo: bar`;
+    const result = await parseSetup(content);
+    assert.equal(result.length, 0);
+  });
 });