xfs images should not be frozen snapshots, but properly unmounted and fully quiesced

[keszybz]

Trying to mount e.g. https://download.fedoraproject.org/pub/fedora/linux/releases/32/Server/aarch64/images/Fedora-Server-32-1.6.aarch64.raw.xz in read-only mode results in a failure and warning from the kernel. 'mount -o ro,norecovery' needs to be used.
https://bugzilla.redhat.com/show_bug.cgi?id=1829792

I originally reported this against the kernel, but this is expected behaviour:

Anyway, this isn't really a bug per se, xfs requires "mount -o ro,norecovery" on a read-only device with a dirty journal (which is somewhat surprisingly the case with a frozen image)

The image should be properly unmounted and fully quiesced instead.

Lubomír Sedlář commented https://pagure.io/pungi/issue/1495#comment-715232:

The image is produced by image-factory inside Koji. Pungi triggers the build, but doesn't really have much say in how the image is built.

Here's the build for the particular image:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1497298
And the task:
https://koji.fedoraproject.org/koji/taskinfo?taskID=43660770

The image was configured by fedora-disk-server.ks file from https://pagure.io/fedora-kickstarts repo.

[sandeen]

I'd be happy to help out here - I'd ultimately like to remove this somewhat odd behavior from XFS but in the meantime I'd like to understand how these images are being generated, and perhaps we can also avoid it when the image gets built.

Thanks,
-Eric

[keszybz]

/cc @lsedlar