Skip to content

Commit 254b40d

Browse files
committed
Fix review comments
1 parent 94b94e2 commit 254b40d

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ documentation instead.
1616

1717
### Operator CI Pipeline
1818

19-
The Operator CI pipeline is a Tekton pipeline that can be triggered by a partner on on-premise
20-
infrastructure. The pipeline validates an Operator Bundle, builds it and install it to an OpenShift
21-
environment. After installation pre-flight tests are executed which validate that the Operator meets
22-
minimum requirements for Red Hat OpenShift Certification. If all preceding tasks pass the CI pipeline
19+
The Operator CI pipeline is a Tekton pipeline that can be triggered by a partner using on-premise
20+
infrastructure. The pipeline validates an Operator Bundle, builds it and installs it to an OpenShift
21+
environment. After installation, pre-flight tests are executed which validate that the Operator meets
22+
minimum requirements for Red Hat OpenShift Certification. If all preceding tasks pass, the CI pipeline
2323
optionally uploads results and submits a pull request to trigger the next stages of the operator
2424
certification workflow.
2525

docs/ci-cd.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This project uses GitHub actions for CI (tests, linters) and CD (deployment).
44

55
## Secrets
66

7-
Both deployment and E2E tests needs GitHub secrets to work properly.
7+
Both deployment and E2E tests need GitHub secrets to work properly.
88
The following secrets should be kept in the repository:
99

1010
| Secret name | Secret value | Purpose |

docs/developer-guide.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ git push origin <insert-branch-name>
202202

203203
#### Create an API Key
204204

205-
Contact a Pyxis admin to assist with this request. It must correspond to the
206-
`org_id` for the certification project under test.
205+
[File a ticket](https://url.corp.redhat.com/86973d1) with Pyxis admins to assist with this request.
206+
It must correspond to the `org_id` for the certification project under test.
207207

208208
## Making Changes to the Pipelines
209209

@@ -247,7 +247,7 @@ pip install ".[dev]"
247247

248248
### Tips
249249

250-
- If adding a new script - don't forget to add the entrypoint to setup.py
250+
- If adding a new script in the pipeline image - don't forget to add the entrypoint to setup.py
251251

252252
### Run Unit Tests, Code Style Checkers, etc.
253253

docs/pipeline-env-setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ oc create secret generic github-bot-token --from-literal github_bot_token=< BOT
132132

133133
### Prow-kubeconfig
134134
Hosted preflight tests are run on the separate cluster. To provision a cluster destined for the tests,
135-
the pipeline uses a Prowjob. Thus, to start the preflight test, there is needs to be a prow-specific
135+
the pipeline uses a Prowjob. Thus, to start the preflight test, there needs to be a prow-specific
136136
kubeconfig.
137137
- [ProwJob](https://github.com/kubernetes/test-infra/tree/master/prow)
138138
- [OperatorCI](https://docs.ci.openshift.org/docs/architecture/ci-operator/)

docs/rhc4tp-cluster.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ to prepare the RHC4TP clusters for use by the pipeline.
1212
oc create sa operator-pipelines -n default
1313
```
1414

15-
1. Create a Kubeconfig for the service account. It should be stored in the repository Ansible Vault.
15+
1. Create a kubeconfig for the service account. It should be stored in the repository Ansible Vault.
1616

1717
```bash
1818
clusterName=dev

scripts/copy-bundle.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ usage() {
77
[ -i BUNDLE_IMAGE a pull spec to a bundle image to copy ]
88
[ -n PKG_NAME the new operator package name ]
99
[ -v BUNDLE_VERSION the new operator version ]
10-
[ -r OCP_RANGE the new supported OpenShift version range ]
10+
[ -r OCP_RANGE the new supported OpenShift version range (see: https://url.corp.redhat.com/6e0ad44) ]
1111
[ -o OUTPUT_PATH a directory for the generated structure ]
1212
[ -h show this usage ]" 1>&2
1313
}

0 commit comments

Comments
 (0)