Skip to content

Commit 3d64a69

Browse files
committed
Enable signature verification on release pipeline and fix defaults
For signature verification to be truly optional, the 2 pub key related params needed to have default values.
1 parent cd6ffb4 commit 3d64a69

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

ansible/roles/operator-pipeline/templates/openshift/pipelines/operator-release-pipeline.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,12 @@ spec:
7373
description: >-
7474
The key within the Kubernetes Secret that contains the kerberos keytab for submitting IIB builds.
7575
default: krb5.keytab
76+
- name: signing_pub_secret_name
77+
description: The name of the Kubernetes Secret that contains the public key for verifying signatures.
78+
default: signing-pub-key
79+
- name: signing_pub_secret_key
80+
description: The key within the Kubernetes Secret that contains the public key for verifying signatures.
81+
default: sig-key.pub
7682
workspaces:
7783
- name: repository
7884
- name: results
@@ -469,9 +475,12 @@ spec:
469475
value: "$(params.pyxis_ssl_key_secret_key)"
470476
- name: pyxis_url
471477
value: "$(tasks.set-env.results.pyxis_url)"
472-
# TODO: remove it after ISV-1798 is done
478+
- name: signing_pub_secret_name
479+
value: "$(params.signing_pub_secret_name)"
480+
- name: signing_pub_secret_key
481+
value: "$(params.signing_pub_secret_key)"
473482
- name: verify_signature
474-
value: "false"
483+
value: "true"
475484
workspaces:
476485
- name: source
477486
workspace: repository

ansible/roles/operator-pipeline/templates/openshift/tasks/upload-signature.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ spec:
2323
default: "true"
2424
- name: signing_pub_secret_name
2525
description: The name of the Kubernetes Secret that contains the public key for verifying signatures.
26+
default: signing-pub-key
2627
- name: signing_pub_secret_key
2728
description: The key within the Kubernetes Secret that contains the public key for verifying signatures.
29+
default: sig-key.pub
2830
volumes:
2931
- name: pyxis-ssl-volume
3032
secret:

0 commit comments

Comments
 (0)