CVP-1871 subtasks: removed all numbered checks in skiplist

Author: LikhithaEda

.ansible-lint

@@ -16,14 +16,3 @@ skip_list:
   - command-instead-of-shell  # Use shell only when shell functionality is required
   # - yaml  # Violations reported by yamllint
   - line-length
-  - '102'   # No Jinja2
-  - '206'   # Variables should have spaces before and after: {{ var_name}}
-  - '301'   # All tasks should be named
-  - '302'   # Include should has tags
-  - '303'   # Use ":" YAML syntax when arguments are over 4
-  - '305'   # Variable should has space "{{ foo }}"
-  - '306'   # Shells that use pipes should set the pipefail option
-  - '403'   # Package installs should not use latest
-  - '502'   # Use chown module
-  - '601'   # trailing whitespace
-  - '602'   # line too long

roles/build_catalog_upstream/tasks/main.yml

@@ -1,6 +1,7 @@
 ---
 
-- fail:
+- name: "Fail when bundle format is not supported"
+  fail:
     msg: "Bundle format is not supported in manifest test yet !!!"
   when: operator_format == "bundle"
 

roles/build_image_bundle/tasks/main.yml

@@ -29,18 +29,18 @@
         mode: 0644
         remote_src: true
 
-    - set_fact:
+    - name: "Store operator directory name"
+      set_fact:
         operator_name: "{{ operator_dir | basename }}"
-
-    - set_fact:
         bundle_image: "{{ bundle_registry }}/{{ bundle_image_namespace }}/{{ operator_name }}:v{{ operator_version }}"
         clusterserviceversion_bundle_file_path: >
            "{{ operator_bundle_src_dir }}/{{ operator_name }}/{{
             operator_version }}/manifests/{{ operator_name }}.v{{
             operator_version }}.clusterserviceversion.yaml"
         annotation_file_path: "{{ operator_bundle_src_dir }}/{{ operator_name }}/{{ operator_version }}/metadata/annotations.yaml"
 
-    - set_fact:
+    - name: "Set csv file path"
+      set_fact:
         clusterserviceversion_bundle_file_path: "{{ operator_bundle_src_dir }}/{{ operator_name }}/{{ operator_version }}/{{ csv_file_path | basename }}"
       when: operator_format == "manifest"
 

roles/collect_modified_images/tasks/parse_image_names.yml

@@ -21,4 +21,4 @@
 - name: "parse and return image name when timestamp is after start_time"
   set_fact:
     pulled_images: "{{ pulled_images + [image] }}"
-  when: "{{ timestamp > deployment_start_time }}"
+  when: timestamp > deployment_start_time

roles/convert_bundle_image_to_dir/tasks/main.yml

@@ -4,7 +4,7 @@
     - name: Set input image
       set_fact:
         operator_input_image: "{{ operator_input_image | regex_replace('[A-z]*://', '') }}"
-        operator_input_local_image: "{{ operator_local_registry }}/{{ operator_input_image | regex_replace('[A-z]*://', '') | basename}}"
+        operator_input_local_image: "{{ operator_local_registry }}/{{ operator_input_image | regex_replace('[A-z]*://', '') | basename }}"
 
     - name: Remove previous input image from local registry
       shell: "{{ opm_container_tool }} rmi -f {{ operator_input_local_image }}"

roles/deploy_olm_operator/tasks/main.yml

@@ -20,7 +20,7 @@
       when:
         - quay_release_result is defined
         - quay_release_result.stdout is defined
-        - quay_release_result.stdout != ""
+        - quay_release_result.stdout|length > 0
         - quay_release_result.stdout != "null"
 
     - name: "Set quay release to the incremented one if exists"
@@ -29,7 +29,7 @@
       when:
         - quay_increment_release_result is defined
         - quay_increment_release_result.stdout is defined
-        - quay_increment_release_result.stdout != ""
+        - quay_increment_release_result.stdout|length > 0
 
     - name: "Append the -test suffix to the packageName"
       shell: "{{ yq_bin_path }} w -i {{ package_path }} 'packageName' '{{ package_name }}-test'"
@@ -112,7 +112,7 @@
       shell: "{{ oc_bin_path }} create -f {{ operator_work_dir }}/../scorecard.secret.yaml"
       environment:
         KUBECONFIG: "{{ kubeconfig_path }}"
-      when: scorecard_secret_result.stat.exists == True
+      when: scorecard_secret_result.stat.exists
 
     - name: "Create the subscription"
       shell: "{{ oc_bin_path }} create -f {{ olm_operator_files_path }}/subscription.yml"
@@ -141,7 +141,7 @@
         content: "{{ csv_describe_result.stdout }}"
         dest: "{{ work_dir }}/olm-operator-csv-debug.txt"
         mode: 0644
-      when: csv_describe_result.stdout != ""
+      when: csv_describe_result.stdout|length > 0
 
     - name: "Get the pod status of the deployed operator"
       shell: >
@@ -151,16 +151,16 @@
       ignore_errors: true
       environment:
         KUBECONFIG: "{{ kubeconfig_path }}"
-      when: csv_describe_result.stdout != ""
+      when: csv_describe_result.stdout|length > 0
 
     - name: "Output the operator pod log to a debug file"
       copy:
         content: "{{ operator_pod_result.stdout }}"
         dest: "{{ work_dir }}/olm-operator-pod-debug.txt"
         mode: 0644
       when:
-        - csv_describe_result.stdout != ""
-        - operator_pod_result.stdout != ""
+        - csv_describe_result.stdout|length > 0
+        - operator_pod_result.stdout|length > 0
 
     - name: "Get the pod container logs of the deployed operator"
       shell: >
@@ -170,16 +170,16 @@
       ignore_errors: true
       environment:
         KUBECONFIG: "{{ kubeconfig_path }}"
-      when: csv_describe_result.stdout != ""
+      when: csv_describe_result.stdout|length > 0
 
     - name: "Output the operator container log to a debug file"
       copy:
         content: "{{ operator_container_result.stdout }}"
         dest: "{{ work_dir }}/olm-operator-container-debug.txt"
         mode: 0644
       when:
-        - csv_describe_result.stdout != ""
-        - operator_container_result.stdout != ""
+        - csv_describe_result.stdout|length > 0
+        - operator_container_result.stdout|length > 0
 
     - name: "Get the catalogsource pod log"
       shell: >
@@ -233,7 +233,7 @@
     - name: "Get replicaset logs for operators that failed olm-deployment output"
       shell: >
         "{{ oc_bin_path }} get replicasets -o
-        go-template={%raw%}'{{range .items}}{{.status.conditions}}{{\"\\n\"}}{{end}}'{%endraw%}
+        go-template={%raw%}'{{ range .items }}{{ .status.conditions }}{{ \"\\n\" }}{{ end }}'{%endraw%}
         -n {{ openshift_namespace }}"
       register: olm_replicaset_output
       environment:

roles/deploy_olm_operator_upstream/tasks/main.yml

@@ -41,7 +41,7 @@
       when:
         - quay_release_result is defined
         - quay_release_result.stdout is defined
-        - quay_release_result.stdout != ""
+        - quay_release_result.stdout|length > 0
         - quay_release_result.stdout != "null"
 
     - name: "Set quay release to the incremented one if exists"
@@ -50,7 +50,7 @@
       when:
         - quay_increment_release_result is defined
         - quay_increment_release_result.stdout is defined
-        - quay_increment_release_result.stdout != ""
+        - quay_increment_release_result.stdout|length > 0
 
     - name: "Append the -test suffix to the packageName"
       shell: "{{ yq_bin_path }} w -i {{ package_path }} 'packageName' '{{ package_name }}-test'"
@@ -165,7 +165,7 @@
       shell: "{{ oc_bin_path }} create -f {{ operator_work_dir }}/../scorecard.secret.yaml"
       environment:
         KUBECONFIG: "{{ kubeconfig_path }}"
-      when: scorecard_secret_result.stat.exists == True
+      when: scorecard_secret_result.stat.exists
   when: not run_upstream|bool
 
 - name: "Wait for the operator {{ package_name }} to be in packagemanifests"
@@ -219,7 +219,7 @@
     content: "{{ csv_describe_result.stdout }}"
     dest: "{{ work_dir }}/olm-operator-csv-debug.txt"
     mode: 0644
-  when: csv_describe_result.stdout != ""
+  when: csv_describe_result.stdout|length > 0
 
 - name: "Get the pod status of the deployed operator"
   shell: >
@@ -230,16 +230,16 @@
   ignore_errors: true
   environment:
     KUBECONFIG: "{{ kubeconfig_path }}"
-  when: csv_describe_result.stdout != ""
+  when: csv_describe_result.stdout|length > 0
 
 - name: "Output the operator pod log to a debug file"
   copy:
     content: "{{ operator_pod_result.stdout }}"
     dest: "{{ work_dir }}/olm-operator-pod-debug.txt"
     mode: 0644
   when:
-    - csv_describe_result.stdout != ""
-    - operator_pod_result.stdout != ""
+    - csv_describe_result.stdout|length > 0
+    - operator_pod_result.stdout|length > 0
 
 - name: "Get the pod container logs of the deployed operator"
   shell: >
@@ -250,16 +250,16 @@
   ignore_errors: true
   environment:
     KUBECONFIG: "{{ kubeconfig_path }}"
-  when: csv_describe_result.stdout != ""
+  when: csv_describe_result.stdout|length > 0
 
 - name: "Output the operator container log to a debug file"
   copy:
     content: "{{ operator_container_result.stdout }}"
     dest: "{{ work_dir }}/olm-operator-container-debug.txt"
     mode: 0644
   when:
-    - csv_describe_result.stdout != ""
-    - operator_container_result.stdout != ""
+    - csv_describe_result.stdout|length > 0
+    - operator_container_result.stdout|length > 0
 
 - name: "Get the catalogsource pod log"
   shell: >

roles/deploy_olm_operator_upstream_bundle/tasks/main.yml

@@ -1,5 +1,6 @@
 ---
-- set_fact:
+- name: "Set initial data"
+  set_fact:
     quay_release: "0.0.1"
     upstream_namespace_param: "{{ '-n test-operators' if run_upstream else '' }}"
     olm_operator_files_path: /tmp/operator-test/olm-operator-files
@@ -112,7 +113,7 @@
     content: "{{ csv_describe_result.stdout }}"
     dest: "{{ work_dir }}/olm-operator-csv-debug.txt"
     mode: 0644
-  when: csv_describe_result.stdout != ""
+  when: csv_describe_result.stdout|length > 0
 
 - name: "Get the pod status of the deployed operator"
   shell: >
@@ -122,16 +123,16 @@
   ignore_errors: true
   environment:
     KUBECONFIG: "{{ kubeconfig_path }}"
-  when: csv_describe_result.stdout != ""
+  when: csv_describe_result.stdout|length > 0
 
 - name: "Output the operator pod log to a debug file"
   copy:
     content: "{{ operator_pod_result.stdout }}"
     dest: "{{ work_dir }}/olm-operator-pod-debug.txt"
     mode: 0644
   when:
-    - csv_describe_result.stdout != ""
-    - operator_pod_result.stdout != ""
+    - csv_describe_result.stdout|length > 0
+    - operator_pod_result.stdout|length > 0
 
 - name: "Get the pod container logs of the deployed operator"
   shell: >
@@ -141,16 +142,16 @@
   ignore_errors: true
   environment:
     KUBECONFIG: "{{ kubeconfig_path }}"
-  when: csv_describe_result.stdout != ""
+  when: csv_describe_result.stdout|length > 0
 
 - name: "Output the operator container log to a debug file"
   copy:
     content: "{{ operator_container_result.stdout }}"
     dest: "{{ work_dir }}/olm-operator-container-debug.txt"
     mode: 0644
   when:
-    - csv_describe_result.stdout != ""
-    - operator_container_result.stdout != ""
+    - csv_describe_result.stdout|length > 0
+    - operator_container_result.stdout|length > 0
 
 - name: "Get the catalogsource pod log (upstream)"
   shell: >

roles/detect_format/tasks/main.yml

@@ -1,7 +1,8 @@
 ---
 - name: Handle operator input image conversion
   block:
-    - set_fact:
+    - name: "Set image protocol"
+      set_fact:
         image_protocol: "docker-daemon:"
     - name: Handle operator image input
       include_role:

roles/export_csv/tasks/main.yml

@@ -28,10 +28,12 @@
         file_type: file
         patterns: '*.clusterserviceversion.yaml'
       register: csv_find_manifest
-    - fail:
+    - name: "Fail if there are no csv files"
+      fail:
         msg: "Could not find csv file in '{{ op_csv_dir }}'"
       when: csv_find_manifest.files|length == 0
-    - set_fact:
+    - name: "Set file path"
+      set_fact:
         csv_file_path: "{{ csv_find_manifest.files[0].path }}"
   when: operator_format == "manifest"