Use disks "by-path" instead of random name

Refactor find-node-disks to:
- Only access the first node (node_0) instead of looping through 3 nodes
- Extract disk devices using lsblk on the first node
- Convert /dev/sdX devices to their stable /dev/disk/by-path/... symlinks using udevadm
- Store all by-path device paths in common_disks variable for reliable disk identification

Author: cjeanner

ansible/roles/values-prep/tasks/find-node-disks.yml

@@ -1,23 +1,34 @@
 ---
-- name: Run lsblk on each node
+- name: Run lsblk on first node
   vars:
-    ip: "{{ lookup('vars', 'node_' ~ item ~ '_ip') }}"
+    ip: "{{ lookup('vars', 'node_0_ip') }}"
   ansible.builtin.shell:
     cmd: >-
       ssh core@{{ ip }} "lsblk -J -b -o NAME,TYPE,SIZE,MOUNTPOINT |
       jq -r '.blockdevices[] | select(.size > 0 and .type == \"disk\") |
       select((.children // []) | all(.mountpoint != \"/boot\")) | \"/dev/\" + .name'"
-  register: blk_outputs
-  loop: "{{ range(0,3) | list }}"
+  register: blk_output
+  changed_when: false
 
-- name: Extract device lists
-  ansible.builtin.set_fact:
-    node_disks_list: "{{ blk_outputs.results | map(attribute='stdout_lines') | list }}"
+- name: Get by-path device paths for each disk
+  vars:
+    ip: "{{ lookup('vars', 'node_0_ip') }}"
+  ansible.builtin.shell:
+    cmd: >-
+      ssh -o LogLevel=ERROR core@{{ ip }}
+      'udevadm info -q symlink -r --name="{{ item }}" |
+      awk '\''{ for (i = 1; i <= NF; i++) if ($i ~ /disk\/by-path\//) print $i }'\'''
+  register: by_path_outputs
+  loop: "{{ blk_output.stdout_lines }}"
+  changed_when: false
 
-- name: Find common devices across nodes
+- name: Extract by-path device list
   ansible.builtin.set_fact:
-    common_disks: "{{ node_disks_list[0] | intersect(node_disks_list[1]) | intersect(node_disks_list[2]) }}"
+    common_disks: "{{ by_path_outputs.results | selectattr('stdout', 'defined') | selectattr('stdout', 'ne', '') | map(attribute='stdout') | map('trim') | select('ne', '') | list }}"
 
 - name: Display common disks
   ansible.builtin.debug:
     msg: "{{ common_disks }}"
+
+- name: Stop playbook here
+  ansible.builtin.meta: end_play