chore: remove new/reset/old password handling

* This is clumsy and very unlikely these values will be an env variable.
* Nothing keeps people from securing it with a temporary export but it
  is not in scope for using stored env vars which tend to be static or
change rarely and thus makes more sense to concentrate on for this
feature.

Author: sadsfae

README.md

@@ -259,7 +259,7 @@ curl  https://raw.githubusercontent.com/redhat-performance/badfish/master/config
 
 ### Use Environment Variables for Secrets
 > [!IMPORTANT]
-> While you can pass `-u` and `-p` for user and password you should set environment variables instead.
+> While you can pass `-u` and `-p` for user and password env variables are more secure.
 >
 > `export BADFISH_USERNAME="my_username"`
 >
@@ -316,13 +316,13 @@ src/main.py --host-list /tmp/hosts -u root -p password -i config/idrac_interface
 ### Forcing a one time boot to a specific device
 To force systems to perform a one-time boot to a specific device on the next subsequent reboot you can use the ```--boot-to``` option and pass as an argument the device you want the one-time boot to be set to. This will change the one time boot BIOS attributes OneTimeBootMode and OneTimeBootSeqDev and on the next reboot it will attempt to PXE boot or boot from that interface string.  You can obtain the device list via the `--check-boot` directive below.
 ```bash
-badfish -H mgmt-your-server.example.com  --boot-to NIC.Integrated.1-3-1
+badfish -H mgmt-your-server.example.com --boot-to NIC.Integrated.1-3-1
 ```
 
 ### Forcing a one time boot to a specific mac address
 To force systems to perform a one-time boot to a specific mac address on the next subsequent reboot you can use the ```--boot-to-mac``` option and pass as an argument the device mac address for a specific NIC that you want the one-time boot to be set to. This will change the one time boot BIOS attributes OneTimeBootMode and OneTimeBootSeqDev and on the next reboot it will attempt to PXE boot or boot from that interface.
 ```bash
-badfish -H mgmt-your-server.example.com  --boot-to-mac A9:BB:4B:50:CA:54
+badfish -H mgmt-your-server.example.com --boot-to-mac A9:BB:4B:50:CA:54
 ```
 
 ### Forcing a one time boot to a specific type
@@ -344,25 +344,25 @@ badfish -H mgmt-your-server.example.com  -i config/idrac_interfaces.yml --pxe
 ### Rebooting a system
 In certain cases you might need to only reboot the host, for this case we included the ```--reboot-only``` flag which will force a GracefulRestart on the target host. Note that this option is not to be used with any other option.
 ```bash
-badfish -H mgmt-your-server.example.com  --reboot-only
+badfish -H mgmt-your-server.example.com --reboot-only
 ```
 
 ### Power cycling a system
 For a hard reset you can use ```--power-cycle``` flag which will run a ForceOff instruction on the target host. Note that this option is not to be used with any other option.
 ```bash
-badfish -H mgmt-your-server.example.com  --power-cycle
+badfish -H mgmt-your-server.example.com --power-cycle
 ```
 
 ### Power State Control
 You can also turn a server on or off by using options `--power-on` and `--power-off` respectively.
 ```bash
-badfish -H mgmt-your-server.example.com  --power-on
+badfish -H mgmt-your-server.example.com --power-on
 ```
 
 ### Check Power State
 For checking the current power state of a server you can run badfish with the `--power-state` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --power-state
+badfish -H mgmt-your-server.example.com --power-state
 ```
 Partial Output:
 ```
@@ -382,15 +382,15 @@ Partial Output:
 ### Resetting iDRAC
 For the replacement of `racadm racreset`, the optional argument `--racreset` was added. When this argument is passed to ```badfish```, a graceful restart is triggered on the iDRAC itself.
 ```bash
-badfish -H mgmt-your-server.example.com  --racreset
+badfish -H mgmt-your-server.example.com --racreset
 ```
 > [!NOTE]
 > Dell specific command, for Supermicro servers there is an equivalent of `--bmc-reset`
 
 ### Resetting BMC
 For the replacement of `ipmitool bmc reset` or `ipmiutil reset`, the optional argument `--bmc-reset` was added. When this argument is passed to ```badfish```, a graceful restart is triggered on the BMC itself.
 ```bash
-badfish -H mgmt-your-server.example.com  --bmc-reset
+badfish -H mgmt-your-server.example.com --bmc-reset
 ```
 > [!NOTE]
 > Supermicro specific command, for Dell servers there is an equivalent of `--racreset`
@@ -401,7 +401,7 @@ badfish -H mgmt-your-server.example.com  --bmc-reset
 
 You can restore BIOS default settings by calling Badfish with the option `--factory-reset`.
 ```bash
-badfish -H mgmt-your-server.example.com  --factory-reset
+badfish -H mgmt-your-server.example.com --factory-reset
 ```
 
 ### Check current boot order
@@ -413,7 +413,7 @@ badfish -H mgmt-your-server.example.com  -i config/idrac_interfaces.yml --check-
 ### Toggle boot device
 If you would like to enable or disable a boot device you can use ```--toggle-boot-device``` argument which takes the device name as input and will toggle the `Enabled` state from True to False and vice versa.
 ```bash
-badfish -H mgmt-your-server.example.com  --toggle-boot-device NIC.Integrated.1-3-1```
+badfish -H mgmt-your-server.example.com --toggle-boot-device NIC.Integrated.1-3-1```
 ```
 
 ### Variable number of retries
@@ -425,127 +425,127 @@ badfish -H mgmt-your-server.example.com  -i config/idrac_interfaces.yml -t forem
 ### Firmware inventory
 If you would like to get a detailed list of all the devices supported by iDRAC you can run ```badfish``` with the ```--firware-inventory``` option which will return a list of devices with additional device info.
 ```bash
-badfish -H mgmt-your-server.example.com  --firmware-inventory
+badfish -H mgmt-your-server.example.com --firmware-inventory
 ```
 
 ### Delta of firmware inventories
 If you would like to get a delta between firmware inventories of two servers, you can do so with the `--delta` option. This option takes a second host address as its argument. Only the firmware that's on both servers and has different versions will get displayed.
 ```bash
-badfish -H mgmt-your-server.example.com  --firmware-inventory --delta mgmt-your-other-server.example.com
+badfish -H mgmt-your-server.example.com --firmware-inventory --delta mgmt-your-other-server.example.com
 ```
 
 ### Clear Job Queue
 If you would like to clear all the jobs that are queued on the remote iDRAC you can run ```badfish``` with the ```--clear-jobs``` option which query for all active jobs in the iDRAC queue and will post a request to clear the queue.
 ```bash
-badfish -H mgmt-your-server.example.com  --clear-jobs
+badfish -H mgmt-your-server.example.com --clear-jobs
 ```
 
 You can also force the clearing of Dell iDRAC job queues by passing the `--force` option.
 
 ```bash
-badfish -H mgmt-your-server.example.com  --clear-jobs --force
+badfish -H mgmt-your-server.example.com --clear-jobs --force
 ```
 
 ### List Job Queue
 If you would like to list all active jobs that are queued on the remote iDRAC you can run ```badfish``` with the ```--ls-jobs``` option which query for all active jobs in the iDRAC queue and will return a list with all active items.
 ```bash
-badfish -H mgmt-your-server.example.com  --ls-jobs
+badfish -H mgmt-your-server.example.com --ls-jobs
 ```
 
 ### Check Job Status
 If you would like to the status of an existing LifeCycle controller job you can run ```badfish``` with the ```--check-job``` option and passing the job id which can be obtained via ```--ls-jobs```. This will return a detail of the specific job with status and percentage of completion.
 ```bash
-badfish -H mgmt-your-server.example.com  --check-job JID_340568202796
+badfish -H mgmt-your-server.example.com --check-job JID_340568202796
 ```
 
 ### Set Bios Password
 If you would like to set the bios password you can run ```badfish``` with the ```--set-bios-password``` option and passing the new password with ```--new-password```. If a password is already set you must pass this with ```--old-password``` otherwise optional.
 ```bash
-badfish -H mgmt-your-server.example.com  --set-bios-password --new-password new_pass --old-password old_pass
+badfish -H mgmt-your-server.example.com -u root --set-bios-password --new-password new_pass --old-password old_pass
 ```
 
 ### Remove Bios Password
 If you would like to remove the bios password you can run ```badfish``` with the ```--remove-bios-password``` option and passing the existing password with ```--old-password```.
 ```bash
-badfish -H mgmt-your-server.example.com  --remove-bios-password --old-password old_pass
+badfish -H mgmt-your-server.example.com -u root --remove-bios-password --old-password old_pass
 ```
 
 ### List Network Interfaces
 For getting a list of network interfaces with individual metadata for each you can run ```badfish``` with the ```--ls-interfaces``` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --ls-interfaces
+badfish -H mgmt-your-server.example.com --ls-interfaces
 ```
 
 ### List Memory
 For getting a detailed list of memory devices you can run ```badfish``` with the ```--ls-memory``` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --ls-memory
+badfish -H mgmt-your-server.example.com --ls-memory
 ```
 
 ### List Processors
 For getting a detailed list of processors you can run ```badfish``` with the ```--ls-processors``` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --ls-processors
+badfish -H mgmt-your-server.example.com --ls-processors
 ```
 
 ### List Serial Number or Service Tag
 For getting the system's serial number or on Dell servers the service tag (equivalent to `racadm getsvctag`) you can run ```badfish``` with the ```--ls-serial``` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --ls-serial
+badfish -H mgmt-your-server.example.com --ls-serial
 ```
 
 ### Check Virtual Media
 If you would like to check for any active virtual media you can run ```badfish``` with the ```--check-virtual-media``` option which query for all active virtual devices.
 ```bash
-badfish -H mgmt-your-server.example.com  --check-virtual-media
+badfish -H mgmt-your-server.example.com --check-virtual-media
 ```
 
 ### Mount Virtual Media
 If you would like to mount an ISO from network you can run ```badfish``` with the ```--mount-virtual-media``` option which post a request for mounting the ISO virtual media (Virtual CD). Full address to the ISO is needed as an argument.
 ```bash
-badfish -H mgmt-your-server.example.com  --mount-virtual-media http://storage.example.com/folder/linux.iso
+badfish -H mgmt-your-server.example.com --mount-virtual-media http://storage.example.com/folder/linux.iso
 ```
 
 ### Unmount Virtual Media
 If you would like to unmount all active virtual media you can run ```badfish``` with the ```--unmount-virtual-media``` option which post a request for unmounting all active virtual devices.
 ```bash
-badfish -H mgmt-your-server.example.com  --unmount-virtual-media
+badfish -H mgmt-your-server.example.com --unmount-virtual-media
 ```
 
 ### Boot to Virtual Media
 If you would like to boot to virtual media (Virtual CD) you can run ```badfish``` with the ```--boot-to-virtual-media``` option which sets the onetime next boot device to virtual CD.
 ```bash
-badfish -H mgmt-your-server.example.com  --boot-to-virtual-media
+badfish -H mgmt-your-server.example.com --boot-to-virtual-media
 ```
 
 ### Check Remote Image
 If you would like to check the attach status of a remote ISO in DellOSDeployment service you can run ```badfish``` with the ```--check-remote-image``` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --check-remote-image
+badfish -H mgmt-your-server.example.com --check-remote-image
 ```
 > [!NOTE]
 > This is only supported on DELL devices.
 
 ### Boot to Remote Image
 If you would like to boot to a remote ISO on NFS with DellOSDeployment service you can run ```badfish``` with the ```--boot-remote-image``` option which will attach the image and reboot the server to it. Expects the NFS path to the ISO as the argument.
 ```bash
-badfish -H mgmt-your-server.example.com  --boot-remote-image nfs-storage.example.com:/mnt/folder/linux.iso
+badfish -H mgmt-your-server.example.com --boot-remote-image nfs-storage.example.com:/mnt/folder/linux.iso
 ```
 > [!NOTE]
 > This is only supported on DELL devices.
 
 ### Detach Remote Image
 If you would like to detach an ISO from DellOSDeployment service you can run ```badfish``` with the ```--detach-remote-image``` option.
 ```bash
-badfish -H mgmt-your-server.example.com  --detach-remote-image
+badfish -H mgmt-your-server.example.com --detach-remote-image
 ```
 > [!NOTE]
 > This is only supported on DELL devices.
 
 ### Get SRIOV mode
 For checking if the global SRIOV mode is enabled you can use ```--get-sriov```
 ```bash
-badfish -H mgmt-your-server.example.com  --get-sriov
+badfish -H mgmt-your-server.example.com --get-sriov
 ```
 > [!NOTE]
 > This is only supported on DELL devices.
@@ -554,25 +554,25 @@ badfish -H mgmt-your-server.example.com  --get-sriov
 For changing the mode of the SRIOV glabal BIOS attribute, we have included 2 new arguments.
 In case the setting is in disabled mode, you can enable it by passing ```--enable-sriov```
 ```bash
-badfish -H mgmt-your-server.example.com  --enable-sriov
+badfish -H mgmt-your-server.example.com --enable-sriov
 ```
 On the contrary, if you would like to disable the SRIOV mode, you can now pass ```--disable-sriov```
 ```bash
-badfish -H mgmt-your-server.example.com  --disable-sriov
+badfish -H mgmt-your-server.example.com --disable-sriov
 ```
 > [!NOTE]
 > This is only supported on DELL devices.
 
 ### Get FQDDs for all nics
 To get a list of all FQDDs for all NICs on the server you can run badfish with ```--get-nic-fqdds```.
 ```bash
-badfish -H mgmt-your-server.example.com  --get-nic-fqdds
+badfish -H mgmt-your-server.example.com --get-nic-fqdds
 ```
 
 ### Get NIC attributes
 To get a list of all NIC attributes we can potentially modify (some might be set as read-only), you can run badfish with ```--get-nic-attribute``` passing the desired FQDD and this will return a list off all NIC attributes with their current value set.
 ```bash
-badfish -H mgmt-your-server.example.com  --get-nic-attribute NIC.Integrated.1-1-1
+badfish -H mgmt-your-server.example.com --get-nic-attribute NIC.Integrated.1-1-1
 ```
 
 ### Set NIC attribute
@@ -581,25 +581,25 @@ badfish -H mgmt-your-server.example.com  --get-nic-attribute NIC.Integrated.1-1-
 
 To change the value of a NIC attribute you can use ```--set-nic-attribute``` with the desired FQDD, passing both ```--attribute``` and desired ```--value```.
 ```bash
-badfish -H mgmt-your-server.example.com  --set-nic-attribute NIC.Integrated.1-1-1 --attribute LegacyBootProto --value PXE
+badfish -H mgmt-your-server.example.com --set-nic-attribute NIC.Integrated.1-1-1 --attribute LegacyBootProto --value PXE
 ```
 
 ### Get BIOS attributes
 To get a list of all BIOS attributes we can potentially modify (some might be set as read-only), you can run badfish with ```--get-bios-attribute``` alone and this will return a list off all BIOS attributes with their current value set.
 ```bash
-badfish -H mgmt-your-server.example.com  --get-bios-attribute
+badfish -H mgmt-your-server.example.com --get-bios-attribute
 ```
 
 ### Get specific BIOS attribute
 In case you would like to get a more detailed view on the parameters for a BIOS attribute you can run ```--get-bios-attribute``` including the specific name of the attribute via ```--attribute```.
 ```bash
-badfish -H mgmt-your-server.example.com  --get-bios-attribute --attribute ProcC1E
+badfish -H mgmt-your-server.example.com --get-bios-attribute --attribute ProcC1E
 ```
 
 ### Set BIOS attribute
 To change the value of a bios attribute you can use ```--set-bios-attribute``` passing both ```--attribute``` and ```--value```.
 ```bash
-badfish -H mgmt-your-server.example.com  --set-bios-attribute --attribute ProcC1E --value Enabled
+badfish -H mgmt-your-server.example.com --set-bios-attribute --attribute ProcC1E --value Enabled
 ```
 > [!NOTE]
 > You can get the list of allowed values you can pass for that attribute by looking at the attribute details via ```--get-bios-attribute``` for that specific one.
@@ -613,15 +613,15 @@ badfish -H mgmt-your-server.example.com  --set-bios-attribute --attribute ProcC1
 #### Querying bootmode
 * First determine what bootmode state your server is using before proceeding.
 ```bash
-badfish -H mgmt-your-server.example.com  --get-bios-attribute --attribute BootMode
+badfish -H mgmt-your-server.example.com --get-bios-attribute --attribute BootMode
 ```
 #### Setting UEFI mode
 ```bash
-badfish -H mgmt-your-server.example.com  --set-bios-attribute --attribute BootMode --value Uefi
+badfish -H mgmt-your-server.example.com --set-bios-attribute --attribute BootMode --value Uefi
 ```
 ### Setting BIOS mode
 ```bash
-badfish -H mgmt-your-server.example.com  --set-bios-attribute --attribute BootMode --value Bios
+badfish -H mgmt-your-server.example.com --set-bios-attribute --attribute BootMode --value Bios
 ```
 
 > [!IMPORTANT]
@@ -631,13 +631,13 @@ badfish -H mgmt-your-server.example.com  --set-bios-attribute --attribute BootMo
 ### Get server screenshot
 If you would like to get a screenshot with the current state of the server you can now run badfish with ```--screenshot``` which will capture this and store it in the current directory in png format.
 ```bash
-badfish -H mgmt-your-server.example.com  --screenshot
+badfish -H mgmt-your-server.example.com --screenshot
 ```
 
 ### Targets for server configuration profile
 If you want to get a list of allowed targets for SCP export or import you can get that with the `--get-scp-targets` command, takes either `Export` or `Import` as an argument.
 ```
-badfish -H mgmt-your-server.example.com  --get-scp-targets (Export | Import)
+badfish -H mgmt-your-server.example.com --get-scp-targets (Export | Import)
 ```
 > [!NOTE]
 > This is only supported on Dell devices.
@@ -646,23 +646,23 @@ badfish -H mgmt-your-server.example.com  --get-scp-targets (Export | Import)
 ### Export server configuration profile
 If you would like to export a SCP as a JSON file for either some specific targets or all of them, you can run badfish with `--export-scp` and specify a path where the config should be saved to with its argument. Targets can be specified with `--scp-targets` flag that takes a comma separated list of targets as an argument. Read only arguments can be included with the `--scp-include-read-only` flag.
 ```
-badfish -H mgmt-your-server.example.com  --export-scp "./" --scp-targets IDRAC,BIOS --scp-include-read-only
+badfish -H mgmt-your-server.example.com --export-scp "./" --scp-targets IDRAC,BIOS --scp-include-read-only
 ```
 > [!NOTE]
 > This is only supported on Dell devices.
 
 ### Import server configuration profile
 If you would like to import a SCP in a JSON file for either some specific targets or all of them, you can run badfish with `--import-scp`. Targets can be specified with `--scp-targets` flag that takes a comma separated list of targets as an argument. Command will reboot the server and return it to a state at the launch start of import.
 ```
-badfish -H mgmt-your-server.example.com  --import-scp "./example_export.json" --scp-targets IDRAC,BIOS
+badfish -H mgmt-your-server.example.com --import-scp "./example_export.json" --scp-targets IDRAC,BIOS
 ```
 > [!NOTE]
 > This is only supported on Dell devices.
 
 ### Bulk actions via text file with list of hosts
 In the case you would like to execute a common badfish action on a list of hosts, you can pass the optional argument ```--host-list``` in place of ```-H``` with the path to a text file with the hosts you would like to action upon and any addtional arguments defining a common action for all these hosts.
 ```bash
-badfish --host-list /tmp/bad-hosts  --clear-jobs
+badfish --host-list /tmp/bad-hosts --clear-jobs
 ```
 
 ### Verbose output
@@ -686,7 +686,7 @@ If you would like to easier query some information listed by badfish, you can te
 - `--check-virtual-media`
 - `--power-state`.
 ```bash
-badfish -H mgmt-your-server.example.com  --output json/yaml --firmware-inventory
+badfish -H mgmt-your-server.example.com --output json/yaml --firmware-inventory
 ```
 
 ## iDRAC and Data Format