feat: support auth via env vars#516
Merged
grafuls merged 18 commits intoredhat-performance:developmentfrom Feb 12, 2026
Merged
Conversation
* Add these new vars for safer badfishing - BADFISH_PASSWORD - BADFISH_USERNAME - BADFISH_NEW_PASSWORD - BADFISH_OLD_PASSWORD * Update venv example for PYTHONPATH fixes: redhat-performance#496
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #516 +/- ##
===============================================
+ Coverage 92.05% 92.07% +0.01%
===============================================
Files 8 8
Lines 2506 2511 +5
===============================================
+ Hits 2307 2312 +5
Misses 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* incorpoate some suggestions from @stephane-chazelas
grafuls
reviewed
Feb 12, 2026
* This is clumsy and very unlikely these values will be an env variable. * Nothing keeps people from securing it with a temporary export but it is not in scope for using stored env vars which tend to be static or change rarely and thus makes more sense to concentrate on for this feature.
grafuls
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add these new vars for safer badfishing
Update venv example for PYTHONPATH
fixes: #496