refactor: move badfish parameter validation to validate-vars role

Move the badfish parameter validation task from badfish/tasks/call.yml
to validate-vars/tasks/badfish_call.yml to centralize validation logic
in the validate-vars role.

Changes:
- Create validate-vars/tasks/badfish_call.yml with badfish parameter
  validation (badfish_host, badfish_user, badfish_password, badfish_args)
- Update badfish/tasks/call.yml to include validation via include_role
- Rename "Build badfish container command" task to "Build badfish command"

Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com>

Author: cjeanner

ansible/roles/badfish/tasks/call.yml

@@ -15,20 +15,11 @@
 #   retries: Number of retries (default: omit)
 
 - name: Validate required badfish parameters
-  ansible.builtin.assert:
-    that:
-      - badfish_host is defined
-      - badfish_host | length > 0
-      - badfish_user is defined
-      - badfish_user | length > 0
-      - badfish_password is defined
-      - badfish_password | length > 0
-      - badfish_args is defined
-      - badfish_args | length > 0
-    fail_msg: "Missing or empty required badfish parameters. Required: badfish_host, badfish_user, badfish_password, badfish_args"
-    quiet: true
+  ansible.builtin.include_role:
+    name: validate-vars
+    tasks_from: badfish_call
 
-- name: Build and run badfish container command
+- name: Build badfish command
   vars:
     _badfish_podman_cmd: >-
       {{

ansible/roles/validate-vars/tasks/badfish_call.yml

@@ -0,0 +1,17 @@
+---
+# Validate required badfish parameters for badfish call tasks
+
+- name: Validate required badfish parameters
+  ansible.builtin.assert:
+    that:
+      - badfish_host is defined
+      - badfish_host | length > 0
+      - badfish_user is defined
+      - badfish_user | length > 0
+      - badfish_password is defined
+      - badfish_password | length > 0
+      - badfish_args is defined
+      - badfish_args | length > 0
+    fail_msg: "Missing or empty required badfish parameters. Required: badfish_host, badfish_user, badfish_password, badfish_args"
+    quiet: true
+