Valid topics maps fail to build intermittently depending on size and/or location of maps

[gabriel-ocp]

Using the map in https://github.com/gabriel-ocp/ocp-bare-bones/blob/main/_topic_map.yml:

• Render the bare bones OCP repo using asciibinder build with top level _topic_map.yml - build works
• Move map into separate _topic_maps folder on its own and re-render - build fails
• Copy OSD topic map into folder and re-render OCP topic map - build works
• Remove chunk of OSD map and re-render OCP topic map - build fails
• Restore chunk of OSD map and re-render OCP topic map - build works

The exact steps for reproducing the problem are available at:

https://source.redhat.com/groups/public/gabrielocp/videos/ab_part01_reproducing_build_issuesmp4~1

[gabriel-ocp]

The problem seems to how the temporary file, which is used for combining multiple maps, is written and read.

https://stackoverflow.com/questions/18052966/ruby-how-to-write-to-tempfile recommends .close or .rewind

https://ruby-doc.org/stdlib-2.5.3/libdoc/tempfile/rdoc/Tempfile.html recommends .rewind

So the solution seems to be to add a tf.rewind after writing to the tmp file, before trying to read from it.

[vikram-redhat]

@gabriel-ocp I assume you have been able to test this?

[rohennes]

I have replicated the issue with my local asciibinder build. Using @gabriel-ocp's container image with his updated version of asciibinder, I verified the fixes worked as expected.