exclude status impact and test the rule

Author: sfavot

src/action/mod.rs

@@ -504,7 +504,7 @@ impl Action {
                 }
 
                 if trace.exclude_response_status_codes && !trace.on_response_status_codes.contains(&response_status_code) {
-                     self.apply_rule_id(Some(trace.id));
+                    self.apply_rule_id(Some(trace.id));
                 }
             }
         }

src/action/status_code_update.rs

@@ -18,8 +18,7 @@ impl StatusCodeUpdate {
             return (self.status_code, self.rule_id.clone());
         }
 
-        if self.exclude_response_status_codes && !self.on_response_status_codes.contains(&response_status_code)
-        {
+        if self.exclude_response_status_codes && !self.on_response_status_codes.contains(&response_status_code) {
             return (self.status_code, self.rule_id.clone());
         }
 

src/api/explain_request.rs

@@ -73,14 +73,14 @@ impl ExplainRequestOutput {
         let routes = router.match_request(&request);
         let mut action = Action::from_routes_rule(routes, &request, Some(&mut unit_trace));
 
-        let action_status_code = action.get_status_code(0, Some(&mut unit_trace));
+        let example_status_code = example.response_status_code.unwrap_or(0);
+        let action_status_code = action.get_status_code(example_status_code, Some(&mut unit_trace));
         let (final_status_code, backend_status_code) = if action_status_code != 0 {
             (action_status_code, action_status_code)
         } else {
-            // We call the backend and get a response code
             let backend_status_code = example.response_status_code.unwrap_or(200);
             let final_status_code = action.get_status_code(backend_status_code, Some(&mut unit_trace));
-            (final_status_code, backend_status_code)
+            (final_status_code, example_status_code)
         };
 
         let headers = action.filter_headers(Vec::new(), backend_status_code, false, Some(&mut unit_trace));

src/api/impact.rs

@@ -137,14 +137,14 @@ impl ImpactOutput {
             let routes = router.match_request(&request);
             let mut action = Action::from_routes_rule(routes, &request, Some(&mut unit_trace));
 
-            let action_status_code = action.get_status_code(0, Some(&mut unit_trace));
+            let example_status_code = example.response_status_code.unwrap_or(0);
+            let action_status_code = action.get_status_code(example_status_code, Some(&mut unit_trace));
             let (final_status_code, backend_status_code) = if action_status_code != 0 {
                 (action_status_code, action_status_code)
             } else {
-                // We call the backend and get a response code
                 let backend_status_code = example.response_status_code.unwrap_or(200);
                 let final_status_code = action.get_status_code(backend_status_code, Some(&mut unit_trace));
-                (final_status_code, backend_status_code)
+                (final_status_code, example_status_code)
             };
 
             let headers = action.filter_headers(Vec::new(), backend_status_code, false, Some(&mut unit_trace));

src/router/route.rs

@@ -83,7 +83,9 @@ impl<T: RouteData> Route<T> {
         self.methods.as_ref()
     }
 
-    pub fn exclude_methods(&self) -> Option<bool> { self.exclude_methods }
+    pub fn exclude_methods(&self) -> Option<bool> {
+        self.exclude_methods
+    }
 
     pub fn priority(&self) -> i64 {
         self.priority