feat(ffi): drop from raw, small typo fixes

Author: joelwurtz

src/action/ffi.rs

@@ -56,7 +56,7 @@ pub unsafe extern "C" fn redirectionio_action_drop(_action: *mut Action) {
         return;
     }
 
-    Box::from_raw(_action);
+    drop(Box::from_raw(_action));
 }
 
 #[no_mangle]
@@ -140,7 +140,7 @@ pub unsafe extern "C" fn redirectionio_action_body_filter_drop(_filter: *mut Fil
         return;
     }
 
-    Box::from_raw(_filter);
+    drop(Box::from_raw(_filter));
 }
 
 #[no_mangle]

src/ffi.rs

@@ -76,7 +76,7 @@ pub unsafe extern "C" fn redirectionio_router_drop(_router: *mut Router<Rule>) {
         return;
     }
 
-    Box::from_raw(_router);
+    drop(Box::from_raw(_router));
 }
 
 #[no_mangle]

src/filter/filter_body.rs

@@ -110,7 +110,7 @@ impl FilterBodyAction {
             data = if new_data.is_empty() { None } else { Some(new_data) };
         }
 
-        Ok(data.unwrap_or_else(|| Vec::new()))
+        Ok(data.unwrap_or_default())
     }
 }
 

src/html/mod.rs

@@ -6,7 +6,7 @@ use error::Result;
 use std::io::Read;
 use std::string::ToString;
 
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum TokenType {
     NoneToken,
     ErrorToken,

src/http/ffi.rs

@@ -214,5 +214,5 @@ pub unsafe extern "C" fn redirectionio_request_drop(_request: *mut Request) {
         return;
     }
 
-    Box::from_raw(_request);
+    drop(Box::from_raw(_request));
 }

src/router/transformer/slice.rs

@@ -8,7 +8,7 @@ pub struct Slice {
 impl Transform for Slice {
     fn transform(&self, str: String) -> String {
         let from = self.from;
-        let mut to = self.to.unwrap_or_else(|| str.len());
+        let mut to = self.to.unwrap_or(str.len());
 
         if from > str.len() {
             return "".to_string();