Skip to content

Commit 872b41e

Browse files
committed
Bump metrics version to v10
Revert to non-exponential histograms.
1 parent cc17d07 commit 872b41e

File tree

5 files changed

+6
-59
lines changed

5 files changed

+6
-59
lines changed

badges/coverage.svg

Lines changed: 1 addition & 1 deletion
Loading

dist/index.js

Lines changed: 2 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ describe('main.ts', () => {
147147
})
148148

149149
expect(mockOTLPExporter.OTLPMetricExporter).toHaveBeenCalledWith({
150-
aggregationPreference: expect.any(Function),
151150
url: 'http://localhost:4318/v1/metrics',
152151
headers: {
153152
'api-key': 'secret123',

src/main.ts

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,10 @@ import {
2626
} from '@opentelemetry/api'
2727

2828
import {
29-
AggregationSelector,
3029
MeterProvider,
31-
PeriodicExportingMetricReader,
32-
ViewOptions
30+
PeriodicExportingMetricReader
3331
} from '@opentelemetry/sdk-metrics'
34-
import { DEFAULT_AGGREGATION_SELECTOR } from '@opentelemetry/sdk-metrics/build/src/export/AggregationSelector.js'
35-
import { InstrumentType } from '@opentelemetry/sdk-metrics/build/src/export/MetricData.js'
3632

37-
import { AggregationType } from '@opentelemetry/sdk-metrics'
3833
import { randomUUID } from 'crypto'
3934
class CapturingDiagLogger implements DiagLogger {
4035
private baseLogger: DiagConsoleLogger
@@ -101,7 +96,7 @@ export async function run(): Promise<void> {
10196

10297
const metricsNamespace = core.getInput('metrics-namespace') || 'cae'
10398

104-
const metricsVersion = core.getInput('metrics-version') || 'v9'
99+
const metricsVersion = core.getInput('metrics-version') || 'v10'
105100

106101
const config: TMetricsConfig = {
107102
serviceName,
@@ -130,20 +125,7 @@ export async function run(): Promise<void> {
130125
[ATTR_DEPLOYMENT_ENVIRONMENT_NAME]: deploymentEnvironment
131126
})
132127

133-
const aggregationPreference: AggregationSelector = (t: InstrumentType) => {
134-
if (t === InstrumentType.HISTOGRAM) {
135-
return {
136-
type: AggregationType.EXPONENTIAL_HISTOGRAM,
137-
options: {
138-
recordMinMax: true
139-
}
140-
}
141-
}
142-
return DEFAULT_AGGREGATION_SELECTOR(t)
143-
}
144-
145128
const exporter = new OTLPMetricExporter({
146-
aggregationPreference,
147129
url: otlpEndpoint,
148130
headers,
149131
timeoutMillis: DEFAULT_TIMEOUT_MS
@@ -156,17 +138,7 @@ export async function run(): Promise<void> {
156138
})
157139
]
158140

159-
const view: ViewOptions = {
160-
instrumentType: InstrumentType.HISTOGRAM,
161-
aggregation: {
162-
type: AggregationType.EXPONENTIAL_HISTOGRAM,
163-
options: {
164-
recordMinMax: true
165-
}
166-
}
167-
}
168141
const meterProvider = new MeterProvider({
169-
views: [view],
170142
resource,
171143
readers
172144
})

0 commit comments

Comments
 (0)