Skip to content

Commit 9613af1

Browse files
committed
fix: remove incorrect skip decorator from alist deserialization test
The test_async_alist_with_deserialization test was incorrectly marked as skipped with a misleading comment claiming that alist() deserialization was not addressed in PR #87. However, the fix was already implemented in the alist() method via _recursive_deserialize() call at line 742 of aio.py. This commit: - Removes the @pytest.mark.skip decorator - Updates the docstring to accurately reflect that the fix is implemented - Ensures the test runs and validates proper message deserialization The test passes successfully, confirming that alist() properly deserializes LangChain messages when listing checkpoints.
1 parent 10a0c09 commit 9613af1

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

tests/test_issue_87_async_deserialization.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -478,16 +478,12 @@ async def test_async_mixed_content_types(redis_url: str):
478478

479479

480480
@pytest.mark.asyncio
481-
@pytest.mark.skip(
482-
reason="alist() deserialization not addressed in PR #87 - needs separate fix"
483-
)
484481
async def test_async_alist_with_deserialization(redis_url: str):
485482
"""Test that alist() also properly deserializes messages.
486483
487-
NOTE: This test is skipped because PR #87 only addresses aget_tuple()
488-
deserialization. The alist() method also needs the same fix applied
489-
to properly deserialize LangChain messages. This should be addressed
490-
in a follow-up PR.
484+
This test verifies that the alist() method properly deserializes
485+
LangChain messages when listing checkpoints, matching the behavior
486+
of aget_tuple().
491487
"""
492488
async with AsyncRedisSaver.from_conn_string(redis_url) as saver:
493489
thread_id = str(uuid4())

0 commit comments

Comments
 (0)