Skip to content

Commit c64dca9

Browse files
committed
test(checkpoint): fix serializer test helpers for checkpoint 3.0
Update dumps_helper/loads_helper to preserve full (type_str, bytes) tuple. Update test_dumps_typed_with_messages to expect bytes not str.
1 parent ea8340d commit c64dca9

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

tests/test_jsonplus_serializer_default_handler.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,20 @@
1616

1717
# Helper functions for backward compatibility with tests
1818
def dumps_helper(serializer: JsonPlusRedisSerializer, obj):
19-
"""Helper to simulate old dumps() method using dumps_typed()."""
20-
type_str, data_bytes = serializer.dumps_typed(obj)
21-
return data_bytes
19+
"""Helper to simulate old dumps() method using dumps_typed().
20+
21+
Returns the full (type_str, data_bytes) tuple to preserve type information.
22+
"""
23+
return serializer.dumps_typed(obj)
2224

2325

24-
def loads_helper(serializer: JsonPlusRedisSerializer, data_bytes):
25-
"""Helper to simulate old loads() method using loads_typed()."""
26-
# Assume JSON type for these tests
27-
return serializer.loads_typed(("json", data_bytes))
26+
def loads_helper(serializer: JsonPlusRedisSerializer, typed_data):
27+
"""Helper to simulate old loads() method using loads_typed().
28+
29+
Args:
30+
typed_data: Full (type_str, data_bytes) tuple from dumps_helper
31+
"""
32+
return serializer.loads_typed(typed_data)
2833

2934

3035
def test_serializer_uses_default_handler_for_messages():
@@ -153,7 +158,8 @@ def test_dumps_typed_with_messages():
153158
type_str, blob = serializer.dumps_typed(msg)
154159

155160
assert type_str == "json"
156-
assert isinstance(blob, str)
161+
# Checkpoint 3.0: dumps_typed now returns bytes, not str
162+
assert isinstance(blob, bytes)
157163

158164
# Deserialize
159165
deserialized = serializer.loads_typed((type_str, blob))

0 commit comments

Comments
 (0)