Update tests for RedisVL 0.4.0

Author: abrookins

tests/test_async.py

@@ -287,24 +287,26 @@ async def test_from_conn_string_errors() -> None:
     with pytest.raises(
         ValueError, match="Either redis_url or redis_client must be provided"
     ):
-        async with AsyncRedisSaver.from_conn_string() as _:
-            pass
+        async with AsyncRedisSaver.from_conn_string() as saver:
+            await saver.asetup()
 
     # Test with empty URL - should fail
     with pytest.raises(ValueError, match="REDIS_URL env var not set"):
-        async with AsyncRedisSaver.from_conn_string("") as _:
-            pass
+        async with AsyncRedisSaver.from_conn_string("") as saver:
+            await saver.asetup()
 
     # Test with invalid connection URL
     with pytest.raises(RedisConnectionError):
-        async with AsyncRedisSaver.from_conn_string("redis://nonexistent:6379") as _:
-            await _.asetup()  # Force connection attempt
+        async with AsyncRedisSaver.from_conn_string(
+            "redis://nonexistent:6379"
+        ) as saver:
+            await saver.asetup()
 
     # Test with non-functional client
     client = Redis.from_url("redis://nonexistent:6379")
     with pytest.raises(RedisConnectionError):
-        async with AsyncRedisSaver.from_conn_string(redis_client=client) as _:
-            await _.asetup()  # Force connection attempt
+        async with AsyncRedisSaver.from_conn_string(redis_client=client) as saver:
+            await saver.asetup()
 
 
 @pytest.mark.asyncio

tests/test_shallow_async.py

@@ -1,6 +1,8 @@
 from typing import Any, AsyncGenerator, Dict
 
 import pytest
+from redis.asyncio import Redis
+from redis.exceptions import ConnectionError as RedisConnectionError
 from langchain_core.runnables import RunnableConfig
 from langgraph.checkpoint.base import (
     Checkpoint,
@@ -208,3 +210,50 @@ async def test_sequential_writes(
     assert result.pending_writes is not None
     assert len(result.pending_writes) == 1
     assert result.pending_writes[0] == ("task1", "channel2", "value2")
+
+
+@pytest.mark.asyncio
+async def test_from_conn_string_errors(redis_url: str) -> None:
+    """Test proper cleanup of Redis connections."""
+    async with AsyncShallowRedisSaver.from_conn_string(redis_url) as s:
+        saver_redis = s._redis
+        assert await saver_redis.ping()
+
+    client = Redis.from_url(redis_url)
+    try:
+        async with AsyncShallowRedisSaver.from_conn_string(
+            redis_client=client
+        ) as saver:
+            assert saver._redis is client
+            assert await saver._redis.ping()
+        assert await client.ping()
+    finally:
+        await client.close()
+
+    """Test error conditions for from_conn_string."""
+    # Test with neither URL nor client provided
+    with pytest.raises(
+        ValueError, match="Either redis_url or redis_client must be provided"
+    ):
+        async with AsyncShallowRedisSaver.from_conn_string() as saver:
+            await saver.asetup()
+
+    # Test with invalid connection URL
+    with pytest.raises(RedisConnectionError):
+        async with AsyncShallowRedisSaver.from_conn_string(
+            "redis://nonexistent:6379"
+        ) as saver:
+            await saver.asetup()
+
+    # Test with non-responding client
+    client = Redis(host="nonexistent", port=6379)
+    with pytest.raises(RedisConnectionError):
+        async with AsyncShallowRedisSaver.from_conn_string(
+            redis_client=client
+        ) as saver:
+            await saver.asetup()
+
+    # Test with empty URL
+    with pytest.raises(ValueError, match="REDIS_URL env var not set"):
+        async with AsyncShallowRedisSaver.from_conn_string("") as saver:
+            await saver.asetup()

tests/test_shallow_sync.py

@@ -254,21 +254,21 @@ def test_from_conn_string_errors(redis_url: str) -> None:
     with pytest.raises(
         ValueError, match="Either redis_url or redis_client must be provided"
     ):
-        with ShallowRedisSaver.from_conn_string() as _:
-            pass
+        with ShallowRedisSaver.from_conn_string() as saver:
+            saver.setup()
 
     # Test with invalid connection URL
     with pytest.raises(RedisConnectionError):
-        with ShallowRedisSaver.from_conn_string("redis://nonexistent:6379") as _:
-            pass
+        with ShallowRedisSaver.from_conn_string("redis://nonexistent:6379") as saver:
+            saver.setup()
 
     # Test with non-responding client
     client = Redis(host="nonexistent", port=6379)
     with pytest.raises(RedisConnectionError):
-        with ShallowRedisSaver.from_conn_string(redis_client=client) as _:
-            pass
+        with ShallowRedisSaver.from_conn_string(redis_client=client) as saver:
+            saver.setup()
 
     # Test with empty URL
     with pytest.raises(ValueError, match="REDIS_URL env var not set"):
-        with ShallowRedisSaver.from_conn_string("") as _:
-            pass
+        with ShallowRedisSaver.from_conn_string("") as saver:
+            saver.setup()

tests/test_sync.py

@@ -337,24 +337,24 @@ def test_from_conn_string_errors() -> None:
     with pytest.raises(
         ValueError, match="Either redis_url or redis_client must be provided"
     ):
-        with RedisSaver.from_conn_string() as _:
-            pass
+        with RedisSaver.from_conn_string() as saver:
+            saver.setup()
 
     # Test with empty URL
     with pytest.raises(ValueError, match="REDIS_URL env var not set"):
-        with RedisSaver.from_conn_string("") as _:
-            pass
+        with RedisSaver.from_conn_string("") as saver:
+            saver.setup()
 
     # Test with invalid connection URL
     with pytest.raises(RedisConnectionError):
-        with RedisSaver.from_conn_string("redis://nonexistent:6379") as _:
-            pass
+        with RedisSaver.from_conn_string("redis://nonexistent:6379") as saver:
+            saver.setup()
 
     # Test with non-responding client
     client = Redis(host="nonexistent", port=6379)
     with pytest.raises(RedisConnectionError):
-        with RedisSaver.from_conn_string(redis_client=client) as _:
-            pass
+        with RedisSaver.from_conn_string(redis_client=client) as saver:
+            saver.setup()
 
 
 def test_large_batches(test_data: dict[str, Any], redis_url: str) -> None: