fix: cleanup blobs and writes for shallow classes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just noticed a second issue: Since none of the values get encoded, if any of This happens for langgraph where channels can for example be For now, will set this PR to draft and open an issue with detailed problem description --> #39 |
Contributor
|
@noelpenne can you test and rebase against main and see if the problem persists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to issue #13
This PR addresses an incomplete cleanup in
ShallowRedisSaverandAsyncShallowRedisSaverrelated to leftover blobs and writes.The initial fix (commit) did not fully remove all related keys. Specifically, the helper methods
_make_shallow_redis_checkpoint_blob_key_patternand_make_shallow_redis_checkpoint_writes_key_patterndid not apply theto_storage_safe_idandto_storage_safe_strutilities, which are used by the base class during blob dumping.As a result, when
checkpoint_nswas empty andchannel_versionswas populated, the cleanup logic failed to match and remove the correct keys — leading to orphaned blobs and write entries.This PR ensures consistency in key generation across dumping and cleanup, allowing complete and reliable deletion of checkpoint-related data.