cleanup ignore list parsing

Author: tylerhutcherson

.github/workflows/nightly-test.yml

@@ -21,11 +21,13 @@ jobs:
 
       - id: get_nbs
         run: |
-          # 1) Read the ignore list into an array
+          # 1) Read ignore patterns from .github/notebooks-ignore.txt
           IGNORE_LIST=()
-          while IFS= read -r skip_nb; do
+          while IFS= read -r skip_nb || [ -n "$skip_nb" ]; do
+            # Skip empty lines or comment lines
+            [[ -z "$skip_nb" || "$skip_nb" =~ ^# ]] && continue
             IGNORE_LIST+=("$skip_nb")
-          done < .github/ignore-notebooks.txt
+          done < .github/notebooks-ignore.txt
       
           # 2) Find all .ipynb in python-recipes (or your path)
           NBS=$(find python-recipes -name '*.ipynb')

.github/workflows/test.yml

@@ -26,13 +26,13 @@ jobs:
           git fetch --depth=1 origin main
           CHANGED_NOTEBOOKS=$(git diff --name-only origin/main | grep '\.ipynb$' || true)
       
-          # 1) Read ignore patterns from a file named notebooks-ignore.txt
+          # 1) Read ignore patterns from .github/notebooks-ignore.txt
           IGNORE_LIST=()
-          while IFS= read -r skip_nb; do
+          while IFS= read -r skip_nb || [ -n "$skip_nb" ]; do
+            # Skip empty lines or comment lines
+            [[ -z "$skip_nb" || "$skip_nb" =~ ^# ]] && continue
             IGNORE_LIST+=("$skip_nb")
-          done < .github/ignore-notebooks.txt
-
-          echo "All ignored notebooks: $IGNORE_LIST"
+          done < .github/notebooks-ignore.txt
 
           # 2) Filter out notebooks in CHANGED_NOTEBOOKS that match ignore patterns
           FILTERED_NBS=()