Adds self-contained docker environment for java-recipes #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbodden
force-pushed
the
bsb/java-resources
branch
from
72b9801 to
902bdb0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a self-contained Docker environment for the Java recipes project by introducing necessary configuration files and setup instructions. Key changes include:
- A comprehensive README outlining setup, running, and project structure details.
- A new docker-compose.yml file to orchestrate the Jupyter and Redis containers.
- An installation script (install.py) to configure the Java Jupyter kernel along with an environment specification file for Conda.
Reviewed Changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java-recipes/README.md | Adds detailed setup and usage instructions; note a potential directory name inconsistency. |
| java-recipes/docker-compose.yml | Introduces container definitions for Jupyter and Redis. |
| java-recipes/jupyter/install.py | Provides installation logic for the Java kernel; contains a minor spelling error in help text. |
| java-recipes/jupyter/environment.yml | Adds Conda environment dependencies for the Jupyter container. |
Files not reviewed (4)
- .github/ignore-notebooks.txt: Language not supported
- java-recipes/jupyter/Dockerfile: Language not supported
- java-recipes/jupyter/java/kernel.json: Language not supported
- java-recipes/jupyter/java/pom.xml: Language not supported
Comments suppressed due to low confidence (2)
java-recipes/README.md:50
- [nitpick] The directory name 'java-resources' appears inconsistent with the project folder 'java-recipes'. Please verify and update the directory name for clarity.
cd redis-ai-resources/java-resources
java-recipes/jupyter/install.py:133
- The word 'seperator' is misspelled; it should be corrected to 'separator'.
help="A file path seperator delimited list of `.jshell` scripts to run on startup. This includes ijava-jshell-init.jshell and ijava-display-init.jshell. **Important:** no matter what OS, this should use forward slash "/" as the file separator. Also each path may actually be a simple glob."
tylerhutcherson
approved these changes
Mar 20, 2025
Collaborator
tylerhutcherson
left a comment
tylerhutcherson
left a comment
There was a problem hiding this comment.
Really solid, Brian! I left a note or two about the readme and we should make sure to link to this from the main readme.
Once this gets merged in, let's make some noise in the spring community by sharing with maintainers, or other java spaces, and getting their eyeballs on this whole repo! Great work!
bsbodden
force-pushed
the
bsb/java-resources
branch
from
902bdb0 to
0c4e3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project uses JJava, a Jupyter kernel for Java based on JShell. This allows for interactive Java development in Jupyter notebooks.
Key components:
Java 21 for modern Java features
Maven for dependency management
JJava kernel for Jupyter integration
Currently 1 notebook showing RAG with Redis ann Spring AI