Skip to content

Commit aadc8ba

Browse files
committed
Rename StateSyncer -> StateManager
1 parent 37b1cfc commit aadc8ba

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

src/redis_release/bht/tree.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
from ..config import Config
2222
from ..github_client_async import GitHubClientAsync
23-
from ..state_manager import S3StateStorage, StateStorage, StateSyncer
23+
from ..state_manager import S3StateStorage, StateManager, StateStorage
2424
from .args import ReleaseArgs
2525
from .backchain import latch_chains
2626
from .behaviours import NeedToPublishRelease
@@ -102,14 +102,14 @@ def initialize_tree_and_state(
102102
args: ReleaseArgs,
103103
storage: Optional[StateStorage] = None,
104104
read_only: bool = False,
105-
) -> Iterator[Tuple[BehaviourTree, StateSyncer]]:
105+
) -> Iterator[Tuple[BehaviourTree, StateManager]]:
106106
github_client = GitHubClientAsync(token=os.getenv("GITHUB_TOKEN") or "")
107107

108108
if storage is None:
109109
storage = S3StateStorage()
110110

111111
# Create state syncer with storage backend and acquire lock
112-
with StateSyncer(
112+
with StateManager(
113113
storage=storage,
114114
config=config,
115115
args=args,

src/redis_release/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from redis_release.state_manager import (
1414
InMemoryStateStorage,
1515
S3StateStorage,
16-
StateSyncer,
16+
StateManager,
1717
)
1818

1919
from .bht.tree import TreeInspector, async_tick_tock, initialize_tree_and_state
@@ -137,7 +137,7 @@ def status(
137137
force_rebuild=[],
138138
)
139139

140-
with StateSyncer(
140+
with StateManager(
141141
storage=S3StateStorage(),
142142
config=config,
143143
args=args,

src/redis_release/state_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def release_lock(self, tag: str) -> bool:
145145
...
146146

147147

148-
class StateSyncer:
148+
class StateManager:
149149
"""Syncs ReleaseState to storage backend only when changed.
150150
151151
Can be used as a context manager to automatically acquire and release locks.
@@ -167,7 +167,7 @@ def __init__(
167167
self._lock_acquired = False
168168
self.read_only = read_only
169169

170-
def __enter__(self) -> "StateSyncer":
170+
def __enter__(self) -> "StateManager":
171171
if self.read_only:
172172
return self
173173
"""Acquire lock when entering context."""

src/tests/test_state.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from redis_release.bht.state import ReleaseState, Workflow
1010
from redis_release.config import Config, PackageConfig
1111
from redis_release.models import PackageType
12-
from redis_release.state_manager import InMemoryStateStorage, StateSyncer
12+
from redis_release.state_manager import InMemoryStateStorage, StateManager
1313

1414

1515
class TestReleaseStateFromConfig:
@@ -492,7 +492,7 @@ def test_state_syncer_sets_tag_from_args(self) -> None:
492492

493493
args = ReleaseArgs(release_tag="8.4-m01", force_rebuild=[])
494494
storage = InMemoryStateStorage()
495-
syncer = StateSyncer(storage=storage, config=config, args=args)
495+
syncer = StateManager(storage=storage, config=config, args=args)
496496

497497
assert syncer.state.meta.tag == "8.4-m01"
498498

@@ -518,7 +518,7 @@ def test_state_syncer_sets_force_rebuild_from_args(self) -> None:
518518

519519
args = ReleaseArgs(release_tag="8.4-m01", force_rebuild=["docker"])
520520
storage = InMemoryStateStorage()
521-
syncer = StateSyncer(storage=storage, config=config, args=args)
521+
syncer = StateManager(storage=storage, config=config, args=args)
522522

523523
assert syncer.state.packages["docker"].meta.ephemeral.force_rebuild is True
524524
assert syncer.state.packages["redis"].meta.ephemeral.force_rebuild is False
@@ -551,7 +551,7 @@ def test_state_syncer_sets_multiple_force_rebuild_from_args(self) -> None:
551551

552552
args = ReleaseArgs(release_tag="8.4-m01", force_rebuild=["docker", "snap"])
553553
storage = InMemoryStateStorage()
554-
syncer = StateSyncer(storage=storage, config=config, args=args)
554+
syncer = StateManager(storage=storage, config=config, args=args)
555555

556556
assert syncer.state.packages["docker"].meta.ephemeral.force_rebuild is True
557557
assert syncer.state.packages["redis"].meta.ephemeral.force_rebuild is False
@@ -573,7 +573,7 @@ def test_state_syncer_without_args(self) -> None:
573573

574574
args = ReleaseArgs(release_tag="test-tag", force_rebuild=[])
575575
storage = InMemoryStateStorage()
576-
syncer = StateSyncer(storage=storage, config=config, args=args)
576+
syncer = StateManager(storage=storage, config=config, args=args)
577577

578578
assert syncer.state.meta.tag == "test-tag"
579579
assert (
@@ -608,7 +608,7 @@ def test_state_syncer_force_rebuild_all(self) -> None:
608608

609609
args = ReleaseArgs(release_tag="8.4-m01", force_rebuild=["all"])
610610
storage = InMemoryStateStorage()
611-
syncer = StateSyncer(storage=storage, config=config, args=args)
611+
syncer = StateManager(storage=storage, config=config, args=args)
612612

613613
# All packages should have force_rebuild set to True
614614
assert syncer.state.packages["docker"].meta.ephemeral.force_rebuild is True
@@ -637,7 +637,7 @@ def test_state_syncer_force_rebuild_all_with_other_values(self) -> None:
637637

638638
args = ReleaseArgs(release_tag="8.4-m01", force_rebuild=["docker", "all"])
639639
storage = InMemoryStateStorage()
640-
syncer = StateSyncer(storage=storage, config=config, args=args)
640+
syncer = StateManager(storage=storage, config=config, args=args)
641641

642642
# All packages should have force_rebuild set to True
643643
assert syncer.state.packages["docker"].meta.ephemeral.force_rebuild is True

0 commit comments

Comments
 (0)