test: implement fixture-based validation for Enterprise API (#352) (#398)

* test: add fixture-based validation tests for Enterprise API

- Created generate-enterprise-fixtures.sh script to capture real API responses
- Generated 21 fixtures from live Docker Enterprise cluster
- Added fixture_validation_tests.rs with 8 tests validating type definitions
- All tests pass except 1 intentionally ignored (found type bug)

Findings:
- Discovered Module struct type mismatch: bigstore_version_2_support is bool in API but defined as map in struct
- Stats endpoints return arrays not objects
- All other core types (Cluster, Database, Node, User, License) deserialize correctly

This fixture-based approach will catch type mismatches that manual mocks miss,
addressing issues #347, #348, #351.

Related to #352

* fix: correct Module struct field types for crdb and dependencies

The fixture tests revealed that crdb and dependencies fields were incorrectly
typed. The API returns empty objects {} when these features are not used,
not boolean/array values.

Changes:
- crdb: Option<bool> → Option<Value> (handles {} empty objects)
- dependencies: Option<Vec<Value>> → Option<Value> (handles {} empty objects)

All 8 fixture validation tests now pass (previously 7/8 with 1 ignored).

This fix was discovered by the fixture-based testing approach - exactly the
type of bug it's designed to catch.

* feat: add Cloud fixture generation script and documentation

Added infrastructure for Cloud API fixture generation with important notes
about costs and data sanitization.

Changes:
- Created scripts/generate-cloud-fixtures.sh for capturing Cloud API responses
- Added crates/redis-cloud/tests/fixtures/README.md documenting approach
- Explains why Cloud fixtures require careful handling (costs, PII)
- Documents current wiremock-based testing approach

Note: Cloud fixtures not generated yet as it requires:
- Active Cloud account with resources
- Manual data sanitization
- Billable infrastructure

Enterprise fixtures are complete and working (8/8 tests passing).

Author: joshrotenberg

crates/redis-cloud/tests/fixtures/README.md

@@ -0,0 +1,40 @@
+# Redis Cloud API Fixtures
+
+## Current Status
+
+The Cloud API fixtures directory currently only contains the OpenAPI specification.
+
+## Why No Real Fixtures Yet?
+
+Unlike Enterprise API (which uses Docker for testing), Cloud API fixtures require:
+1. A real Cloud account with active resources
+2. Billable subscriptions and databases
+3. Careful sanitization of account data before committing
+
+## Generating Cloud Fixtures
+
+When you have a Cloud account with test resources, you can generate fixtures:
+
+```bash
+export REDIS_CLOUD_API_KEY="your-key"
+export REDIS_CLOUD_SECRET_KEY="your-secret"
+./scripts/generate-cloud-fixtures.sh
+```
+
+**Important**: Review all generated fixtures for sensitive data before committing!
+
+## Current Testing Approach
+
+Cloud API tests currently use wiremock with inline JSON mocks. This approach:
+- ✅ Works well for testing
+- ✅ No infrastructure required
+- ✅ No costs
+- ⚠️  Doesn't catch type mismatches from real API responses
+
+## Future Work
+
+To get the full benefits of fixture-based testing for Cloud:
+1. Use a test Cloud account with minimal resources
+2. Generate fixtures from real API responses
+3. Sanitize account/subscription IDs
+4. Add validation tests like Enterprise has

crates/redis-enterprise/src/modules.rs

@@ -38,11 +38,13 @@ pub struct Module {
     /// Redis command used to configure this module
     pub config_command: Option<String>,
 
-    /// Whether the module supports CRDB (Conflict-free Replicated Database)
-    pub crdb: Option<bool>,
+    /// CRDB (Conflict-free Replicated Database) configuration
+    /// The API returns an empty object {} for modules without CRDB support
+    pub crdb: Option<Value>,
 
-    /// List of other modules this module depends on
-    pub dependencies: Option<Vec<Value>>,
+    /// Module dependencies
+    /// The API returns an empty object {} for modules without dependencies
+    pub dependencies: Option<Value>,
 
     /// Contact email address of the module author
     pub email: Option<String>,

crates/redis-enterprise/tests/fixture_validation_tests.rs

@@ -0,0 +1,86 @@
+//! Fixture-based validation tests
+//!
+//! These tests use real API responses captured from a Redis Enterprise cluster
+//! to validate that our Rust type definitions accurately match the actual API.
+//!
+//! ## Fixed Issues
+//!
+//! - Module struct had type mismatches: crdb and dependencies were incorrectly typed
+//!   They should be Option<Value> to handle empty objects {} from API
+
+use redis_enterprise::{ClusterInfo, Database, License, Module, Node, User};
+use serde_json::Value;
+
+#[test]
+fn test_cluster_info_from_fixture() {
+    let fixture = include_str!("fixtures/cluster.json");
+    let cluster: ClusterInfo =
+        serde_json::from_str(fixture).expect("Failed to deserialize cluster info");
+    assert!(!cluster.name.is_empty());
+}
+
+#[test]
+fn test_database_list_from_fixture() {
+    let fixture = include_str!("fixtures/bdbs_list.json");
+    let databases: Vec<Database> =
+        serde_json::from_str(fixture).expect("Failed to deserialize database list");
+    assert!(!databases.is_empty());
+}
+
+#[test]
+fn test_single_database_from_fixture() {
+    let fixture = include_str!("fixtures/bdb_single.json");
+    let _database: Database =
+        serde_json::from_str(fixture).expect("Failed to deserialize single database");
+}
+
+#[test]
+fn test_nodes_list_from_fixture() {
+    let fixture = include_str!("fixtures/nodes_list.json");
+    let nodes: Vec<Node> = serde_json::from_str(fixture).expect("Failed to deserialize nodes list");
+    assert!(!nodes.is_empty());
+}
+
+#[test]
+fn test_users_list_from_fixture() {
+    let fixture = include_str!("fixtures/users_list.json");
+    let users: Vec<User> = serde_json::from_str(fixture).expect("Failed to deserialize users list");
+    assert!(!users.is_empty());
+}
+
+#[test]
+fn test_modules_list_from_fixture() {
+    let fixture = include_str!("fixtures/modules_list.json");
+    let modules: Vec<Module> =
+        serde_json::from_str(fixture).expect("Failed to deserialize modules list");
+
+    assert!(!modules.is_empty(), "Should have modules");
+
+    let module = &modules[0];
+    assert!(!module.uid.is_empty(), "Module should have UID");
+    assert!(module.module_name.is_some(), "Module should have name");
+}
+
+#[test]
+fn test_license_from_fixture() {
+    let fixture = include_str!("fixtures/license.json");
+    let _license: License = serde_json::from_str(fixture).expect("Failed to deserialize license");
+}
+
+#[test]
+fn test_stats_from_fixtures() {
+    // Test cluster stats
+    let cluster_stats: Value = serde_json::from_str(include_str!("fixtures/cluster_stats.json"))
+        .expect("Failed to deserialize cluster stats");
+    assert!(cluster_stats.is_object());
+
+    // Test database stats - these are arrays not objects
+    let db_stats: Value = serde_json::from_str(include_str!("fixtures/bdbs_stats.json"))
+        .expect("Failed to deserialize database stats");
+    assert!(db_stats.is_array());
+
+    // Test node stats - these are arrays not objects
+    let node_stats: Value = serde_json::from_str(include_str!("fixtures/nodes_stats.json"))
+        .expect("Failed to deserialize node stats");
+    assert!(node_stats.is_array());
+}

crates/redis-enterprise/tests/fixtures/actions_list.json

@@ -0,0 +1 @@
+{"actions":[{"action_uid":"8fc32a11-4688-4057-9237-cd77fccd726f","creation_time":"1760400087","name":"retry_bdb","node_uid":"1","progress":"100","status":"completed","task_id":"8fc32a11-4688-4057-9237-cd77fccd726f"}],"state-machines":[{"action_uid":"04d7b6ea-f377-4d40-9b23-9a8f291988df","heartbeat":1760400082,"name":"SMCreateBDB","object_name":"bdb:1","status":"completed"}]}

crates/redis-enterprise/tests/fixtures/bdb_groups_list.json

@@ -0,0 +1 @@
+{"bdb_groups":[]}

crates/redis-enterprise/tests/fixtures/bdb_single.json

@@ -1,185 +1 @@
-{
-  "acl": [],
-  "active_defrag_cycle_max": 25,
-  "active_defrag_cycle_min": 1,
-  "active_defrag_ignore_bytes": "104857600",
-  "active_defrag_max_scan_fields": 1000,
-  "active_defrag_threshold_lower": 10,
-  "active_defrag_threshold_upper": 100,
-  "activedefrag": "no",
-  "aof_policy": "appendfsync-every-sec",
-  "authentication_admin_pass": "6KioqIaX0iEU4BbQ5sMjE471Q5wljEuVz4nwFts3x34KDkbT",
-  "authentication_redis_pass": "",
-  "authentication_sasl_pass": "",
-  "authentication_sasl_uname": "",
-  "authentication_ssl_client_certs": [],
-  "authentication_ssl_crdt_certs": [],
-  "authorized_subjects": [],
-  "auto_upgrade": false,
-  "background_op": [
-    {
-      "status": "idle"
-    }
-  ],
-  "backup": false,
-  "backup_failure_reason": "",
-  "backup_history": 0,
-  "backup_interval": 86400,
-  "backup_progress": 0.0,
-  "backup_status": "",
-  "bigstore": false,
-  "bigstore_max_ram_ratio": 10,
-  "bigstore_ram_size": 0,
-  "bigstore_version": 1,
-  "client_cert_subject_validation_type": "disabled",
-  "compare_key_hslot": false,
-  "conns": 5,
-  "conns_type": "per-thread",
-  "crdt": false,
-  "crdt_causal_consistency": false,
-  "crdt_config_version": 0,
-  "crdt_ghost_replica_ids": "",
-  "crdt_guid": "",
-  "crdt_modules": "[]",
-  "crdt_repl_backlog_size": "auto",
-  "crdt_replica_id": 0,
-  "crdt_replicas": "",
-  "crdt_sources": [],
-  "crdt_sync": "disabled",
-  "crdt_sync_connection_alarm_timeout_seconds": 0,
-  "crdt_sync_dist": true,
-  "crdt_syncer_auto_oom_unlatch": true,
-  "crdt_xadd_id_uniqueness_mode": "strict",
-  "created_time": "2025-09-16T21:34:19Z",
-  "data_internode_encryption": false,
-  "data_persistence": "disabled",
-  "dataset_import_sources": [],
-  "db_conns_auditing": false,
-  "default_user": true,
-  "dns_address_master": "",
-  "dns_suffixes": [],
-  "email_alerts": false,
-  "endpoints": [
-    {
-      "addr": [
-        "192.168.32.2"
-      ],
-      "addr_type": "external",
-      "dns_name": "redis-11657.docker-cluster",
-      "oss_cluster_api_preferred_endpoint_type": "ip",
-      "oss_cluster_api_preferred_ip_type": "internal",
-      "port": 11657,
-      "proxy_policy": "single",
-      "uid": "2:1"
-    }
-  ],
-  "eviction_policy": "volatile-lru",
-  "export_failure_reason": "",
-  "export_progress": 0.0,
-  "export_status": "",
-  "flush_on_fullsync": true,
-  "generate_text_monitor": false,
-  "gradual_src_max_sources": 1,
-  "gradual_src_mode": "disabled",
-  "gradual_sync_max_shards_per_source": 1,
-  "gradual_sync_mode": "auto",
-  "group_uid": 0,
-  "hash_slots_policy": "16k",
-  "implicit_shard_key": false,
-  "import_failure_reason": "",
-  "import_progress": 0.0,
-  "import_status": "",
-  "internal": false,
-  "last_changed_time": "2025-09-16T21:34:19Z",
-  "master_persistence": false,
-  "max_aof_file_size": 322122547200,
-  "max_aof_load_time": 3600,
-  "max_client_pipeline": 200,
-  "max_connections": 0,
-  "max_pipelined": 2000,
-  "maxclients": 10000,
-  "memory_size": 107374182,
-  "metrics_export_all": false,
-  "mkms": true,
-  "module_list": [
-    {
-      "module_args": "",
-      "module_id": "4e6efe7fa848e35cbae142dd1e4564a2",
-      "module_name": "search",
-      "semantic_version": "7.99.91"
-    },
-    {
-      "module_args": "",
-      "module_id": "b14385b09778a335835ee3ae380bbc77",
-      "module_name": "bf",
-      "semantic_version": "8.0.1"
-    },
-    {
-      "module_args": "",
-      "module_id": "259bc961ae0ed766d6294bcdb7af9039",
-      "module_name": "ReJSON",
-      "semantic_version": "7.99.3"
-    },
-    {
-      "module_args": "",
-      "module_id": "891142de155df09c6739543b422178f4",
-      "module_name": "timeseries",
-      "semantic_version": "8.0.2"
-    }
-  ],
-  "mtls_allow_outdated_certs": false,
-  "mtls_allow_weak_hashing": false,
-  "multi_commands_opt": "auto",
-  "name": "test-db",
-  "oss_cluster": false,
-  "oss_cluster_api_preferred_endpoint_type": "ip",
-  "oss_cluster_api_preferred_ip_type": "internal",
-  "oss_sharding": false,
-  "port": 0,
-  "proxy_policy": "single",
-  "rack_aware": false,
-  "recovery_wait_time": -1,
-  "redis_cluster_enabled": false,
-  "redis_version": "8.0",
-  "repl_backlog_size": "auto",
-  "replica_read_only": false,
-  "replica_sources": [],
-  "replica_sync": "disabled",
-  "replica_sync_connection_alarm_timeout_seconds": 0,
-  "replica_sync_dist": true,
-  "replication": false,
-  "resp3": true,
-  "roles_permissions": [],
-  "sched_policy": "cmp",
-  "shard_block_crossslot_keys": false,
-  "shard_block_foreign_keys": true,
-  "shard_key_regex": [],
-  "shard_list": [
-    1
-  ],
-  "sharding": false,
-  "shards_count": 1,
-  "shards_placement": "dense",
-  "skip_import_analyze": "disabled",
-  "slave_buffer": "auto",
-  "slave_ha": false,
-  "slave_ha_priority": 0,
-  "snapshot_policy": [],
-  "ssl": false,
-  "status": "active",
-  "support_syncer_reconf": true,
-  "sync": "disabled",
-  "sync_dedicated_threads": 5,
-  "sync_sources": [],
-  "syncer_log_level": "info",
-  "syncer_mode": "distributed",
-  "throughput_ingress": 0,
-  "tls_mode": "disabled",
-  "topology_epoch": 1,
-  "tracking_table_max_keys": 1000000,
-  "type": "redis",
-  "uid": 2,
-  "use_selective_flush": true,
-  "version": "8.0.0",
-  "wait_command": true
-}
+{"acl":[],"active_defrag_cycle_max":25,"active_defrag_cycle_min":1,"active_defrag_ignore_bytes":"104857600","active_defrag_max_scan_fields":1000,"active_defrag_threshold_lower":10,"active_defrag_threshold_upper":100,"activedefrag":"no","aof_policy":"appendfsync-every-sec","authentication_admin_pass":"MTRp3pu6VGSojFkfw5v1iiHFnU3NYFvUHtoMDybsZAufxDfL","authentication_redis_pass":"","authentication_sasl_pass":"","authentication_sasl_uname":"","authentication_ssl_client_certs":[],"authentication_ssl_crdt_certs":[],"authorized_subjects":[],"auto_upgrade":false,"background_op":[{"status":"idle"}],"backup":false,"backup_failure_reason":"","backup_history":0,"backup_interval":86400,"backup_progress":0.0,"backup_status":"","bigstore":false,"bigstore_max_ram_ratio":10,"bigstore_ram_size":0,"bigstore_version":1,"client_cert_subject_validation_type":"disabled","compare_key_hslot":false,"conns":5,"conns_type":"per-thread","crdt":false,"crdt_causal_consistency":false,"crdt_config_version":0,"crdt_ghost_replica_ids":"","crdt_guid":"","crdt_modules":"[]","crdt_repl_backlog_size":"auto","crdt_replica_id":0,"crdt_replicas":"","crdt_sources":[],"crdt_sync":"disabled","crdt_sync_connection_alarm_timeout_seconds":0,"crdt_sync_dist":true,"crdt_syncer_auto_oom_unlatch":true,"crdt_xadd_id_uniqueness_mode":"strict","created_time":"2025-10-14T00:01:22Z","data_internode_encryption":false,"data_persistence":"disabled","dataset_import_sources":[],"db_conns_auditing":false,"default_user":true,"dns_address_master":"","dns_suffixes":[],"email_alerts":false,"endpoints":[{"addr":["192.168.16.2"],"addr_type":"external","dns_name":"redis-14968.docker-cluster","oss_cluster_api_preferred_endpoint_type":"ip","oss_cluster_api_preferred_ip_type":"internal","port":14968,"proxy_policy":"single","uid":"1:1"}],"eviction_policy":"volatile-lru","export_failure_reason":"","export_progress":0.0,"export_status":"","flush_on_fullsync":true,"generate_text_monitor":false,"gradual_src_max_sources":1,"gradual_src_mode":"disabled","gradual_sync_max_shards_per_source":1,"gradual_sync_mode":"auto","group_uid":0,"hash_slots_policy":"16k","implicit_shard_key":false,"import_failure_reason":"","import_progress":0.0,"import_status":"","internal":false,"last_changed_time":"2025-10-14T00:01:22Z","master_persistence":false,"max_aof_file_size":322122547200,"max_aof_load_time":3600,"max_client_pipeline":200,"max_connections":0,"max_pipelined":2000,"maxclients":10000,"memory_size":1073741824,"metrics_export_all":false,"mkms":true,"module_list":[{"module_args":"","module_id":"891142de155df09c6739543b422178f4","module_name":"timeseries","semantic_version":"8.0.2"},{"module_args":"","module_id":"4e6efe7fa848e35cbae142dd1e4564a2","module_name":"search","semantic_version":"7.99.91"},{"module_args":"","module_id":"b14385b09778a335835ee3ae380bbc77","module_name":"bf","semantic_version":"8.0.1"},{"module_args":"","module_id":"259bc961ae0ed766d6294bcdb7af9039","module_name":"ReJSON","semantic_version":"7.99.3"}],"mtls_allow_outdated_certs":false,"mtls_allow_weak_hashing":false,"multi_commands_opt":"auto","name":"default-db","oss_cluster":false,"oss_cluster_api_preferred_endpoint_type":"ip","oss_cluster_api_preferred_ip_type":"internal","oss_sharding":false,"port":0,"proxy_policy":"single","rack_aware":false,"recovery_wait_time":-1,"redis_cluster_enabled":false,"redis_version":"8.0","repl_backlog_size":"auto","replica_read_only":false,"replica_sources":[],"replica_sync":"disabled","replica_sync_connection_alarm_timeout_seconds":0,"replica_sync_dist":true,"replication":false,"resp3":true,"roles_permissions":[],"sched_policy":"cmp","shard_block_crossslot_keys":false,"shard_block_foreign_keys":true,"shard_key_regex":[],"shard_list":[1],"sharding":false,"shards_count":1,"shards_placement":"dense","skip_import_analyze":"disabled","slave_buffer":"auto","slave_ha":false,"slave_ha_priority":0,"snapshot_policy":[],"ssl":false,"status":"active","support_syncer_reconf":true,"sync":"disabled","sync_dedicated_threads":5,"sync_sources":[],"syncer_log_level":"info","syncer_mode":"distributed","throughput_ingress":0,"tls_mode":"disabled","topology_epoch":1,"tracking_table_max_keys":1000000,"type":"redis","uid":1,"use_selective_flush":true,"version":"8.0.0","wait_command":true}