Skip to content

Commit 42ab46a

Browse files
committed
fix: remove musl target from cargo-dist due to keyring incompatibility
The keyring crate used for secure-storage has native dependencies that don't work with musl libc. This causes the x86_64-unknown-linux-musl build to fail when trying to link OpenSSL. Solutions considered: 1. Disable secure-storage for musl builds (complex configuration) 2. Use vendored OpenSSL (adds build time and complexity) 3. Remove musl target (chosen - simplest) The x86_64-unknown-linux-gnu target still provides Linux binaries that work on most distributions. Users needing static binaries can build manually with --no-default-features --features full.
1 parent 5b41bd2 commit 42ab46a

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ ci = "github"
3434
# The installers to generate for each app
3535
installers = ["shell", "powershell"]
3636
# Target platforms to build apps for (Rust target-triple syntax)
37-
targets = ["aarch64-apple-darwin", "x86_64-apple-darwin", "x86_64-unknown-linux-gnu", "x86_64-unknown-linux-musl", "x86_64-pc-windows-msvc"]
37+
# Note: x86_64-unknown-linux-musl removed due to keyring incompatibility with musl
38+
targets = ["aarch64-apple-darwin", "x86_64-apple-darwin", "x86_64-unknown-linux-gnu", "x86_64-pc-windows-msvc"]
3839
# Which actions to run on pull requests
3940
pr-run-mode = "plan"
4041
# Whether dist should create a Github Release or use an existing draft

crates/redisctl/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ full = ["cloud", "enterprise", "upload"]
6666
cloud = []
6767
enterprise = []
6868
upload = ["dep:files-sdk"]
69+
# Note: secure-storage may not work on musl targets due to keyring native dependencies
70+
# Build with --no-default-features --features full for musl
6971
secure-storage = ["dep:keyring"]
7072

7173
[dev-dependencies]

0 commit comments

Comments
 (0)