Merge pull request #376 from joshrotenberg/feat/api-coverage-high-priority-375

feat: High Priority API Coverage Improvements (Issue #375)

Author: joshrotenberg

CLAUDE.md

@@ -428,13 +428,42 @@ Examples:
 - BDB creation: Use `/v2/bdbs` for async operations
 - Actions: Use `/v2/actions` for listing and status
 
+### Active-Active (CRDB) Pattern
+
+Redis Cloud has separate functions for Active-Active (CRDB) operations to ensure type safety:
+
+#### When to Use Active-Active Functions
+Active-Active databases (Conflict-free Replicated Databases) require special handling for multi-region deployments. The `_active_active` suffix indicates functions designed specifically for these databases.
+
+**Key Active-Active Operations:**
+- VPC Peering: `create_active_active()`, `get_active_active()`, `update_active_active()`, `delete_active_active()`
+- PSC: `create_service_active_active()`, `create_endpoint_active_active()`, etc.
+- Transit Gateway: `create_attachment_active_active()`, `get_attachments_active_active()`, etc.
+
+**Why Separate Functions?**
+1. **Different request structures** - AA operations often require region-specific parameters
+2. **Type safety** - Prevents accidentally calling regular endpoints with AA-specific data
+3. **Clear API surface** - Explicit function names make intent clear
+
+**Example:**
+```rust
+// Regular database VPC peering
+let vpc = handler.create(subscription_id, &request).await?;
+
+// Active-Active database VPC peering (requires region specification)
+let vpc = handler.create_active_active(subscription_id, region_id, &request).await?;
+```
+
+**Note:** Despite having separate functions, these map to the same API endpoints. The separation is for developer ergonomics and type safety.
+
 ### Common Code Patterns
 - **Client creation**: Use `create_cloud_client()` or `create_enterprise_client()` helpers
 - **Error context**: Always add `.context()` to errors for debugging
 - **Output handling**: Use `print_output()` helper for consistent formatting
 - **Async operations**: Use `handle_async_response()` for task-based operations
 - **Parameter grouping**: Create params struct when >7 parameters needed
 - **Testing**: Mock all HTTP calls with `wiremock`, never make real API calls in tests
+- **Active-Active**: Use `_active_active` suffixed functions for CRDB operations
 
 ## Testing Approach
 

crates/redis-cloud/src/cloud_accounts.rs

@@ -121,6 +121,14 @@ pub struct CloudAccount {
     #[serde(skip_serializing_if = "Option::is_none")]
     pub access_secret_key: Option<String>,
 
+    /// AWS Console Role ARN (AWS-specific)
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub aws_console_role_arn: Option<String>,
+
+    /// AWS User ARN (AWS-specific)
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub aws_user_arn: Option<String>,
+
     /// Cloud provider management console username
     #[serde(skip_serializing_if = "Option::is_none")]
     pub console_username: Option<String>,

crates/redis-cloud/src/fixed/databases.rs

@@ -1044,8 +1044,13 @@ impl FixedDatabaseHandler {
     // ========================================================================
     // Backward compatibility wrapper methods
     // ========================================================================
+    // NOTE: These methods are deprecated in favor of the shorter, more idiomatic names.
+    // They will be removed in a future version.
 
     /// Create fixed database (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`create`](Self::create) instead
+    #[deprecated(since = "0.8.0", note = "Use `create` instead")]
     pub async fn create_fixed_database(
         &self,
         subscription_id: i32,
@@ -1055,6 +1060,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Get fixed database (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_by_id`](Self::get_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_by_id` instead")]
     pub async fn get_fixed_database(
         &self,
         subscription_id: i32,
@@ -1066,6 +1074,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Update fixed database (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`update`](Self::update) instead
+    #[deprecated(since = "0.8.0", note = "Use `update` instead")]
     pub async fn update_fixed_database(
         &self,
         subscription_id: i32,
@@ -1076,6 +1087,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Delete fixed database (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`delete_by_id`](Self::delete_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `delete_by_id` instead")]
     pub async fn delete_fixed_database(
         &self,
         subscription_id: i32,
@@ -1085,6 +1099,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Backup fixed database (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`backup`](Self::backup) instead
+    #[deprecated(since = "0.8.0", note = "Use `backup` instead")]
     pub async fn backup_fixed_database(
         &self,
         subscription_id: i32,
@@ -1095,6 +1112,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Get fixed subscription databases (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`list`](Self::list) instead
+    #[deprecated(since = "0.8.0", note = "Use `list` instead")]
     pub async fn get_fixed_subscription_databases(
         &self,
         subscription_id: i32,
@@ -1105,6 +1125,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Get fixed database by id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_by_id`](Self::get_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_by_id` instead")]
     pub async fn fixed_database_by_id(
         &self,
         subscription_id: i32,
@@ -1114,6 +1137,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Get fixed subscription database by id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_by_id`](Self::get_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_by_id` instead")]
     pub async fn get_fixed_subscription_database_by_id(
         &self,
         subscription_id: i32,
@@ -1123,6 +1149,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Delete fixed database by id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`delete_by_id`](Self::delete_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `delete_by_id` instead")]
     pub async fn delete_fixed_database_by_id(
         &self,
         subscription_id: i32,
@@ -1132,6 +1161,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Import fixed database (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`import`](Self::import) instead
+    #[deprecated(since = "0.8.0", note = "Use `import` instead")]
     pub async fn import_fixed_database(
         &self,
         subscription_id: i32,
@@ -1142,6 +1174,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Create fixed database tag (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`create_tag`](Self::create_tag) instead
+    #[deprecated(since = "0.8.0", note = "Use `create_tag` instead")]
     pub async fn create_fixed_database_tag(
         &self,
         subscription_id: i32,
@@ -1152,6 +1187,9 @@ impl FixedDatabaseHandler {
     }
 
     /// Get fixed database tags (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_tags`](Self::get_tags) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_tags` instead")]
     pub async fn get_fixed_database_tags(
         &self,
         subscription_id: i32,

crates/redis-cloud/src/fixed/subscriptions.rs

@@ -550,8 +550,13 @@ impl FixedSubscriptionHandler {
     // ========================================================================
     // Backward compatibility wrapper methods
     // ========================================================================
+    // NOTE: These methods are deprecated in favor of the shorter, more idiomatic names.
+    // They will be removed in a future version.
 
     /// Create fixed subscription (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`create`](Self::create) instead
+    #[deprecated(since = "0.8.0", note = "Use `create` instead")]
     pub async fn create_fixed_subscription(
         &self,
         request: &FixedSubscriptionCreateRequest,
@@ -560,13 +565,19 @@ impl FixedSubscriptionHandler {
     }
 
     /// Get fixed subscription (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_by_id`](Self::get_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_by_id` instead")]
     pub async fn get_fixed_subscription(&self, subscription_id: i32) -> Result<TaskStateUpdate> {
         self.get_by_id(subscription_id)
             .await
             .map(|sub| serde_json::from_value(serde_json::json!(sub)).unwrap())
     }
 
     /// Update fixed subscription (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`update`](Self::update) instead
+    #[deprecated(since = "0.8.0", note = "Use `update` instead")]
     pub async fn update_fixed_subscription(
         &self,
         subscription_id: i32,
@@ -576,16 +587,25 @@ impl FixedSubscriptionHandler {
     }
 
     /// Delete fixed subscription (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`delete_by_id`](Self::delete_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `delete_by_id` instead")]
     pub async fn delete_fixed_subscription(&self, subscription_id: i32) -> Result<TaskStateUpdate> {
         self.delete_by_id(subscription_id).await
     }
 
     /// Get all fixed subscriptions plans (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`list_plans`](Self::list_plans) instead
+    #[deprecated(since = "0.8.0", note = "Use `list_plans` instead")]
     pub async fn get_all_fixed_subscriptions_plans(&self) -> Result<FixedSubscriptionsPlans> {
         self.list_plans(None, None).await
     }
 
     /// Get fixed subscriptions plans by subscription id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_plans_by_subscription_id`](Self::get_plans_by_subscription_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_plans_by_subscription_id` instead")]
     pub async fn get_fixed_subscriptions_plans_by_subscription_id(
         &self,
         subscription_id: i32,
@@ -594,6 +614,9 @@ impl FixedSubscriptionHandler {
     }
 
     /// Get fixed subscriptions plan by id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_plan_by_id`](Self::get_plan_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_plan_by_id` instead")]
     pub async fn get_fixed_subscriptions_plan_by_id(
         &self,
         plan_id: i32,
@@ -602,16 +625,25 @@ impl FixedSubscriptionHandler {
     }
 
     /// Get fixed redis versions (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_redis_versions`](Self::get_redis_versions) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_redis_versions` instead")]
     pub async fn get_fixed_redis_versions(&self, subscription_id: i32) -> Result<RedisVersions> {
         self.get_redis_versions(subscription_id).await
     }
 
     /// Get all fixed subscriptions (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`list`](Self::list) instead
+    #[deprecated(since = "0.8.0", note = "Use `list` instead")]
     pub async fn get_all_fixed_subscriptions(&self) -> Result<FixedSubscriptions> {
         self.list().await
     }
 
     /// Delete fixed subscription by id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`delete_by_id`](Self::delete_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `delete_by_id` instead")]
     pub async fn delete_fixed_subscription_by_id(
         &self,
         subscription_id: i32,
@@ -620,6 +652,9 @@ impl FixedSubscriptionHandler {
     }
 
     /// Get fixed subscription by id (backward compatibility)
+    ///
+    /// **Deprecated**: Use [`get_by_id`](Self::get_by_id) instead
+    #[deprecated(since = "0.8.0", note = "Use `get_by_id` instead")]
     pub async fn get_fixed_subscription_by_id(
         &self,
         subscription_id: i32,

crates/redis-cloud/tests/fixed_databases_tests.rs

@@ -37,10 +37,7 @@ async fn test_get_fixed_subscription_databases() {
         .unwrap();
 
     let handler = FixedDatabaseHandler::new(client);
-    let result = handler
-        .get_fixed_subscription_databases(123, None, None)
-        .await
-        .unwrap();
+    let result = handler.list(123, None, None).await.unwrap();
 
     assert_eq!(result.account_id, Some(456));
     assert!(result.links.is_some());
@@ -105,7 +102,7 @@ async fn test_create_fixed_database() {
         extra: serde_json::Value::Null,
     };
 
-    let result = handler.create_fixed_database(123, &request).await.unwrap();
+    let result = handler.create(123, &request).await.unwrap();
     assert_eq!(result.task_id, Some("task-create-fixed-db".to_string()));
     assert_eq!(
         result.command_type,
@@ -196,7 +193,7 @@ async fn test_delete_fixed_database() {
         .unwrap();
 
     let handler = FixedDatabaseHandler::new(client);
-    let result = handler.delete_fixed_database_by_id(123, 456).await.unwrap();
+    let result = handler.delete_by_id(123, 456).await.unwrap();
 
     assert_eq!(result.task_id, Some("task-delete-fixed-db".to_string()));
     assert_eq!(
@@ -236,10 +233,7 @@ async fn test_backup_fixed_database() {
         command_type: None,
         extra: serde_json::Value::Null,
     };
-    let result = handler
-        .backup_fixed_database(123, 456, &request)
-        .await
-        .unwrap();
+    let result = handler.backup(123, 456, &request).await.unwrap();
 
     assert_eq!(result.task_id, Some("task-backup-fixed-db".to_string()));
 }
@@ -278,10 +272,7 @@ async fn test_import_fixed_database() {
         extra: serde_json::Value::Null,
     };
 
-    let result = handler
-        .import_fixed_database(123, 456, &request)
-        .await
-        .unwrap();
+    let result = handler.import(123, 456, &request).await.unwrap();
     assert_eq!(result.task_id, Some("task-import-fixed-db".to_string()));
 }
 
@@ -318,10 +309,7 @@ async fn test_tag_operations() {
         extra: serde_json::Value::Null,
     };
 
-    let result = handler
-        .create_fixed_database_tag(123, 456, &request)
-        .await
-        .unwrap();
+    let result = handler.create_tag(123, 456, &request).await.unwrap();
     assert!(result.key.is_some());
 }
 
@@ -345,9 +333,7 @@ async fn test_error_handling_401() {
         .unwrap();
 
     let handler = FixedDatabaseHandler::new(client);
-    let result = handler
-        .get_fixed_subscription_databases(123, None, None)
-        .await;
+    let result = handler.list(123, None, None).await;
 
     assert!(result.is_err());
     match result {
@@ -378,7 +364,7 @@ async fn test_error_handling_403() {
         .unwrap();
 
     let handler = FixedDatabaseHandler::new(client);
-    let result = handler.delete_fixed_database_by_id(123, 456).await;
+    let result = handler.delete_by_id(123, 456).await;
 
     assert!(result.is_err());
     match result {
@@ -409,9 +395,7 @@ async fn test_error_handling_404() {
         .unwrap();
 
     let handler = FixedDatabaseHandler::new(client);
-    let result = handler
-        .get_fixed_subscription_database_by_id(999, 999)
-        .await;
+    let result = handler.get_by_id(999, 999).await;
 
     assert!(result.is_err());
     if let Err(redis_cloud::CloudError::NotFound { message }) = result {
@@ -472,7 +456,7 @@ async fn test_error_handling_500() {
         command_type: None,
         extra: serde_json::Value::Null,
     };
-    let result = handler.create_fixed_database(123, &request).await;
+    let result = handler.create(123, &request).await;
 
     assert!(result.is_err());
     match result {