fix: update shard tests and suppress false dead code warnings

- Fix shard tests to use String for node_uid (matches API response)
- Update mock data in shard_tests.rs (node_uid: 1 -> "1")
- Update test assertions to compare with strings
- Add #[allow(dead_code)] to status.rs structs/functions
  (they are used via main.rs routing but clippy doesn't detect it)

All tests now pass:
- cargo test --lib --all-features ✓
- cargo test --test '*' --all-features ✓
- cargo clippy --all-targets --all-features ✓
- cargo fmt --all -- --check ✓

Author: joshrotenberg

crates/redis-enterprise/tests/shard_tests.rs

@@ -14,7 +14,7 @@ fn master_shard() -> serde_json::Value {
     json!({
         "uid": "shard:1:1",
         "bdb_uid": 1,
-        "node_uid": 1,
+        "node_uid": "1",
         "role": "master",
         "status": "active",
         "slots": "0-8191",
@@ -28,7 +28,7 @@ fn replica_shard() -> serde_json::Value {
     json!({
         "uid": "shard:1:2",
         "bdb_uid": 1,
-        "node_uid": 2,
+        "node_uid": "2",
         "role": "slave",
         "status": "active",
         "slots": "0-8191",
@@ -40,7 +40,7 @@ fn backup_shard() -> serde_json::Value {
     json!({
         "uid": "shard:2:1",
         "bdb_uid": 2,
-        "node_uid": 1,
+        "node_uid": "1",
         "role": "master",
         "status": "backing-up",
         "slots": "8192-16383",
@@ -53,7 +53,7 @@ fn importing_shard() -> serde_json::Value {
     json!({
         "uid": "shard:3:1",
         "bdb_uid": 3,
-        "node_uid": 3,
+        "node_uid": "3",
         "role": "master",
         "status": "importing",
         "slots": "0-16383",
@@ -66,7 +66,7 @@ fn minimal_shard() -> serde_json::Value {
     json!({
         "uid": "shard:4:1",
         "bdb_uid": 4,
-        "node_uid": 1,
+        "node_uid": "1",
         "role": "master",
         "status": "active"
     })
@@ -132,7 +132,7 @@ async fn test_shard_list() {
     let master = &shards[0];
     assert_eq!(master.uid, "shard:1:1");
     assert_eq!(master.bdb_uid, 1);
-    assert_eq!(master.node_uid, 1);
+    assert_eq!(master.node_uid, "1");
     assert_eq!(master.role, "master");
     assert_eq!(master.status, "active");
     assert_eq!(master.slots, Some("0-8191".to_string()));
@@ -219,7 +219,7 @@ async fn test_shard_get() {
     let shard = result.unwrap();
     assert_eq!(shard.uid, "shard:1:1");
     assert_eq!(shard.bdb_uid, 1);
-    assert_eq!(shard.node_uid, 1);
+    assert_eq!(shard.node_uid, "1");
     assert_eq!(shard.role, "master");
     assert_eq!(shard.status, "active");
     assert_eq!(shard.slots, Some("0-8191".to_string()));
@@ -252,7 +252,7 @@ async fn test_shard_get_minimal() {
     let shard = result.unwrap();
     assert_eq!(shard.uid, "shard:4:1");
     assert_eq!(shard.bdb_uid, 4);
-    assert_eq!(shard.node_uid, 1);
+    assert_eq!(shard.node_uid, "1");
     assert_eq!(shard.role, "master");
     assert_eq!(shard.status, "active");
     assert!(shard.slots.is_none());
@@ -453,9 +453,9 @@ async fn test_shard_list_by_node() {
     assert_eq!(shards.len(), 3);
 
     // All shards should be on node 1
-    assert_eq!(shards[0].node_uid, 1);
-    assert_eq!(shards[1].node_uid, 1);
-    assert_eq!(shards[2].node_uid, 1);
+    assert_eq!(shards[0].node_uid, "1");
+    assert_eq!(shards[1].node_uid, "1");
+    assert_eq!(shards[2].node_uid, "1");
 
     // Verify different databases
     assert_eq!(shards[0].bdb_uid, 1);

crates/redisctl/src/commands/enterprise/status.rs

@@ -18,6 +18,7 @@ use super::utils::*;
 
 /// Comprehensive cluster status information
 #[derive(Debug, Clone, Serialize, Deserialize)]
+#[allow(dead_code)]
 pub struct ClusterStatus {
     /// Cluster information
     pub cluster: Value,
@@ -33,6 +34,7 @@ pub struct ClusterStatus {
 
 /// Summary statistics for cluster health
 #[derive(Debug, Clone, Serialize, Deserialize)]
+#[allow(dead_code)]
 pub struct StatusSummary {
     /// Total number of nodes
     pub total_nodes: usize,
@@ -50,6 +52,7 @@ pub struct StatusSummary {
 
 /// Sections to display in status output
 #[derive(Debug, Clone, Default)]
+#[allow(dead_code)]
 pub struct StatusSections {
     /// Show cluster information
     pub cluster: bool,
@@ -63,6 +66,7 @@ pub struct StatusSections {
 
 impl StatusSections {
     /// Create sections showing all information
+    #[allow(dead_code)]
     pub fn all() -> Self {
         Self {
             cluster: true,
@@ -73,12 +77,14 @@ impl StatusSections {
     }
 
     /// Check if any section is enabled
+    #[allow(dead_code)]
     pub fn any_enabled(&self) -> bool {
         self.cluster || self.nodes || self.databases || self.shards
     }
 }
 
 /// Get comprehensive cluster status
+#[allow(dead_code)]
 pub async fn get_status(
     conn_mgr: &ConnectionManager,
     profile_name: Option<&str>,
@@ -163,6 +169,7 @@ pub async fn get_status(
 }
 
 /// Calculate summary statistics from collected data
+#[allow(dead_code)]
 fn calculate_summary(nodes: &Value, databases: &Value, shards: &Value) -> StatusSummary {
     let empty_vec = vec![];
     let nodes_array = nodes.as_array().unwrap_or(&empty_vec);