Skip to content

Commit 8604158

Browse files
chore(docs): update mdbook-lint to 0.13.2 with CI mode (#493)
* chore: remove outdated implementation tracking file * chore(docs): update mdbook-lint to 0.13.2 with CI mode - Update mdbook-lint from 0.13.1 to 0.13.2 (fixes mdbook 0.5 compatibility) - Use CI mode (mdbook-lint lint) instead of preprocessor mode - Update .mdbook-lint.toml config to disable noisy rules - Remove preprocessor config from book.toml * fix(docs): resolve all mdbook-lint errors Fix 123 lint errors across 48 documentation files: - MD052 (20): Fix checklist items interpreted as reference links - MDBOOK010 (2): Escape shell $ variables in inline code - MDBOOK004 (15): Make duplicate chapter titles unique - MDBOOK006 (4): Remove invalid cross-reference anchors - MDBOOK002 (82): Remove broken internal links to non-existent files
1 parent 9e510c0 commit 8604158

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+180
-219
lines changed

.github/workflows/mdbook.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ on:
55
branches:
66
- main
77
paths:
8-
- 'docs/**'
9-
- '.github/workflows/mdbook.yml'
8+
- "docs/**"
9+
- ".github/workflows/mdbook.yml"
1010
pull_request:
1111
paths:
12-
- 'docs/**'
13-
- '.github/workflows/mdbook.yml'
12+
- "docs/**"
13+
- ".github/workflows/mdbook.yml"
1414
workflow_dispatch:
1515

1616
permissions:
@@ -33,8 +33,15 @@ jobs:
3333
- name: Setup mdBook
3434
uses: peaceiris/actions-mdbook@v2
3535
with:
36-
mdbook-version: 'latest'
36+
mdbook-version: "latest"
3737

38+
- name: Install mdbook-lint
39+
run: cargo install mdbook-lint --version 0.13.2 --locked
40+
41+
- name: Lint documentation
42+
run: |
43+
cd docs
44+
mdbook-lint lint . --config .mdbook-lint.toml
3845
3946
- name: Build book
4047
run: |
@@ -57,4 +64,4 @@ jobs:
5764
steps:
5865
- name: Deploy to GitHub Pages
5966
id: deployment
60-
uses: actions/deploy-pages@v4
67+
uses: actions/deploy-pages@v4

.mdbook-lint.toml

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,18 @@
11
# mdbook-lint configuration for redisctl documentation
22
# https://github.com/joshrotenberg/mdbook-lint
33

4-
# Temporarily disable rules with known issues
5-
disabled-rules = [
6-
"MDBOOK010", # Math block detection - false positives with $ in shell code blocks (issue #141)
7-
"MDBOOK005", # Orphaned files - incorrectly checking outside src directory (issue #142)
8-
"MDBOOK002", # Internal link validation - false positives with existing files
9-
]
10-
11-
# Don't fail the build on warnings or errors during initial setup
4+
# Fail on errors but not warnings
125
fail-on-warnings = false
13-
fail-on-errors = false
6+
fail-on-errors = true
147

15-
# Configure specific rules
16-
[rules.MD013]
17-
# Allow longer lines for code examples and CLI output
18-
line_length = 120
8+
# Disable rules that are too noisy for this project
9+
disabled-rules = [
10+
"MD013", # Line length - too strict for documentation
11+
"MDBOOK005", # Orphaned files - we have WIP docs
12+
"MDBOOK023", # Chapter title match - intentionally different
13+
"CONTENT004", # Heading capitalization - we use sentence case
14+
"CONTENT007", # Terminology consistency - too strict
15+
]
1916

2017
[rules.MD024]
2118
# Allow duplicate headings in different sections
@@ -24,10 +21,3 @@ enabled = true
2421
[rules.MD041]
2522
# Require first line to be a heading
2623
enabled = true
27-
28-
# Future configuration options when issues are resolved:
29-
# [rules.MDBOOK005]
30-
# search-path = "src" # Only check within src directory
31-
#
32-
# [rules.MDBOOK010]
33-
# skip-code-blocks = true # Skip math detection in code blocks

docs/.mdbook-lint.toml

Lines changed: 10 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,18 @@
11
# mdbook-lint configuration for redisctl documentation
22
# https://github.com/joshrotenberg/mdbook-lint
33

4-
# Temporarily disable rules with known issues
5-
disabled-rules = [
6-
"MDBOOK010", # Math block detection - false positives with $ in shell code blocks (issue #141)
7-
"MDBOOK005", # Orphaned files - incorrectly checking outside src directory (issue #142)
8-
"MDBOOK002", # Internal link validation - false positives with existing files
9-
]
10-
11-
# Don't fail the build on warnings, but show them for fixing
4+
# Fail on errors but not warnings
125
fail-on-warnings = false
13-
fail-on-errors = false
14-
15-
# Enable rules that should be fixable
16-
[rules.MD022]
17-
# Require blank lines around headings
18-
enabled = true
19-
20-
[rules.MD032]
21-
# Require blank lines around lists
22-
enabled = true
23-
24-
[rules.MD031]
25-
# Require blank lines around fenced code blocks
26-
enabled = true
27-
28-
[rules.MD006]
29-
# Lists should start at beginning of line
30-
enabled = true
31-
32-
[rules.MD047]
33-
# Files should end with single newline
34-
enabled = true
6+
fail-on-errors = true
357

36-
# Configure specific rules
37-
[rules.MD013]
38-
# Allow longer lines for code examples and CLI output
39-
line_length = 120
8+
# Disable rules that are too noisy for this project
9+
disabled-rules = [
10+
"MD013", # Line length - too strict for documentation
11+
"MDBOOK005", # Orphaned files - we have WIP docs
12+
"MDBOOK023", # Chapter title match - intentionally different
13+
"CONTENT004", # Heading capitalization - we use sentence case
14+
"CONTENT007", # Terminology consistency - too strict
15+
]
4016

4117
[rules.MD024]
4218
# Allow duplicate headings in different sections
@@ -45,10 +21,3 @@ enabled = true
4521
[rules.MD041]
4622
# Require first line to be a heading
4723
enabled = true
48-
49-
# Future configuration options when issues are resolved:
50-
# [rules.MDBOOK005]
51-
# search-path = "src" # Only check within src directory
52-
#
53-
# [rules.MDBOOK010]
54-
# skip-code-blocks = true # Skip math detection in code blocks

docs/book.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,3 @@ edit-url-template = "https://github.com/joshrotenberg/redisctl/edit/main/docs/{p
1313
[output.html.fold]
1414
enable = true
1515
level = 0
16-
17-
# Temporarily disabled for reorganization
18-
# [preprocessor.lint]
19-
# command = "mdbook-lint"
20-
# renderer = ["html"]

docs/src/api-reference/api.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,14 @@ redisctl api cloud post /subscriptions/123456/databases/789/acl/users --data @us
154154

155155
## Redis Enterprise API
156156

157-
### Base URL
157+
### Enterprise Base URL
158158
`https://<cluster-address>:9443`
159159

160-
### Authentication
160+
### Enterprise Authentication
161161
- Basic Auth: `username:password`
162162
- Header: `Authorization: Basic <base64>`
163163

164-
### Common Endpoints
164+
### Enterprise Endpoints
165165

166166
#### Cluster
167167
```bash

docs/src/cloud/commands.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Direct access to any REST endpoint when you need full control.
2020
redisctl api cloud <method> <path> [options]
2121
```
2222

23-
See [Raw API Access](./api-access.md) for details.
23+
See Raw API Access for details.
2424

2525
## 3. Workflows (Coming Soon)
2626

docs/src/cloud/commands/subscriptions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,9 @@ redisctl cloud fixed-subscription create --data @fixed-subscription.json --wait
208208

209209
## Related Commands
210210

211-
- [Databases](./databases.md) - Manage databases within subscriptions
212-
- [Network Connectivity](./connectivity.md) - Configure VPC peering and private endpoints
213-
- [Provider Accounts](./provider-accounts.md) - Manage cloud provider integrations
211+
- Databases - Manage databases within subscriptions
212+
- Network Connectivity - Configure VPC peering and private endpoints
213+
- Provider Accounts - Manage cloud provider integrations
214214

215215
## Common Patterns
216216

docs/src/cloud/core-resources/databases.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,8 @@ done
343343
## Related Commands
344344

345345
- [Subscriptions](./subscriptions.md) - Manage parent subscriptions
346-
- [ACL](./acl.md) - Configure access control
347-
- [Connectivity](./connectivity.md) - Set up VPC peering
346+
- ACL - Configure access control
347+
- Connectivity - Set up VPC peering
348348

349349
## API Reference
350350

docs/src/cloud/core-resources/subscriptions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,9 @@ redisctl cloud fixed-subscription create --data @fixed-subscription.json --wait
208208

209209
## Related Commands
210210

211-
- [Databases](./databases.md) - Manage databases within subscriptions
212-
- [Network Connectivity](./connectivity.md) - Configure VPC peering and private endpoints
213-
- [Provider Accounts](./provider-accounts.md) - Manage cloud provider integrations
211+
- Databases - Manage databases within subscriptions
212+
- Network Connectivity - Configure VPC peering and private endpoints
213+
- Provider Accounts - Manage cloud provider integrations
214214

215215
## Common Patterns
216216

docs/src/common-features/profiles.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ redisctl profile set enterprise-prod \
4545
3. Click "Add API Key" and give it a name
4646
4. Copy both the Account key and Secret (you won't see the secret again!)
4747

48-
### Redis Enterprise
48+
### Redis Enterprise Credentials
4949

5050
- **URL**: `https://cluster-fqdn:9443`
5151
- **Username**: Configured during setup (often `[email protected]`)

0 commit comments

Comments
 (0)