Fixed the --extra-tags export logic (#225)

* [fix] Fixed the --extra-tags export logic

* Bumping version from 0.5.7 to 0.5.8

Author: filipecosta90

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redisbench-admin"
-version = "0.5.7"
+version = "0.5.8"
 description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
 authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
 readme = "README.md"

redisbench_admin/export/common/common.py

@@ -48,15 +48,15 @@ def add_datapoint(
 
 
 def split_tags_string(extra_tags):
-    result = []
+    result = {}
     extra_tags = extra_tags.split(",")
     if len(extra_tags) > 0:
         for extra_tag in extra_tags:
             kv = extra_tag.split("=")
             if len(kv) == 2:
                 k = prepare_tags(kv[0])
                 v = prepare_tags(kv[1])
-                result.append({k: v})
+                result[k] = v
     return result
 
 

redisbench_admin/export/export.py

@@ -37,15 +37,7 @@ def export_command_logic(args, project_name, project_version):
     if results_format == "json":
         with open(benchmark_file, "r") as json_file:
             results_dict = json.load(json_file)
-    extra_tags_array = split_tags_string(args.extra_tags)
-    extra_tags_dict = {}
-    for kv_pair in extra_tags_array:
-        kv_tuple = kv_pair.split("=")
-        if len(kv_tuple) < 2:
-            pass
-        key = kv_tuple[0]
-        value = kv_tuple[1]
-        extra_tags_dict[key] = value
+    extra_tags_dict = split_tags_string(args.extra_tags)
     logging.info("Using the following extra tags: {}".format(extra_tags_dict))
 
     logging.info("Checking connection to RedisTimeSeries.")

tests/test_common.py

@@ -56,7 +56,7 @@ def test_add_datapoint(self):
 
     def test_split_tags_string(self):
         result = split_tags_string("k1=v1,k2=v2")
-        assert result == [{"k1": "v1"}, {"k2": "v2"}]
+        assert result == {"k1": "v1", "k2": "v2"}
 
     def test_get_or_none(self):
         res = get_or_none({}, "k")