On remote DB spin, logging process exit code and stdout stderr in case of failure (#286)

Author: filipecosta90

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redisbench-admin"
-version = "0.6.19"
+version = "0.6.20"
 description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
 authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
 readme = "README.md"

redisbench_admin/run/cluster.py

@@ -138,7 +138,16 @@ def spin_up_redis_cluster_remote_redis(
         )
         logfiles.append(logfile)
         redis_process_commands.append(" ".join(command))
-    execute_remote_commands(
+    res = execute_remote_commands(
         server_public_ip, username, private_key, redis_process_commands, ssh_port
     )
+    for pos, res_pos in enumerate(res):
+        [recv_exit_status, stdout, stderr] = res_pos
+        if recv_exit_status != 0:
+            logging.error(
+                "Remote primary shard {} command returned exit code {}. stdout {}. stderr {}".format(
+                    pos, recv_exit_status, stdout, stderr
+                )
+            )
+
     return logfiles

redisbench_admin/run_remote/standalone.py

@@ -37,7 +37,17 @@ def spin_up_standalone_remote_redis(
 
     # start redis-server
     commands = [initial_redis_cmd]
-    execute_remote_commands(server_public_ip, username, private_key, commands, port)
+    res = execute_remote_commands(
+        server_public_ip, username, private_key, commands, port
+    )
+    for pos, res_pos in enumerate(res):
+        [recv_exit_status, stdout, stderr] = res_pos
+        if recv_exit_status != 0:
+            logging.error(
+                "Remote primary shard {} command returned exit code {}. stdout {}. stderr {}".format(
+                    pos, recv_exit_status, stdout, stderr
+                )
+            )
     return full_logfile