Skip to content

Commit 5278c98

Browse files
[fix] Shutting down remote redis properly (#174)
1 parent f938815 commit 5278c98

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.4.1"
3+
version = "0.4.2"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"

redisbench_admin/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828

2929
LOG_LEVEL = logging.DEBUG
30-
if os.getenv("VERBOSE", "1") == "0":
30+
if os.getenv("VERBOSE", "0") == "0":
3131
LOG_LEVEL = logging.INFO
3232
LOG_FORMAT = "%(asctime)s %(levelname)-4s %(message)s"
3333
LOG_DATEFMT = "%Y-%m-%d %H:%M:%S"

redisbench_admin/run_remote/run_remote.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,6 @@ def run_remote_command_logic(args, project_name, project_version):
321321
benchmark_config, local_redis_conn, required_modules
322322
)
323323

324-
ssh_tunnel.close() # Close the tunnel
325-
326324
(
327325
benchmark_min_tool_version,
328326
benchmark_min_tool_version_major,
@@ -392,6 +390,10 @@ def run_remote_command_logic(args, project_name, project_version):
392390
command_str,
393391
)
394392
benchmark_end_time = datetime.datetime.now()
393+
394+
logging.info("Shutting down remote redis.")
395+
local_redis_conn.shutdown(save=False)
396+
ssh_tunnel.close() # Close the tunnel
395397
if remote_run_result is False:
396398
failed_remote_run_artifact_store(
397399
args,

0 commit comments

Comments
 (0)