Skip to content

Commit a2901b4

Browse files
Using dbconfig.dataset_load_timeout_secs on run-local (#167)
* [fix] Using dbconfig.dataset_load_timeout_secs on run-local * Bumping version from 0.3.6 to 0.3.7
1 parent e7ce941 commit a2901b4

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.3.6"
3+
version = "0.3.7"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"

redisbench_admin/environments/oss_cluster.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ def spin_up_local_redis_cluster(
2020
local_module_file,
2121
configuration_parameters=None,
2222
dbdir_folder=None,
23+
dataset_load_timeout_secs=60,
2324
):
2425
redis_processes = []
2526
meet_cmds = []
@@ -38,7 +39,7 @@ def spin_up_local_redis_cluster(
3839
)
3940
redis_process = subprocess.Popen(command)
4041
r = redis.StrictRedis(port=shard_port)
41-
result = wait_for_conn(r)
42+
result = wait_for_conn(r, dataset_load_timeout_secs)
4243
if result is True:
4344
logging.info("Redis available")
4445
meet_cmds.append("CLUSTER MEET {} {}".format("127.0.0.1", shard_port))

redisbench_admin/run_local/run_local.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def run_local_command_logic(args, project_name, project_version):
156156
)
157157
(
158158
redis_configuration_parameters,
159-
_,
159+
dataset_load_timeout_secs,
160160
) = extract_redis_dbconfig_parameters(
161161
benchmark_config, "dbconfig"
162162
)
@@ -172,6 +172,7 @@ def run_local_command_logic(args, project_name, project_version):
172172
local_module_file,
173173
redis_configuration_parameters,
174174
dbdir_folder,
175+
dataset_load_timeout_secs,
175176
)
176177
for redis_process in redis_processes:
177178
if is_process_alive(redis_process) is False:

tests/test_redisgraph_benchmark_go.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ def test_prepare_redis_graph_benchmark_go_command():
1818
== "redisgraph-benchmark-go -graph-key g -rps 0 -c 32 -n 1000000 -query MATCH (n) WHERE ID(n) = 0 SET n.v = n.v + 1 -query-ratio 1 -h localhost -p 6380 -json-out-file result.txt"
1919
)
2020

21+
2122
def test_prepare_redis_graph_benchmark_go_new_command():
2223
with open("./tests/test_data/redisgraph-benchmark-go_2.yml", "r") as yml_file:
2324
benchmark_config = yaml.safe_load(yml_file)

0 commit comments

Comments
 (0)