[add] kicking off export action

Author: filipecosta90

README.md

@@ -1 +1,28 @@
-# redisbench-admin
+
+# redisbench-admin
+Redis benchmark run helper. A wrapper around ftsb_redisearch ( future versions will also support redis-benchmark and memtier_benchmark ).
+
+
+## Installation
+
+Installation is done using pip, the package installer for Python, in the following manner:
+
+```bash
+python3 -m pip install redisbench-admin
+```
+
+## Overview
+
+TBD
+
+### Running tests
+
+A simple test suite is provided, and can be run with:
+
+```sh
+$ poetry run pytest
+```
+
+## License
+
+redisbench-admin is distributed under the BSD3 license - see [LICENSE](LICENSE)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redisbench-admin"
-version = "0.1.5"
+version = "0.1.6"
 description = "Redis benchmark run helper. A wrapper around ftsb_redisearch ( future versions will also support redis-benchmark and memtier_benchmark )."
 authors = ["filipecosta90 <[email protected]>"]
 

redisbench_admin/__init__.py

@@ -1 +1 @@
-__version__ = '0.1.3'
+__version__ = '0.1.6'

redisbench_admin/cli.py

@@ -1,7 +1,7 @@
 import argparse
 import sys
-
 import toml
+from redisbench_admin import __version__
 
 from redisbench_admin.compare.args import create_compare_arguments
 from redisbench_admin.compare.compare import compare_command_logic
@@ -12,10 +12,17 @@
 
 
 def populate_with_poetry_data():
-    poetry_data = toml.load("pyproject.toml")['tool']['poetry']
-    project_name = poetry_data["name"]
-    project_version = poetry_data["version"]
-    project_description = poetry_data["description"]
+    project_name = 'redisbench-admin'
+    project_version = __version__
+    project_description = None
+    try:
+        poetry_data = toml.load("pyproject.toml")['tool']['poetry']
+        project_name = poetry_data["name"]
+        project_version = poetry_data["version"]
+        project_description = poetry_data["description"]
+    except FileNotFoundError:
+        pass
+
     return project_name, project_description, project_version
 
 

redisbench_admin/compare/compare.py

@@ -10,11 +10,12 @@
 def get_key_results_and_values(baseline_json, step, use_result):
     selected_run = None
     metrics = {}
-    for name, value in baseline_json["key-results"][step][use_result][0].items():
-        if name == "run-name":
-            selected_run = value
-        else:
-            metrics[name] = value
+    if "key-results" in baseline_json and use_result in baseline_json["key-results"]:
+        for name, value in baseline_json["key-results"][step][use_result][0].items():
+            if name == "run-name":
+                selected_run = value
+            else:
+                metrics[name] = value
     return selected_run, metrics
 
 
@@ -84,8 +85,6 @@ def compare_command_logic(args):
                 ammount_of_failing_metrics = len (failing_metrics)
                 if ammount_of_failing_metrics > 0:
                     df_keys = df.keys()
-                    # print(df.loc['pct_change'][0])
-                    # print([0])
                     print( "There was a total of {} metrics that presented a regression above {} %".format(ammount_of_failing_metrics,max_pct_change) )
                     for pos,failed in enumerate(failing_metrics_serie):
                         if failed:

redisbench_admin/export/args.py

@@ -1,2 +1,8 @@
 def create_export_arguments(parser):
+    parser.add_argument('--benchmark-result-files', type=str, required=True,
+                        help="benchmark results files to read results from. can be a local file, a remote link, or an s3 bucket.")
+    parser.add_argument('--steps', type=str, default="setup,benchmark",
+                        help="comma separated list of steps to be analyzed given the benchmark result files")
+    parser.add_argument('--exporter', type=str, default="csv",
+                        help="exporter to be used ( either csv or redistimeseries )")
     return parser

redisbench_admin/export/export.py

@@ -1,2 +1,10 @@
+import os
+
+from redisbench_admin.utils.utils import retrieve_local_or_remote_input_json
+
+
 def export_command_logic(args):
-    pass
+    benchmark_files = args.benchmark_result_files
+    local_path = os.path.abspath(args.local_dir)
+    included_steps = args.steps.split(",")
+    benchmark_results = retrieve_local_or_remote_input_json(benchmark_files, local_path, "--benchmark-result-files")

tests/test_compare.py

@@ -0,0 +1,6 @@
+from unittest import TestCase
+
+
+class Test(TestCase):
+    def test_get_key_results_and_values(self):
+        pass

tests/test_redisbench_admin.py

@@ -2,4 +2,4 @@
 
 
 def test_version():
-    assert __version__ == '0.1.3'
+    assert __version__ == '0.1.6'