Skip to content

Commit c4b785b

Browse files
[fix] Fixed standardized metrics by branch (#134)
* [add] Added by.branch time-series for benchmark_duration and dataset_load_duration metrics * Bumping version from 0.2.3 to 0.2.4 * [fix] fixed benchmark repetitions range * Bumping version from 0.2.4 to 0.2.5 * [fix] Fixed standardized metrics by branch
1 parent 2042013 commit c4b785b

File tree

2 files changed

+26
-25
lines changed

2 files changed

+26
-25
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.2.5"
3+
version = "0.2.6"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"

redisbench_admin/run_remote/run_remote.py

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -599,30 +599,31 @@ def run_remote_command_logic(args):
599599
tf_triggering_env,
600600
),
601601
)
602-
add_standardized_metric_bybranch(
603-
"benchmark_duration",
604-
benchmark_duration_seconds,
605-
tf_github_branch,
606-
deployment_type,
607-
rts,
608-
start_time_ms,
609-
test_name,
610-
tf_github_org,
611-
tf_github_repo,
612-
tf_triggering_env,
613-
)
614-
add_standardized_metric_bybranch(
615-
"dataset_load_duration",
616-
dataset_load_duration_seconds,
617-
tf_github_branch,
618-
deployment_type,
619-
rts,
620-
start_time_ms,
621-
test_name,
622-
tf_github_org,
623-
tf_github_repo,
624-
tf_triggering_env,
625-
)
602+
if tf_github_branch is not None and tf_github_branch != "":
603+
add_standardized_metric_bybranch(
604+
"benchmark_duration",
605+
benchmark_duration_seconds,
606+
str(tf_github_branch),
607+
deployment_type,
608+
rts,
609+
start_time_ms,
610+
test_name,
611+
tf_github_org,
612+
tf_github_repo,
613+
tf_triggering_env,
614+
)
615+
add_standardized_metric_bybranch(
616+
"dataset_load_duration",
617+
dataset_load_duration_seconds,
618+
str(tf_github_branch),
619+
deployment_type,
620+
rts,
621+
start_time_ms,
622+
test_name,
623+
tf_github_org,
624+
tf_github_repo,
625+
tf_triggering_env,
626+
)
626627
add_standardized_metric_byversion(
627628
"benchmark_duration",
628629
benchmark_duration_seconds,

0 commit comments

Comments
 (0)