Skip to content

Commit ee0775a

Browse files
Fixed profiler-daemon startup code. Included documentation about perf-daemon (#282)
* [fix] get_final_benchmark_config is error agnostic * Fixed profiler-daemon startup code. Included documentation about perf-daemon
1 parent 4f74d06 commit ee0775a

File tree

5 files changed

+42
-6
lines changed

5 files changed

+42
-6
lines changed

README.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,42 @@ python3 -m pip install redisbench-admin
3636

3737
## Profiler daemon
3838

39+
You can use the profiler daemon by itself in the following manner.
40+
On the target machine do as follow:
41+
42+
```bash
43+
pip3 install --upgrade pip
44+
pip3 install redisbench-admin --ignore-installed PyYAML
45+
46+
# install perf
47+
apt install linux-tools-common linux-tools-generic linux-tools-`uname -r` -y
48+
49+
# ensure perf is working
50+
perf --version
51+
52+
# install awscli
53+
snap install aws-cli --classic
54+
55+
56+
# configure aws
57+
aws configure
58+
59+
# start the perf-daemon
60+
perf-daemon start
61+
WARNING:root:Unable to detected github_actor. caught the following error: No section: 'user'
62+
Writting log to /tmp/perf-daemon.log
63+
Starting perf-daemon. PID file /tmp/perfdaemon.pid. Daemon workdir: /root/RedisGraph
64+
65+
# check daemon is working appropriatelly
66+
curl localhost:5000/ping
67+
68+
# start a profile
69+
curl -X POST localhost:5000/profiler/perf/start/<pid to profile>
70+
71+
# stop a profile
72+
curl -X POST -d '{"aws_access_key_id":$AWS_ACCESS_KEY_ID,"aws_secret_access_key":$AWS_SECRET_ACCESS_KEY}' localhost:5000/profiler/perf/stop/<pid to profile>
73+
```
74+
3975

4076
## Development
4177

docs/export.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Current supported benchmark tools to export data from:
2727
Installation is done using pip, the package installer for Python, in the following manner:
2828

2929
```bash
30-
python3 -m pip install redisbench-admin>=0.5.5
30+
python3 -m pip install redisbench-admin>=0.5.5 --ignore-installed PyYAML
3131
```
3232

3333
## Required minimum arguments

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.6.17"
3+
version = "0.6.18"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
66
readme = "README.md"

redisbench_admin/profilers/daemon.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from redisbench_admin.cli import populate_with_poetry_data
2020
from redisbench_admin.profilers.perf import Perf
2121
from redisbench_admin.profilers.perf_daemon_caller import PERF_DAEMON_LOGNAME
22-
from redisbench_admin.profilers.profile_local import local_profilers_platform_checks
22+
from redisbench_admin.profilers.profilers_local import local_profilers_platform_checks
2323
from redisbench_admin.run.args import S3_BUCKET_NAME
2424
from redisbench_admin.run.common import get_start_time_vars
2525
from redisbench_admin.run.s3 import get_test_s3_bucket_path

redisbench_admin/utils/remote.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ def extract_git_vars(path=None, github_url=None):
332332
try:
333333
github_branch = github_repo.active_branch
334334
except TypeError as e:
335-
logging.warning(
335+
logging.debug(
336336
"Unable to detected github_branch. caught the following error: {}".format(
337337
e.__str__()
338338
)
@@ -343,14 +343,14 @@ def extract_git_vars(path=None, github_url=None):
343343
try:
344344
github_actor = github_repo.config_reader().get_value("user", "name")
345345
except configparser.NoSectionError as e:
346-
logging.warning(
346+
logging.debug(
347347
"Unable to detected github_actor. caught the following error: {}".format(
348348
e.__str__()
349349
)
350350
)
351351
github_branch_detached = True
352352
except git.exc.InvalidGitRepositoryError as e:
353-
logging.warning(
353+
logging.debug(
354354
"Unable to fill git vars. caught the following error: {}".format(
355355
e.__str__()
356356
)

0 commit comments

Comments
 (0)