Skip to content

Commit f02e041

Browse files
[fix] Fixed required modules check on empty modules list (#94)
* [fix] Fixed required modules check on empty modules list * Bumping version from 0.1.70 to 0.1.71
1 parent 5622c7a commit f02e041

File tree

3 files changed

+30
-27
lines changed

3 files changed

+30
-27
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.1.70"
3+
version = "0.1.71"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"

redisbench_admin/run_local/run_local.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -139,20 +139,21 @@ def run_local_command_logic(args):
139139
module_names,
140140
_,
141141
) = extract_module_semver_from_info_modules_cmd(stdout)
142-
if len(required_modules) > 0:
143-
logging.info(
144-
"Checking if the following required modules {} are present".format(
145-
required_modules
146-
)
147-
)
148-
for required_module in required_modules:
149-
if required_module not in module_names:
150-
raise Exception(
151-
"Unable to detect required module {} in {}. Aborting...".format(
152-
required_module,
153-
module_names,
142+
if required_modules is not None:
143+
if len(required_modules) > 0:
144+
logging.info(
145+
"Checking if the following required modules {} are present".format(
146+
required_modules
154147
)
155148
)
149+
for required_module in required_modules:
150+
if required_module not in module_names:
151+
raise Exception(
152+
"Unable to detect required module {} in {}. Aborting...".format(
153+
required_module,
154+
module_names,
155+
)
156+
)
156157

157158
# setup the benchmark
158159
start_time, start_time_ms, start_time_str = get_start_time_vars()

redisbench_admin/run_remote/run_remote.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -398,22 +398,24 @@ def run_remote_command_logic(args):
398398
module_names, artifact_versions = extract_artifact_version_remote(
399399
server_public_ip, server_plaintext_port, username, private_key
400400
)
401-
if len(required_modules) > 0:
402-
logging.info(
403-
"Checking if the following required modules {} are present".format(
404-
required_modules
405-
)
406-
)
407-
for required_module in required_modules:
408-
if required_module not in module_names:
409-
raise Exception(
410-
"Unable to detect required module {} in {}, using remote DB with IP {}, PORT {}. Aborting...".format(
411-
required_module,
412-
module_names,
413-
server_public_ip,
414-
server_plaintext_port,
401+
if required_modules is not None:
402+
if len(required_modules) > 0:
403+
logging.info(
404+
"Checking if the following required modules {} are present".format(
405+
required_modules
415406
)
416407
)
408+
for required_module in required_modules:
409+
if required_module not in module_names:
410+
raise Exception(
411+
"Unable to detect required module {} in {}"
412+
", using remote DB with IP {}, PORT {}. Aborting...".format(
413+
required_module,
414+
module_names,
415+
server_public_ip,
416+
server_plaintext_port,
417+
)
418+
)
417419

418420
artifact_version = artifact_versions[0]
419421
(

0 commit comments

Comments
 (0)