Always assume UTF-8 encoding instead of relying on Encoding.default_external

Author: byroot

CHANGELOG.md

@@ -1,5 +1,7 @@
 # Unreleased
 
+- Always assume UTF-8 encoding instead of relying on `Encoding.default_external`.
+
 # 0.21.1
 
 - Handle unresolved Sentinel master/replica error when displaying server URL in exceptions. See #182.

hiredis-client/ext/redis_client/hiredis/hiredis_connection.c

@@ -178,7 +178,7 @@ static void *reply_create_string(const redisReadTask *task, char *cstr, size_t l
         len -= 4;
     }
 
-    VALUE string = rb_external_str_new(cstr, len);
+    VALUE string = rb_utf8_str_new(cstr, len);
     if (rb_enc_str_coderange(string) == ENC_CODERANGE_BROKEN) {
         rb_enc_associate(string, rb_ascii8bit_encoding());
     }

lib/redis_client/ruby_connection/buffered_io.rb

@@ -10,10 +10,9 @@ class BufferedIO
 
       attr_accessor :read_timeout, :write_timeout
 
-      def initialize(io, read_timeout:, write_timeout:, chunk_size: 4096, encoding: Encoding.default_external)
+      def initialize(io, read_timeout:, write_timeout:, chunk_size: 4096)
         @io = io
-        @encoding = encoding
-        @buffer = "".dup.force_encoding(@encoding)
+        @buffer = +""
         @offset = 0
         @chunk_size = chunk_size
         @read_timeout = read_timeout
@@ -175,9 +174,9 @@ def fill_buffer(strict, size = @chunk_size)
             if empty_buffer
               @offset = start
               empty_buffer = false
-              @buffer.force_encoding(@encoding) if RESET_BUFFER_ENCODING
+              @buffer.force_encoding(Encoding::UTF_8) if RESET_BUFFER_ENCODING
             else
-              @buffer << bytes.force_encoding(@encoding)
+              @buffer << bytes.force_encoding(Encoding::UTF_8)
             end
             remaining -= bytes.bytesize
             return if !strict || remaining <= 0

test/redis_client_test.rb

@@ -28,7 +28,7 @@ def test_encoding
     @redis.call("SET", "str", "fée")
     str = @redis.call("GET", "str")
 
-    assert_equal Encoding.default_external, str.encoding
+    assert_equal Encoding::UTF_8, str.encoding
     assert_predicate str, :valid_encoding?
 
     bytes = "\xFF\00"