RESP3: Pre-freeze hash keys

This saves Ruby from needing to make a frozen copy of the string keys.

Author: byroot

benchmark/drivers.rb

@@ -17,9 +17,9 @@
   x.report("ruby") { ruby.pipelined { |p| 100.times { p.call("GET", "key") } } }
 end
 
-benchmark("large string x 100") do |x|
-  x.report("hiredis") { hiredis.pipelined { |p| 100.times { p.call("GET", "large") } } }
-  x.report("ruby") { ruby.pipelined { |p| 100.times { p.call("GET", "large") } } }
+benchmark("large string") do |x|
+  x.report("hiredis") { hiredis.call("GET", "large") }
+  x.report("ruby") { ruby.call("GET", "large") }
 end
 
 benchmark("small list x 100") do |x|

benchmark/drivers_ruby.md

@@ -7,53 +7,53 @@ redis-server: `Redis server v=7.0.12 sha=00000000:0 malloc=libc bits=64 build=a1
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) [arm64-darwin23]
-             hiredis:     4825.5 i/s
-                ruby:     2863.4 i/s - 1.69x  slower
+             hiredis:     5239.0 i/s
+                ruby:     2957.4 i/s - 1.77x  slower
 
 ```
 
-### large string x 100
+### large string
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) [arm64-darwin23]
-             hiredis:      266.6 i/s
-                ruby:      198.1 i/s - 1.35x  slower
+             hiredis:    12784.9 i/s
+                ruby:    14948.2 i/s - same-ish: difference falls within error
 
 ```
 
 ### small list x 100
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) [arm64-darwin23]
-             hiredis:     2416.9 i/s
-                ruby:     1223.3 i/s - 1.98x  slower
+             hiredis:     2599.3 i/s
+                ruby:     1300.0 i/s - 2.00x  slower
 
 ```
 
 ### large list
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) [arm64-darwin23]
-             hiredis:     5351.6 i/s
-                ruby:     1718.0 i/s - 3.11x  slower
+             hiredis:     6836.0 i/s
+                ruby:     1867.6 i/s - 3.66x  slower
 
 ```
 
 ### small hash x 100
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) [arm64-darwin23]
-             hiredis:     2854.3 i/s
-                ruby:     1294.4 i/s - 2.21x  slower
+             hiredis:     3392.5 i/s
+                ruby:     1408.9 i/s - 2.41x  slower
 
 ```
 
 ### large hash
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) [arm64-darwin23]
-             hiredis:     1580.6 i/s
-                ruby:     1634.7 i/s - same-ish: difference falls within error
+             hiredis:     1786.2 i/s
+                ruby:     1811.9 i/s - same-ish: difference falls within error
 
 ```
 

benchmark/drivers_yjit.md

@@ -7,53 +7,53 @@ redis-server: `Redis server v=7.0.12 sha=00000000:0 malloc=libc bits=64 build=a1
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) +YJIT [arm64-darwin23]
-             hiredis:     6407.8 i/s
-                ruby:     5852.0 i/s - same-ish: difference falls within error
+             hiredis:     7148.9 i/s
+                ruby:     5758.6 i/s - 1.24x  slower
 
 ```
 
-### large string x 100
+### large string
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) +YJIT [arm64-darwin23]
-             hiredis:      302.8 i/s
-                ruby:      337.3 i/s - same-ish: difference falls within error
+             hiredis:    13023.5 i/s
+                ruby:    20246.4 i/s - 1.55x  faster
 
 ```
 
 ### small list x 100
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) +YJIT [arm64-darwin23]
-             hiredis:     4067.7 i/s
-                ruby:     2721.5 i/s - 1.49x  slower
+             hiredis:     3973.6 i/s
+                ruby:     2668.7 i/s - 1.49x  slower
 
 ```
 
 ### large list
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) +YJIT [arm64-darwin23]
-             hiredis:     7138.7 i/s
-                ruby:     6605.4 i/s - same-ish: difference falls within error
+             hiredis:     6706.8 i/s
+                ruby:     6529.3 i/s - same-ish: difference falls within error
 
 ```
 
 ### small hash x 100
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) +YJIT [arm64-darwin23]
-             hiredis:     4219.8 i/s
-                ruby:     3586.4 i/s - 1.18x  slower
+             hiredis:     4001.6 i/s
+                ruby:     3482.9 i/s - 1.15x  slower
 
 ```
 
 ### large hash
 
 ```
 ruby 3.4.0dev (2024-03-19T14:18:56Z master 5c2937733c) +YJIT [arm64-darwin23]
-             hiredis:     5240.9 i/s
-                ruby:     5312.5 i/s - same-ish: difference falls within error
+             hiredis:     5511.9 i/s
+                ruby:     5555.7 i/s - same-ish: difference falls within error
 
 ```
 

lib/redis_client/ruby_connection/resp3.rb

@@ -174,7 +174,7 @@ def parse_set(io)
     def parse_map(io)
       hash = {}
       io.gets_integer.times do
-        hash[parse(io)] = parse(io)
+        hash[parse(io).freeze] = parse(io)
       end
       hash
     end