Merge pull request #173 from stanhu/sh-freeze-prelude

Ensure all elements of connection prelude are frozen

Author: casperisfine

lib/redis_client/config.rb

@@ -151,6 +151,12 @@ def build_connection_prelude
         if @db && @db != 0
           prelude << ["SELECT", @db.to_s]
         end
+
+        # Deep freeze all the strings and commands
+        prelude.map! do |commands|
+          commands = commands.map { |str| str.frozen? ? str : str.dup.freeze }
+          commands.freeze
+        end
         prelude.freeze
       end
     end

test/redis_client/config_test.rb

@@ -74,6 +74,17 @@ def test_user_password_uri
       refute_predicate config, :ssl?
     end
 
+    def test_frozen_prelude
+      config = Config.new(url: "redis://username:[email protected]")
+      prelude = config.connection_prelude
+      assert_equal true, prelude.frozen?
+      assert_equal true, (prelude.all? { |commands| commands.frozen? })
+
+      prelude.each do |commands|
+        assert_equal true, (commands.all? { |arg| arg.frozen? })
+      end
+    end
+
     def test_simple_password_uri
       config = Config.new(url: "redis://[email protected]")
       assert_equal "example.com", config.host