Skip to content

Commit 1b41b3b

Browse files
authored
perf: use cached replicas which excluding empty value (#108)
1 parent bc97722 commit 1b41b3b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/redis_client/cluster/node/latency_replica.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ def initialize(replications, options, pool, **kwargs)
2121
@replications.each_value { |keys| keys.sort_by! { |k| latencies.fetch(k) } }
2222
@replica_clients = select_replica_clients(@replications, @clients)
2323
@clients_for_scanning = select_clients_for_scanning(@replications, @clients)
24+
@existed_replicas = @replications.reject { |_, v| v.empty? }.values
2425
end
2526

2627
def clients_for_scanning(seed: nil) # rubocop:disable Lint/UnusedMethodArgument
@@ -33,7 +34,7 @@ def find_node_key_of_replica(primary_node_key, seed: nil) # rubocop:disable Lint
3334

3435
def any_replica_node_key(seed: nil)
3536
random = seed.nil? ? Random : Random.new(seed)
36-
@replications.reject { |_, v| v.empty? }.values.sample(random: random).first
37+
@existed_replicas.sample(random: random).first
3738
end
3839

3940
private

0 commit comments

Comments
 (0)