fix: the public methods for the block of the transaction should return nil because of the queueing (#324)

Author: supercaracal

lib/redis_client/cluster/transaction.rb

@@ -15,7 +15,7 @@ def initialize(router, command_builder, watch)
         @watch = watch
         @retryable = true
         @pipeline = ::RedisClient::Pipeline.new(@command_builder)
-        @buffer = []
+        @pending_commands = []
         @node = nil
       end
 
@@ -24,7 +24,7 @@ def call(*command, **kwargs, &block)
         if prepare(command)
           @pipeline.call_v(command, &block)
         else
-          @buffer << -> { @pipeline.call_v(command, &block) }
+          defer { @pipeline.call_v(command, &block) }
         end
       end
 
@@ -33,7 +33,7 @@ def call_v(command, &block)
         if prepare(command)
           @pipeline.call_v(command, &block)
         else
-          @buffer << -> { @pipeline.call_v(command, &block) }
+          defer { @pipeline.call_v(command, &block) }
         end
       end
 
@@ -43,7 +43,7 @@ def call_once(*command, **kwargs, &block)
         if prepare(command)
           @pipeline.call_once_v(command, &block)
         else
-          @buffer << -> { @pipeline.call_once_v(command, &block) }
+          defer { @pipeline.call_once_v(command, &block) }
         end
       end
 
@@ -53,12 +53,12 @@ def call_once_v(command, &block)
         if prepare(command)
           @pipeline.call_once_v(command, &block)
         else
-          @buffer << -> { @pipeline.call_once_v(command, &block) }
+          defer { @pipeline.call_once_v(command, &block) }
         end
       end
 
       def execute
-        @buffer.each(&:call)
+        @pending_commands.each(&:call)
 
         raise ArgumentError, 'empty transaction' if @pipeline._empty?
         raise ConsistencyError, "couldn't determine the node: #{@pipeline._commands}" if @node.nil?
@@ -69,6 +69,11 @@ def execute
 
       private
 
+      def defer(&block)
+        @pending_commands << block
+        nil
+      end
+
       def watch?
         !@watch.nil? && !@watch.empty?
       end
@@ -97,8 +102,8 @@ def prepare(command)
         @node = @router.find_node(node_key)
         @pipeline.call('WATCH', *@watch) if watch?
         @pipeline.call('MULTI')
-        @buffer.each(&:call)
-        @buffer.clear
+        @pending_commands.each(&:call)
+        @pending_commands.clear
         true
       end