Add some test cases (#26)

Author: supercaracal

README.md

@@ -88,6 +88,35 @@ cli.call('CLUSTER', 'KEYSLOT', 'key3')
 #=> 935
 ```
 
+## ACL
+The cluster client internally calls `COMMAND` and `CLUSTER NODES` commands to operate correctly.
+So please permit it like the followings.
+
+```ruby
+# The default user is administrator.
+cli1 = RedisClient.cluster.new_client
+
+# To create a user with permissions
+cli1.call('ACL', 'SETUSER', 'foo', 'ON', '+COMMAND', '+CLUSTER|NODES', '+PING', '>mysecret')
+
+# To initialize client with the user
+cli2 = RedisClient.cluster(username: 'foo', password: 'mysecret').new_client
+
+# The user can only call the PING command.
+cli2.call('PING')
+#=> "PONG"
+
+cli2.call('GET', 'key1')
+#=> NOPERM this user has no permissions to run the 'get' command (RedisClient::PermissionError)
+```
+
+Otherwise:
+
+```ruby
+RedisClient.cluster(username: 'foo', password: 'mysecret').new_client
+#=> Redis client could not fetch cluster information: NOPERM this user has no permissions to run the 'cluster|nodes' command (RedisClient::Cluster::InitialSetupError)
+```
+
 ## Connection pooling
 TODO
 

test/redis_client/test_cluster.rb

@@ -22,14 +22,15 @@ def teardown
       end
 
       def wait_for_replication
-        @client.call('WAIT', '1', (TEST_TIMEOUT_SEC * 1000).to_i.to_s)
+        @client.call('WAIT', TEST_REPLICA_SIZE, (TEST_TIMEOUT_SEC * 1000).to_i)
       end
 
       def test_inspect
         assert_match(/^#<RedisClient::Cluster [0-9., :]*>$/, @client.inspect)
       end
 
       def test_call
+        assert_raises(ArgumentError) { @client.call }
         (0..9).each do |i|
           assert_equal('OK', @client.call('SET', "key#{i}", i), "Case: SET: key#{i}")
           wait_for_replication
@@ -38,6 +39,7 @@ def test_call
       end
 
       def test_call_once
+        assert_raises(ArgumentError) { @client.call_once }
         (0..9).each do |i|
           assert_equal('OK', @client.call_once('SET', "key#{i}", i), "Case: SET: key#{i}")
           wait_for_replication
@@ -46,6 +48,7 @@ def test_call_once
       end
 
       def test_blocking_call
+        assert_raises(ArgumentError) { @client.blocking_call(TEST_TIMEOUT_SEC) }
         @client.call(*%w[RPUSH foo hello])
         @client.call(*%w[RPUSH foo world])
         wait_for_replication
@@ -140,6 +143,50 @@ def test_pubsub
       def test_close
         assert_nil(@client.close)
       end
+
+      def test_dedicated_commands
+        (0..9).each { |i| @client.call('SET', "key#{i}", i) }
+        [
+          { command: %w[ACL HELP], is_a: Array },
+          { command: %w[WAIT 1 1], want: TEST_NUMBER_OF_REPLICAS },
+          { command: %w[KEYS *], want: (0..9).map { |i| "key#{i}" } },
+          { command: %w[DBSIZE], want: (0..9).size },
+          { command: %w[SCAN], is_a: Array },
+          { command: %w[LASTSAVE], is_a: Array },
+          { command: %w[ROLE], is_a: Array },
+          { command: %w[CONFIG RESETSTAT], want: 'OK' },
+          { command: %w[CONFIG GET maxmemory], is_a: Hash },
+          { command: %w[CLIENT LIST], is_a: Array },
+          { command: %w[CLIENT PAUSE 100], want: 'OK' },
+          { command: %w[CLIENT INFO], is_a: String },
+          { command: %w[CLUSTER SET-CONFIG-EPOCH 0], error: ::RedisClient::Cluster::OrchestrationCommandNotSupported },
+          { command: %w[CLUSTER SAVECONFIG], want: 'OK' },
+          { command: %w[CLUSTER NODES], is_a: String },
+          { command: %w[READONLY], error: ::RedisClient::Cluster::OrchestrationCommandNotSupported },
+          { command: %w[MEMORY STATS], is_a: Array },
+          { command: %w[MEMORY PURGE], want: 'OK' },
+          { command: %w[MEMORY USAGE key0], is_a: Integer },
+          { command: %w[SCRIPT DEBUG NO], want: 'OK' },
+          { command: %w[SCRIPT FLUSH], want: 'OK' },
+          { command: %w[SCRIPT EXISTS b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c], want: [0] },
+          { command: %w[PUBSUB CHANNELS test-channel*], want: [] },
+          { command: %w[PUBSUB NUMSUB test-channel], want: { 'test-channel' => 0 } },
+          { command: %w[PUBSUB NUMPAT], want: 0 },
+          { command: %w[PUBSUB HELP], is_a: Array },
+          { command: %w[MULTI], error: ::RedisClient::Cluster::AmbiguousNodeError },
+          { command: %w[FLUSHDB], want: 'OK' }
+        ].each do |c|
+          msg = "Case: #{c[:command].join(' ')}"
+          got = -> { @client.call(*c[:command]) }
+          if c.key?(:error)
+            assert_raises(c[:error], msg, &got)
+          elsif c.key?(:is_a)
+            assert_instance_of(c[:is_a], got.call, msg)
+          else
+            assert_equal(c[:want], got.call, msg)
+          end
+        end
+      end
     end
 
     class PrimaryOnly < Minitest::Test

test/testing_helper.rb

@@ -11,6 +11,8 @@ module TestingHelper
   TEST_REDIS_PORTS = (6379..6384).freeze
   TEST_TIMEOUT_SEC = 5.0
   TEST_RECONNECT_ATTEMPTS = 3
+  TEST_REPLICA_SIZE = 1
+  TEST_NUMBER_OF_REPLICAS = 3
   TEST_GENERIC_OPTIONS = { timeout: TEST_TIMEOUT_SEC, reconnect_attempts: TEST_RECONNECT_ATTEMPTS, ssl: TEST_REDIS_SSL }.freeze
   TEST_NODE_URIS = TEST_REDIS_PORTS.map { |v| "#{TEST_REDIS_SCHEME}://#{TEST_REDIS_HOST}:#{v}" }.freeze
   TEST_NODE_OPTIONS = TEST_REDIS_PORTS.to_h { |v| ["#{TEST_REDIS_HOST}:#{v}", { host: TEST_REDIS_HOST, port: v, ssl: TEST_REDIS_SSL }] }.freeze