Pass a randomized array into Command.load

This reduces the dependencies between classes.

Author: Sylvester Chin

lib/redis_client/cluster/command.rb

@@ -24,7 +24,7 @@ class << self
         def load(nodes)
           cmd = errors = nil
 
-          nodes&.shuffle_each do |node|
+          nodes&.each do |node|
             reply = node.call('COMMAND')
             commands = parse_command_reply(reply)
             cmd = ::RedisClient::Cluster::Command.new(commands)

lib/redis_client/cluster/node.rb

@@ -201,8 +201,8 @@ def each(&block)
         @topology.clients.each_value(&block)
       end
 
-      def shuffle_each(&block)
-        @topology.clients.values.shuffle!.each(&block)
+      def shuffled_nodes
+        @topology.clients.values.shuffle
       end
 
       def sample

lib/redis_client/cluster/router.rb

@@ -23,7 +23,7 @@ def initialize(config, pool: nil, **kwargs)
         @pool = pool
         @client_kwargs = kwargs
         @node = fetch_cluster_info(@config, pool: @pool, **@client_kwargs)
-        @command = ::RedisClient::Cluster::Command.load(@node)
+        @command = ::RedisClient::Cluster::Command.load(@node.shuffled_nodes)
         @mutex = Mutex.new
         @command_builder = @config.command_builder
       end

test/redis_client/cluster/test_command.rb

@@ -7,15 +7,7 @@ class RedisClient
   class Cluster
     class TestCommand < TestingWrapper
       def setup
-        per_node_key = TEST_REDIS_PORTS.map do |port|
-          [
-            "#{TEST_REDIS_HOST}:#{port}",
-            { host: TEST_REDIS_HOST, port: port }.merge(TEST_GENERIC_OPTIONS)
-          ]
-        end.to_h
-        node_info_list = ::RedisClient::Cluster::Node.load_info(per_node_key)
-        @raw_clients = ::RedisClient::Cluster::Node.new(per_node_key, node_info_list: node_info_list)
-        @empty_clients = ::RedisClient::Cluster::Node.new([], node_info_list: node_info_list)
+        @raw_clients = TEST_NODE_URIS.map { |addr| ::RedisClient.config(url: addr, **TEST_GENERIC_OPTIONS).new_client }
       end
 
       def teardown
@@ -25,7 +17,7 @@ def teardown
       def test_load
         [
           { nodes: @raw_clients, error: nil },
-          { nodes: @empty_clients, error: ::RedisClient::Cluster::InitialSetupError },
+          { nodes: [], error: ::RedisClient::Cluster::InitialSetupError },
           { nodes: [''], error: NoMethodError },
           { nodes: nil, error: ::RedisClient::Cluster::InitialSetupError }
         ].each_with_index do |c, idx|