fix: make constants private (#372)

Author: supercaracal

lib/redis_client/cluster.rb

@@ -11,6 +11,8 @@ class RedisClient
   class Cluster
     ZERO_CURSOR_FOR_SCAN = '0'
 
+    private_constant :ZERO_CURSOR_FOR_SCAN
+
     attr_reader :config
 
     def initialize(config, pool: nil, concurrency: nil, **kwargs)

lib/redis_client/cluster/command.rb

@@ -12,6 +12,8 @@ class Command
       EMPTY_HASH = {}.freeze
       EMPTY_ARRAY = [].freeze
 
+      private_constant :EMPTY_STRING, :EMPTY_HASH, :EMPTY_ARRAY
+
       Detail = Struct.new(
         'RedisCommand',
         :first_key_position,

lib/redis_client/cluster/errors.rb

@@ -6,6 +6,8 @@ class RedisClient
   class Cluster
     ERR_ARG_NORMALIZATION = ->(arg) { Array[arg].flatten.reject { |e| e.nil? || (e.respond_to?(:empty?) && e.empty?) } }
 
+    private_constant :ERR_ARG_NORMALIZATION
+
     class InitialSetupError < ::RedisClient::Error
       def initialize(errors)
         msg = ERR_ARG_NORMALIZATION.call(errors).map(&:message).uniq.join(',')

lib/redis_client/cluster/key_slot_converter.rb

@@ -3,6 +3,7 @@
 class RedisClient
   class Cluster
     module KeySlotConverter
+      HASH_SLOTS = 16_384
       EMPTY_STRING = ''
       LEFT_BRACKET = '{'
       RIGHT_BRACKET = '}'
@@ -41,7 +42,8 @@ module KeySlotConverter
         0x6e17, 0x7e36, 0x4e55, 0x5e74, 0x2e93, 0x3eb2, 0x0ed1, 0x1ef0
       ].freeze
 
-      HASH_SLOTS = 16_384
+      private_constant :HASH_SLOTS, :EMPTY_STRING,
+                       :LEFT_BRACKET, :RIGHT_BRACKET, :XMODEM_CRC16_LOOKUP
 
       module_function
 

lib/redis_client/cluster/node.rb

@@ -24,6 +24,9 @@ class Node
       EMPTY_ARRAY = [].freeze
       EMPTY_HASH = {}.freeze
 
+      private_constant :USE_CHAR_ARRAY_SLOT, :SLOT_SIZE, :MIN_SLOT, :MAX_SLOT,
+                       :DEAD_FLAGS, :ROLE_FLAGS, :EMPTY_ARRAY, :EMPTY_HASH
+
       ReloadNeeded = Class.new(::RedisClient::Error)
 
       Info = Struct.new(
@@ -45,6 +48,8 @@ class CharArray
         BASE = ''
         PADDING = '0'
 
+        private_constant :BASE, :PADDING
+
         def initialize(size, elements)
           @elements = elements
           @string = String.new(BASE, encoding: Encoding::BINARY, capacity: size)

lib/redis_client/cluster/node/base_topology.rb

@@ -8,6 +8,8 @@ class BaseTopology
         EMPTY_HASH = {}.freeze
         EMPTY_ARRAY = [].freeze
 
+        private_constant :IGNORE_GENERIC_CONFIG_KEYS, :EMPTY_HASH, :EMPTY_ARRAY
+
         attr_reader :clients, :primary_clients, :replica_clients
 
         def initialize(pool, concurrent_worker, **kwargs)

lib/redis_client/cluster/node/latency_replica.rb

@@ -9,6 +9,8 @@ class LatencyReplica < BaseTopology
         DUMMY_LATENCY_MSEC = 100 * 1000 * 1000
         MEASURE_ATTEMPT_COUNT = 10
 
+        private_constant :DUMMY_LATENCY_MSEC, :MEASURE_ATTEMPT_COUNT
+
         def clients_for_scanning(seed: nil) # rubocop:disable Lint/UnusedMethodArgument
           @clients_for_scanning
         end

lib/redis_client/cluster/node_key.rb

@@ -8,6 +8,8 @@ class Cluster
     module NodeKey
       DELIMITER = ':'
 
+      private_constant :DELIMITER
+
       module_function
 
       def hashify(node_key)

lib/redis_client/cluster/normalized_cmd_name.rb

@@ -9,6 +9,8 @@ class NormalizedCmdName
 
       EMPTY_STRING = ''
 
+      private_constant :EMPTY_STRING
+
       def initialize
         @cache = {}
         @mutex = Mutex.new

lib/redis_client/cluster/pub_sub.rb

@@ -44,6 +44,8 @@ def spawn_worker(client, queue)
 
       BUF_SIZE = Integer(ENV.fetch('REDIS_CLIENT_PUBSUB_BUF_SIZE', 1024))
 
+      private_constant :BUF_SIZE
+
       def initialize(router, command_builder)
         @router = router
         @command_builder = command_builder