fix: rename environment variable name for thread limitation and remove its factor (#101)

Author: supercaracal

.github/workflows/test.yaml

@@ -198,6 +198,7 @@ jobs:
     env:
       REDIS_VERSION: '7.0.1'
       DOCKER_COMPOSE_FILE: 'docker-compose.yaml'
+      REDIS_CLIENT_MAX_THREADS: '37'
     steps:
       - name: Check out code
         uses: actions/checkout@v3

lib/redis_client/cluster/node.rb

@@ -16,7 +16,7 @@ class Node
       MIN_SLOT = 0
       MAX_SLOT = SLOT_SIZE - 1
       MAX_STARTUP_SAMPLE = 37
-      MAX_THREADS = Integer(ENV.fetch('MAX_THREADS', 5))
+      MAX_THREADS = Integer(ENV.fetch('REDIS_CLIENT_MAX_THREADS', 5))
       IGNORE_GENERIC_CONFIG_KEYS = %i[url host port path].freeze
 
       ReloadNeeded = Class.new(::RedisClient::Error)
@@ -43,9 +43,9 @@ def load_info(options, **kwargs) # rubocop:disable Metrics/AbcSize, Metrics/Cycl
           errors = Array.new(startup_size)
           startup_options = options.to_a.sample(MAX_STARTUP_SAMPLE).to_h
           startup_nodes = ::RedisClient::Cluster::Node.new(startup_options, **kwargs)
-          startup_nodes.each_slice(MAX_THREADS * 2).with_index do |chuncked_startup_nodes, chuncked_idx|
+          startup_nodes.each_slice(MAX_THREADS).with_index do |chuncked_startup_nodes, chuncked_idx|
             threads = chuncked_startup_nodes.each_with_index.map do |raw_client, idx|
-              Thread.new(raw_client, (MAX_THREADS * 2 * chuncked_idx) + idx) do |cli, i|
+              Thread.new(raw_client, (MAX_THREADS * chuncked_idx) + idx) do |cli, i|
                 Thread.pass
                 reply = cli.call('CLUSTER', 'NODES')
                 node_info_list[i] = parse_node_info(reply)
@@ -234,7 +234,7 @@ def call_multiple_nodes!(clients, method, command, args, &block)
       def try_map(clients) # rubocop:disable Metrics/MethodLength
         results = {}
         errors = {}
-        clients.each_slice(MAX_THREADS * 2) do |chuncked_clients|
+        clients.each_slice(MAX_THREADS) do |chuncked_clients|
           threads = chuncked_clients.map do |k, v|
             Thread.new(k, v) do |node_key, client|
               Thread.pass

lib/redis_client/cluster/node/latency_replica.rb

@@ -40,7 +40,7 @@ def any_replica_node_key(seed: nil)
         def measure_latencies(clients) # rubocop:disable Metrics/MethodLength
           latencies = {}
 
-          clients.each_slice(::RedisClient::Cluster::Node::MAX_THREADS * 2) do |chuncked_clients|
+          clients.each_slice(::RedisClient::Cluster::Node::MAX_THREADS) do |chuncked_clients|
             threads = chuncked_clients.map do |k, v|
               Thread.new(k, v) do |node_key, client|
                 Thread.pass

lib/redis_client/cluster/pipeline.rb

@@ -7,7 +7,7 @@ class RedisClient
   class Cluster
     class Pipeline
       ReplySizeError = Class.new(::RedisClient::Error)
-      MAX_THREADS = Integer(ENV.fetch('MAX_THREADS', 5))
+      MAX_THREADS = Integer(ENV.fetch('REDIS_CLIENT_MAX_THREADS', 5))
 
       def initialize(router, command_builder)
         @router = router
@@ -67,7 +67,7 @@ def empty?
       def execute # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
         all_replies = Array.new(@size)
         errors = {}
-        @grouped.each_slice(MAX_THREADS * 2) do |chuncked_grouped|
+        @grouped.each_slice(MAX_THREADS) do |chuncked_grouped|
           threads = chuncked_grouped.map do |k, v|
             Thread.new(@router, k, v) do |router, node_key, rows|
               Thread.pass